Fix buffer leak when overlapped operation fails to start (OS-Windows)

hyongtao-code · hyongtao-code · commit 0ebd149eb675 · 2025-12-28T22:12:15.000+08:00
diff --git a/Modules/overlapped.c b/Modules/overlapped.c
@@ -1806,7 +1806,7 @@ _overlapped_Overlapped_WSASendTo_impl(OverlappedObject *self, HANDLE handle,
         case ERROR_IO_PENDING:
             Py_RETURN_NONE;
         default:
-            self->type = TYPE_NOT_STARTED;
+            Overlapped_clear(self);
             return SetFromWindowsErr(err);
     }
 }
@@ -1873,7 +1873,7 @@ _overlapped_Overlapped_WSARecvFrom_impl(OverlappedObject *self,
     case ERROR_IO_PENDING:
         Py_RETURN_NONE;
     default:
-        self->type = TYPE_NOT_STARTED;
+        Overlapped_clear(self);
         return SetFromWindowsErr(err);
     }
 }
@@ -1940,7 +1940,7 @@ _overlapped_Overlapped_WSARecvFromInto_impl(OverlappedObject *self,
     case ERROR_IO_PENDING:
         Py_RETURN_NONE;
     default:
-        self->type = TYPE_NOT_STARTED;
+        Overlapped_clear(self);
         return SetFromWindowsErr(err);
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -1806,7 +1806,7 @@ _overlapped_Overlapped_WSASendTo_impl(OverlappedObject *self, HANDLE handle,`
`1806`	`1806`	`case ERROR_IO_PENDING:`
`1807`	`1807`	`Py_RETURN_NONE;`
`1808`	`1808`	`default:`
`1809`		`- self->type = TYPE_NOT_STARTED;`
	`1809`	`+ Overlapped_clear(self);`
`1810`	`1810`	`return SetFromWindowsErr(err);`
`1811`	`1811`	`}`
`1812`	`1812`	`}`
`@@ -1873,7 +1873,7 @@ _overlapped_Overlapped_WSARecvFrom_impl(OverlappedObject *self,`
`1873`	`1873`	`case ERROR_IO_PENDING:`
`1874`	`1874`	`Py_RETURN_NONE;`
`1875`	`1875`	`default:`
`1876`		`- self->type = TYPE_NOT_STARTED;`
	`1876`	`+ Overlapped_clear(self);`
`1877`	`1877`	`return SetFromWindowsErr(err);`
`1878`	`1878`	`}`
`1879`	`1879`	`}`
`@@ -1940,7 +1940,7 @@ _overlapped_Overlapped_WSARecvFromInto_impl(OverlappedObject *self,`
`1940`	`1940`	`case ERROR_IO_PENDING:`
`1941`	`1941`	`Py_RETURN_NONE;`
`1942`	`1942`	`default:`
`1943`		`- self->type = TYPE_NOT_STARTED;`
	`1943`	`+ Overlapped_clear(self);`
`1944`	`1944`	`return SetFromWindowsErr(err);`
`1945`	`1945`	`}`
`1946`	`1946`	`}`