Adding typing hints#773
Closed
ThosRTanner wants to merge 1 commit into
Closed
Conversation
houndci-bot
reviewed
Apr 19, 2026
ThosRTanner
force-pushed
the
add-typing-hints
branch
from
67b03cf to
4253758
Compare
houndci-bot
reviewed
Apr 19, 2026
ThosRTanner
force-pushed
the
add-typing-hints
branch
from
4253758 to
0739cf6
Compare
houndci-bot
reviewed
Apr 21, 2026
ThosRTanner
force-pushed
the
add-typing-hints
branch
from
0739cf6 to
48e9478
Compare
houndci-bot
reviewed
Apr 21, 2026
ThosRTanner
force-pushed
the
add-typing-hints
branch
from
48e9478 to
b2e245d
Compare
houndci-bot
reviewed
Apr 22, 2026
ThosRTanner
force-pushed
the
add-typing-hints
branch
3 times, most recently
from
339f1ec to
7edcb3b
Compare
houndci-bot
reviewed
Apr 22, 2026
ThosRTanner
force-pushed
the
add-typing-hints
branch
2 times, most recently
from
5da635b to
d67849a
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #773 +/- ##
==========================================
- Coverage 96.67% 95.58% -1.10%
==========================================
Files 27 27
Lines 3553 3895 +342
==========================================
+ Hits 3435 3723 +288
- Misses 118 172 +54 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ThosRTanner
force-pushed
the
add-typing-hints
branch
4 times, most recently
from
a9318af to
5168260
Compare
houndci-bot
reviewed
Apr 23, 2026
ThosRTanner
force-pushed
the
add-typing-hints
branch
5 times, most recently
from
7063c61 to
f62a077
Compare
houndci-bot
reviewed
Apr 28, 2026
ThosRTanner
force-pushed
the
add-typing-hints
branch
3 times, most recently
from
5035143 to
ec7dc06
Compare
Member
|
Really appreciate the tons of work you put into this PR. Can't wait to see it ready! |
Contributor
Author
|
ThosRTanner
force-pushed
the
add-typing-hints
branch
2 times, most recently
from
b724031 to
f027cf3
Compare
ThosRTanner
force-pushed
the
add-typing-hints
branch
2 times, most recently
from
09c3b2e to
b40a0da
Compare
houndci-bot
reviewed
May 9, 2026
ThosRTanner
force-pushed
the
add-typing-hints
branch
6 times, most recently
from
1d2790c to
91934ff
Compare
houndci-bot
reviewed
May 12, 2026
houndci-bot
reviewed
May 15, 2026
ThosRTanner
force-pushed
the
add-typing-hints
branch
from
9d67e4b to
b8854de
Compare
This adds nearly full type hinting, and enables all but two of the mypy checks that were enabled in the mypy section in pyproject.toml. I hope to address the remaining checks, but it was proving tricky to address some of the 'typing.Any' uses. Also if you enable deprecation checks with --enable-error-code=deprecated You'll get warnings if you use deprecated options (at least as far as I was able to spot them!) This addresses python-zk#647 but there's not entirely strict checking as yet. Although I've tried very hard not to change any code for this, some `return None` statements have been added, which has caused the code coverage to drop as apparently those return paths were not covered by the testing. Also I've been less polite with the testing, and have changed the code in a number of places, including dropping test classes that did nothing, and adding asserts here and there to keep mypy happy as it sometimes doesn't spot a value could have been changed. I've added FIXMEs to address some of the more egregious type warning suppression that I did to avoid doing code changes, and intend to address those in another PR. A note: I've also had to suppress some errors in flake8 and use more general 'type: ignore' suppressions than I'd like because hound CI does something very very odd and tries to parse the text in the [] of the type: ignore[] comments as python, and generates some very peculiar messages.
ThosRTanner
force-pushed
the
add-typing-hints
branch
from
d920398 to
ebb5665
Compare
Contributor
Author
|
closed in favour of 791 because this is now unreadable |
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #
Why is this needed?
Proposed Changes
Does this PR introduce any breaking change?