Skip to content

Commit 27eed7b

Browse files
authored
Merge pull request #230 from joe733/workshop
maint: reformats `card` module, fix typo
2 parents b6d4d7c + c0aecba commit 27eed7b

File tree

3 files changed

+201
-197
lines changed

3 files changed

+201
-197
lines changed

tests/test_btc_address.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
"""Test BTC address."""
22
# -*- coding: utf-8 -*-
33

4-
# standard
4+
# external
55
import pytest
66

77
# local

tests/test_card.py

Lines changed: 64 additions & 102 deletions
Original file line numberDiff line numberDiff line change
@@ -1,44 +1,29 @@
1+
"""Test Card."""
12
# -*- coding: utf-8 -*-
3+
4+
# external
25
import pytest
36

7+
# local
48
from validators import (
5-
amex,
9+
ValidationFailure,
610
card_number,
7-
diners,
8-
discover,
9-
jcb,
1011
mastercard,
1112
unionpay,
12-
ValidationFailure,
13-
visa
13+
discover,
14+
diners,
15+
visa,
16+
amex,
17+
jcb,
1418
)
1519

16-
visa_cards = [
17-
'4242424242424242',
18-
'4000002760003184'
19-
]
20-
mastercard_cards = [
21-
'5555555555554444',
22-
'2223003122003222'
23-
]
24-
amex_cards = [
25-
'378282246310005',
26-
'371449635398431'
27-
]
28-
unionpay_cards = [
29-
'6200000000000005'
30-
]
31-
diners_cards = [
32-
'3056930009020004',
33-
'36227206271667'
34-
]
35-
jcb_cards = [
36-
'3566002020360505'
37-
]
38-
discover_cards = [
39-
'6011111111111117',
40-
'6011000990139424'
41-
]
20+
visa_cards = ["4242424242424242", "4000002760003184"]
21+
mastercard_cards = ["5555555555554444", "2223003122003222"]
22+
amex_cards = ["378282246310005", "371449635398431"]
23+
unionpay_cards = ["6200000000000005"]
24+
diners_cards = ["3056930009020004", "36227206271667"]
25+
jcb_cards = ["3566002020360505"]
26+
discover_cards = ["6011111111111117", "6011000990139424"]
4227

4328

4429
@pytest.mark.parametrize(
@@ -51,140 +36,117 @@
5136
+ jcb_cards
5237
+ discover_cards,
5338
)
54-
def test_returns_true_on_valid_card_number(value):
39+
def test_returns_true_on_valid_card_number(value: str):
40+
"""Test returns true on valid card number."""
5541
assert card_number(value)
5642

5743

58-
@pytest.mark.parametrize('value', [
59-
'4242424242424240',
60-
'4000002760003180',
61-
'400000276000318X'
62-
])
63-
def test_returns_failed_on_valid_card_number(value):
44+
@pytest.mark.parametrize("value", ["4242424242424240", "4000002760003180", "400000276000318X"])
45+
def test_returns_failed_on_valid_card_number(value: str):
46+
"""Test returns failed on valid card number."""
6447
assert isinstance(card_number(value), ValidationFailure)
6548

6649

67-
@pytest.mark.parametrize('value', visa_cards)
68-
def test_returns_true_on_valid_visa(value):
50+
@pytest.mark.parametrize("value", visa_cards)
51+
def test_returns_true_on_valid_visa(value: str):
52+
"""Test returns true on valid visa."""
6953
assert visa(value)
7054

7155

7256
@pytest.mark.parametrize(
7357
"value",
74-
mastercard_cards
75-
+ amex_cards
76-
+ unionpay_cards
77-
+ diners_cards
78-
+ jcb_cards
79-
+ discover_cards,
58+
mastercard_cards + amex_cards + unionpay_cards + diners_cards + jcb_cards + discover_cards,
8059
)
81-
def test_returns_failed_on_valid_visa(value):
60+
def test_returns_failed_on_valid_visa(value: str):
61+
"""Test returns failed on valid visa."""
8262
assert isinstance(visa(value), ValidationFailure)
8363

8464

85-
@pytest.mark.parametrize('value', mastercard_cards)
86-
def test_returns_true_on_valid_mastercard(value):
65+
@pytest.mark.parametrize("value", mastercard_cards)
66+
def test_returns_true_on_valid_mastercard(value: str):
67+
"""Test returns true on valid mastercard."""
8768
assert mastercard(value)
8869

8970

9071
@pytest.mark.parametrize(
9172
"value",
92-
visa_cards
93-
+ amex_cards
94-
+ unionpay_cards
95-
+ diners_cards
96-
+ jcb_cards
97-
+ discover_cards,
73+
visa_cards + amex_cards + unionpay_cards + diners_cards + jcb_cards + discover_cards,
9874
)
99-
def test_returns_failed_on_valid_mastercard(value):
75+
def test_returns_failed_on_valid_mastercard(value: str):
76+
"""Test returns failed on valid mastercard."""
10077
assert isinstance(mastercard(value), ValidationFailure)
10178

10279

103-
@pytest.mark.parametrize('value', amex_cards)
104-
def test_returns_true_on_valid_amex(value):
80+
@pytest.mark.parametrize("value", amex_cards)
81+
def test_returns_true_on_valid_amex(value: str):
82+
"""Test returns true on valid amex."""
10583
assert amex(value)
10684

10785

10886
@pytest.mark.parametrize(
10987
"value",
110-
visa_cards
111-
+ mastercard_cards
112-
+ unionpay_cards
113-
+ diners_cards
114-
+ jcb_cards
115-
+ discover_cards,
88+
visa_cards + mastercard_cards + unionpay_cards + diners_cards + jcb_cards + discover_cards,
11689
)
117-
def test_returns_failed_on_valid_amex(value):
90+
def test_returns_failed_on_valid_amex(value: str):
91+
"""Test returns failed on valid amex."""
11892
assert isinstance(amex(value), ValidationFailure)
11993

12094

121-
@pytest.mark.parametrize('value', unionpay_cards)
122-
def test_returns_true_on_valid_unionpay(value):
95+
@pytest.mark.parametrize("value", unionpay_cards)
96+
def test_returns_true_on_valid_unionpay(value: str):
97+
"""Test returns true on valid unionpay."""
12398
assert unionpay(value)
12499

125100

126101
@pytest.mark.parametrize(
127102
"value",
128-
visa_cards
129-
+ mastercard_cards
130-
+ amex_cards
131-
+ diners_cards
132-
+ jcb_cards
133-
+ discover_cards,
103+
visa_cards + mastercard_cards + amex_cards + diners_cards + jcb_cards + discover_cards,
134104
)
135-
def test_returns_failed_on_valid_unionpay(value):
105+
def test_returns_failed_on_valid_unionpay(value: str):
106+
"""Test returns failed on valid unionpay."""
136107
assert isinstance(unionpay(value), ValidationFailure)
137108

138109

139-
@pytest.mark.parametrize('value', diners_cards)
140-
def test_returns_true_on_valid_diners(value):
110+
@pytest.mark.parametrize("value", diners_cards)
111+
def test_returns_true_on_valid_diners(value: str):
112+
"""Test returns true on valid diners."""
141113
assert diners(value)
142114

143115

144116
@pytest.mark.parametrize(
145117
"value",
146-
visa_cards
147-
+ mastercard_cards
148-
+ amex_cards
149-
+ unionpay_cards
150-
+ jcb_cards
151-
+ discover_cards,
118+
visa_cards + mastercard_cards + amex_cards + unionpay_cards + jcb_cards + discover_cards,
152119
)
153-
def test_returns_failed_on_valid_diners(value):
120+
def test_returns_failed_on_valid_diners(value: str):
121+
"""Test returns failed on valid diners."""
154122
assert isinstance(diners(value), ValidationFailure)
155123

156124

157-
@pytest.mark.parametrize('value', jcb_cards)
158-
def test_returns_true_on_valid_jcb(value):
125+
@pytest.mark.parametrize("value", jcb_cards)
126+
def test_returns_true_on_valid_jcb(value: str):
127+
"""Test returns true on valid jcb."""
159128
assert jcb(value)
160129

161130

162131
@pytest.mark.parametrize(
163132
"value",
164-
visa_cards
165-
+ mastercard_cards
166-
+ amex_cards
167-
+ unionpay_cards
168-
+ diners_cards
169-
+ discover_cards,
133+
visa_cards + mastercard_cards + amex_cards + unionpay_cards + diners_cards + discover_cards,
170134
)
171-
def test_returns_failed_on_valid_jcb(value):
135+
def test_returns_failed_on_valid_jcb(value: str):
136+
"""Test returns failed on valid jcb."""
172137
assert isinstance(jcb(value), ValidationFailure)
173138

174139

175-
@pytest.mark.parametrize('value', discover_cards)
176-
def test_returns_true_on_valid_discover(value):
140+
@pytest.mark.parametrize("value", discover_cards)
141+
def test_returns_true_on_valid_discover(value: str):
142+
"""Test returns true on valid discover."""
177143
assert discover(value)
178144

179145

180146
@pytest.mark.parametrize(
181147
"value",
182-
visa_cards
183-
+ mastercard_cards
184-
+ amex_cards
185-
+ unionpay_cards
186-
+ diners_cards
187-
+ jcb_cards,
148+
visa_cards + mastercard_cards + amex_cards + unionpay_cards + diners_cards + jcb_cards,
188149
)
189-
def test_returns_failed_on_valid_discover(value):
150+
def test_returns_failed_on_valid_discover(value: str):
151+
"""Test returns failed on valid discover."""
190152
assert isinstance(discover(value), ValidationFailure)

0 commit comments

Comments
 (0)