Skip to content

Commit 8085f44

Browse files
Introduced sticky navbar in navigation.html.
Introduced id's to enable navigation.
1 parent b745c51 commit 8085f44

File tree

3 files changed

+61
-14
lines changed

3 files changed

+61
-14
lines changed

_includes/navigation.html

Lines changed: 45 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,11 @@
1+
{% comment %}
12
<nav class="navigation navbar sticky-top navbar-light">
23
<div class="navigation__brand">
3-
<a class="navigation__brand-link navbar-brand" href="{{ '/' | prepend: site.baseurl }}">
4-
<img class="navigation__brand-img" src="{{ site.baseurl }}/static/images/site_logo/python_sprints_logo_triangles_flat_light_text_502x100px.png" alt="Python Sprints Logo">
4+
<a class="navigation__brand-link navbar-brand"
5+
href="{{ '/' | prepend: site.baseurl }}">
6+
<img class="navigation__brand-img"
7+
src="{{ site.baseurl }}/static/images/site_logo/python_sprints_logo_triangles_flat_light_text_502x100px.png"
8+
alt="Python Sprints Logo">
59
</a>
610
</div>
711

@@ -18,12 +22,47 @@
1822
</div>
1923
<div class="navigation__overlay">
2024
<div class="navigation__overlay-content">
21-
<a class="navigation__link" href="{{ '/' | prepend: site.baseurl }}">Home</a>
25+
<a class="navigation__link"
26+
href="{{ '/' | prepend: site.baseurl }}">Home</a>
2227
{% for page in site.pages %}
23-
{% if page.title %}
24-
<a class="navigation__link" href="{{ page.url | prepend: site.baseurl }}">{{ page.title }}</a>
25-
{% endif %}
28+
{% if page.title %}
29+
<a class="navigation__link"
30+
href="{{ page.url | prepend: site.baseurl }}">{{ page.title
31+
}}</a>
32+
{% endif %}
2633
{% endfor %}
2734
</div>
2835
</div>
2936
</nav>
37+
{% endcomment %}
38+
39+
40+
<nav class="navigation navbar navbar-expand-lg navbar-dark sticky-top">
41+
<a class="navigation__brand-link navbar-brand" href="{{ '/' | prepend: site.baseurl }}">
42+
<img class="navigation__brand-img"
43+
src="{{ site.baseurl }}/static/images/site_logo/python_sprints_logo_triangles_flat_light_text_502x100px.png"
44+
alt="Python Sprints Logo">
45+
</a>
46+
<button class="navbar-toggler" type="button" data-toggle="collapse"
47+
data-target="#navbarToggler"
48+
aria-controls="navbarToggler" aria-expanded="false"
49+
aria-label="Toggle navigation">
50+
<span class="navigation__icon navbar-toggler-icon"></span>
51+
</button>
52+
<div class="collapse navbar-collapse" id="navbarToggler">
53+
<ul class="navbar-nav ml-auto mt-2 mt-lg-0">
54+
<li class="nav-item active">
55+
<a class="navigation__link active nav-link" href="{{ '/' | prepend: site.baseurl }}">Home<span class="sr-only">(current)</span></a>
56+
</li>
57+
<li class="nav-item">
58+
<a class="navigation__link nav-link" href="#upcoming">Events</a>
59+
</li>
60+
<li class="nav-item">
61+
<a class="navigation__link nav-link" href="#chapters">Chapters</a>
62+
</li>
63+
<li class="nav-item">
64+
<a class="navigation__link nav-link" href="#about">About</a>
65+
</li>
66+
</ul>
67+
</div>
68+
</nav>

_sass/style.scss

Lines changed: 13 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
overflow-x: hidden;
66
/*Here I need to move the background image to slide under the navigation*/
77
/*Any smarter solutions are welcome!*/
8-
margin-top: -66px;
8+
//margin-top: -66px;
99

1010
}
1111

@@ -96,6 +96,10 @@ a {
9696
}
9797
}
9898

99+
.navigation {
100+
background: rgba(0, 0, 0, 0.9);
101+
}
102+
99103

100104
.navigation__content {
101105
@extend .page__background-img-container;
@@ -117,7 +121,7 @@ a {
117121
}
118122

119123
.navigation__brand-link {
120-
width: 100%;
124+
//width: 100%;
121125
}
122126

123127
.navigation__brand-img {
@@ -131,6 +135,10 @@ a {
131135
}
132136
}
133137

138+
.navigation__icon {
139+
color: grey;
140+
}
141+
134142
.navigation__button-open-container {
135143
border: black 1px solid;
136144
border-radius: 6px;
@@ -218,10 +226,10 @@ a {
218226

219227
.navigation__link {
220228
text-decoration: none;
221-
font-size: 2em;
229+
font-size: 1.25em;
222230
font-family: 'Encode Sans Expanded', sans-serif;
223-
color: $nav-link;
224-
display: block;
231+
color: $nav-link!important;
232+
//display: block;
225233
transition: all 0.5s ease-in-out;
226234
}
227235

index.html

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ <h2 class="navigation__subtitle">All About Open Source</h2>
3636
</div>
3737
</div>
3838
</div>
39-
<div class="upcoming-chapters-container container-fluid">
39+
<div id="upcoming" class="upcoming-chapters-container container-fluid">
4040
<div class="row">
4141
{% include events_array_generator.html future_events = true %}
4242
{% if posts.size > 0 %}
@@ -106,7 +106,7 @@ <h2 class="upcoming__event-subtitle"> {{ post.subtitle }}</h2>
106106
{% endif %}
107107

108108
<div class="{{ chapters_col }} no-padding-x">
109-
<section class="chapters">
109+
<section id="chapters" class="chapters">
110110
<div class="row container-fluid">
111111
<div class="col-12 no-padding-x">
112112
<div class="row">
@@ -166,7 +166,7 @@ <h2 class="chapters__card-title">{{ chapter.title }}</h2>
166166
{% endcomment %}
167167

168168
<!--Services section-->
169-
<section class="services">
169+
<section id="about" class="services">
170170
<div class="container-fluid">
171171
<div class="row">
172172
<div class="col-md-12">

0 commit comments

Comments
 (0)