Skip to content

Commit 1d36f5d

Browse files
Tested about page on mobiles and amended container / image sizes to fit contents better (to 90% of the view from 70%).
Introduced several classes to extend from for about page (image and title containers) - reduced amount of repeated code.
1 parent 0ef446e commit 1d36f5d

File tree

2 files changed

+49
-48
lines changed

2 files changed

+49
-48
lines changed

_pages/01_about.html

Lines changed: 3 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
title: About
44
permalink: /about/
55
---
6-
76
<section class="about">
87
<div class="about__background-img-container">
98
<picture>
@@ -28,7 +27,6 @@ <h2 class="about__page-subtitle">Our Goals, Our Story</h2>
2827
</div>
2928
</div>
3029
</div>
31-
3230
<div class="about__container container-fluid">
3331
<div class="row">
3432
<div class="col-12 no-padding-x">
@@ -43,7 +41,7 @@ <h2 class="about__paragraph-title-dark">Python Sprints Decoded</h2>
4341
We believe in sharing our skills for free to earn our good karma. If you are devoted to a particular open source project, please let us know, we could make a sprint dedicated to it!
4442
Inclusion is in the nature of our group and we want to make sure that no one is underrepresented. All people are welcome.
4543
</p>
46-
<h2 class="about__paragraph-title-dark-left">How It Started?</h2>
44+
<h2 class="about__paragraph-title-dark-left">How It Started</h2>
4745
<hr class="about__divider-left">
4846
<p class="about__paragraph-dark">
4947
Our group was founded in October 2017. As all things in life the beginnings were humble with only a handful of people collaborating but the word quickly spread and now we have nearly 600 members and counting.
@@ -53,26 +51,18 @@ <h2 class="about__paragraph-title-dark-left">How It Started?</h2>
5351
</div>
5452
</div>
5553
</div>
56-
57-
58-
59-
60-
<div class="about__img-container col-md-12">
61-
54+
<div class="about__img-outer-container col-md-12">
6255
<div class="about__img-top-container">
6356
<div class="about__img-top-title-container">
6457
<h2 class="about__img-top-title">Passion</h2>
6558
</div>
6659
</div>
67-
68-
6960
<div class="about__img-bot-container">
7061
<div class="about__img-bot-title-container">
7162
<h2 class="about__img-bot-title">Dedication</h2>
7263
</div>
7364
</div>
7465
</div>
75-
7666
<div class="about__container container-fluid">
7767
<div class="row">
7868
<div class="col-12 no-padding-x">
@@ -98,4 +88,4 @@ <h2 class="about__paragraph-title-dark-left">What Our Meetings Look Like?</h2>
9888
</div>
9989
</div>
10090
</div>
101-
</section>
91+
</section>

_sass/about.scss

Lines changed: 46 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,13 @@
2626
}
2727

2828
.about__container {
29-
max-width: 70%;
29+
max-width: 90%;
30+
}
31+
32+
@media (min-width: 1200px) {
33+
.about__container {
34+
max-width: 70%;
35+
}
3036
}
3137

3238
.about__section-title-left {
@@ -63,14 +69,18 @@
6369
font-size: 1.65em;
6470
}
6571

72+
.about__divider {
73+
@extend .services__divider;
74+
}
75+
6676
.about__divider-right {
77+
@extend .about__divider;
6778
margin-right: 0;
68-
width: 50%;
6979
}
7080

7181
.about__divider-left {
82+
@extend .about__divider;
7283
margin-left: 0;
73-
width: 50%;
7484
}
7585

7686
.about__paragraph-dark {
@@ -90,34 +100,42 @@
90100
}
91101

92102
.about__paragraph-img-main {
93-
width: 35%;
94-
float: left;
95-
margin-right: 1em;
96-
margin-bottom: 0.5em;
103+
width: 100%;
104+
margin-bottom: 1em;
97105
}
98106

99-
.about__img-container {
107+
@media (min-width: 768px) {
108+
.about__paragraph-img-main {
109+
float: left;
110+
width: 35%;
111+
margin-right: 1em;
112+
}
113+
}
114+
115+
.about__img-outer-container {
100116
position: relative;
101117
padding-bottom: 50%;
102118
margin-top: 10%;
103119
}
104120

105-
.about__img-top-container {
121+
.about__img-inner-container {
106122
position: absolute;
107-
top: 0;
108-
right: 15%;
109-
background: linear-gradient(rgba(0, 0, 0, 0.3), rgba(0, 0, 0, 0.3)), url("../images/about/top_img_passion_964x643px.JPG") no-repeat top center;
110-
background-size: cover;
111123
overflow: hidden;
112124
width: 40%;
113125
height: 50%;
114-
border: $old-white 2px groove;
126+
border: $old-white 1px solid;
115127
border-radius: 5px;
128+
background-size: cover!important;
116129
}
117130

118-
.about__img-top-title-container {
119-
position: relative;
131+
.about__img-top-container {
132+
@extend .about__img-inner-container;
120133
top: 0;
134+
right: 15%;
135+
background: linear-gradient(rgba(0, 0, 0, 0.3), rgba(0, 0, 0, 0.3)), url("../images/about/top_img_passion_964x643px.JPG") no-repeat top center;
136+
}
137+
138+
.about__img-title-container {
121139
z-index: 2;
122140
&::after {
123141
position: absolute;
@@ -126,10 +144,18 @@
126144
height: 100%;
127145
content: "";
128146
display: block;
129-
background: linear-gradient(rgba(0, 0, 0, 0.7), rgba(0, 0, 0, 0.7)), url("../images/about/top_img_passion_964x643px.JPG") no-repeat top center;
130-
background-size: cover;
131147
filter: blur(2px);
132148
z-index: -1;
149+
background-size: cover!important;
150+
}
151+
}
152+
153+
.about__img-top-title-container {
154+
@extend .about__img-title-container;
155+
position: relative;
156+
top: 0;
157+
&::after {
158+
background: linear-gradient(rgba(0, 0, 0, 0.7), rgba(0, 0, 0, 0.7)), url("../images/about/top_img_passion_964x643px.JPG") no-repeat top center;
133159
}
134160
}
135161

@@ -149,34 +175,19 @@
149175
}
150176

151177
.about__img-bot-container {
152-
position: absolute;
178+
@extend .about__img-inner-container;
153179
top: 40%;
154180
left: 15%;
155-
width: 40%;
156-
height: 50%;
157181
background: linear-gradient(rgba(0, 0, 0, 0.3), rgba(0, 0, 0, 0.3)), url("../images/about/bot_img_dedication_964x643px.JPG") no-repeat bottom center;
158-
background-size: cover;
159-
overflow: hidden;
160-
border: $old-white 2px groove;
161-
border-radius: 5px;
162182
}
163183

164184
.about__img-bot-title-container {
185+
@extend .about__img-title-container;
165186
position: absolute;
166187
width: 100%;
167188
bottom: 0;
168-
z-index: 2;
169189
&::after {
170-
position: absolute;
171-
top: 0;
172-
width: 100%;
173-
height: 100%;
174-
content: "";
175-
display: block;
176190
background: linear-gradient(rgba(0, 0, 0, 0.7), rgba(0, 0, 0, 0.7)), url("../images/about/bot_img_dedication_964x643px.JPG") no-repeat bottom center;
177-
background-size: cover;
178-
filter: blur(2px);
179-
z-index: -1;
180191
}
181192
}
182193

0 commit comments

Comments
 (0)