feat: ensure PatchOp.path is not none for remove operations

Author: azmeuk

scim2_models/rfc7644/patch_op.py

@@ -5,6 +5,8 @@
 
 from pydantic import Field
 from pydantic import field_validator
+from pydantic import model_validator
+from typing_extensions import Self
 
 from ..base import ComplexAttribute
 from ..base import Required
@@ -32,6 +34,12 @@ class Op(str, Enum):
     """The "path" attribute value is a String containing an attribute path
     describing the target of the operation."""
 
+    @model_validator(mode="after")
+    def validate_path(self) -> Self:
+        if self.path is None and self.op == PatchOperation.Op.remove:
+            raise ValueError("Op.path is required for remove operations")
+        return self
+
     value: Optional[Any] = None
 
     @field_validator("op", mode="before")

tests/test_patch_op.py

@@ -35,3 +35,29 @@ def test_validate_patchop_case_insensitivith():
                 "operations": [{"op": 42, "path": "userName", "value": "Rivard"}],
             },
         )
+
+
+def test_path_required_for_remove_operations():
+    PatchOp.model_validate(
+        {
+            "operations": [
+                {"op": "replace", "value": "foobar"},
+            ],
+        }
+    )
+    PatchOp.model_validate(
+        {
+            "operations": [
+                {"op": "add", "value": "foobar"},
+            ],
+        }
+    )
+
+    with pytest.raises(ValidationError):
+        PatchOp.model_validate(
+            {
+                "operations": [
+                    {"op": "remove", "value": "foobar"},
+                ],
+            }
+        )