refactor: implement _get_path_parts util

Author: azmeuk

scim2_models/messages/patch_op.py

@@ -22,6 +22,7 @@
 from ..urn import _resolve_path_to_target
 from ..utils import _extract_field_name
 from ..utils import _find_field_name
+from ..utils import _get_path_parts
 from ..utils import _validate_scim_path_syntax
 from .error import Error
 from .message import Message
@@ -346,7 +347,7 @@ def _set_value_at_path(
             target.__dict__.update(updated_target.__dict__)
             return True
 
-        path_parts = attr_path.split(".")
+        path_parts = _get_path_parts(attr_path)
         if len(path_parts) == 1:
             return cls._set_simple_attribute(target, path_parts[0], value, is_add)
 
@@ -471,7 +472,7 @@ def _remove_value_at_path(cls, resource: Resource[Any], path: str) -> bool:
         if not attr_path or not target:
             raise ValueError(Error.make_invalid_path_error().detail)
 
-        parent_attr, *path_parts = attr_path.split(".")
+        parent_attr, *path_parts = _get_path_parts(attr_path)
         field_name = _find_field_name(type(target), parent_attr)
         if not field_name:
             raise ValueError(Error.make_no_target_error().detail)

scim2_models/urn.py

@@ -4,6 +4,7 @@
 from typing import Union
 
 from .base import BaseModel
+from .utils import _get_path_parts
 from .utils import _normalize_attribute_name
 
 if TYPE_CHECKING:
@@ -52,7 +53,7 @@ def _normalize_path(model: Optional[type["BaseModel"]], path: str) -> tuple[str,
 
 def _validate_model_attribute(model: type["BaseModel"], attribute_base: str) -> None:
     """Validate that an attribute name or a sub-attribute path exist for a given model."""
-    attribute_name, *sub_attribute_blocks = attribute_base.split(".")
+    attribute_name, *sub_attribute_blocks = _get_path_parts(attribute_base)
     sub_attribute_base = ".".join(sub_attribute_blocks)
 
     aliases = {field.validation_alias for field in model.model_fields.values()}

scim2_models/utils.py

@@ -195,3 +195,7 @@ def _find_field_name(model_class: type["BaseModel"], attr_name: str) -> Optional
             return field_key
 
     return None
+
+
+def _get_path_parts(path: str) -> list[str]:
+    return path.split(".")