fix: a few typing issues

Author: azmeuk

scim2_models/base.py

@@ -111,6 +111,7 @@ def check_request_attributes_mutability(
         """Check and fix that the field mutability is expected according to the requests validation context, as defined in :rfc:`RFC7643 §7 <7653#section-7>`."""
         if (
             not info.context
+            or not info.field_name
             or not info.context.get("scim")
             or not Context.is_request(info.context["scim"])
         ):

scim2_models/rfc7643/schema.py

@@ -70,14 +70,17 @@ def make_python_model(
             Field(default=[obj.id]),
         )
 
+    if not obj.name:
+        raise ValueError("Schema or Attribute 'name' must be defined")
+
     model_name = to_pascal(to_snake(obj.name))
-    model = create_model(model_name, __base__=base, **pydantic_attributes)
+    model: type[T] = create_model(model_name, __base__=base, **pydantic_attributes)  # type: ignore[call-overload]
 
     # Set the ComplexType class as a member of the model
     # e.g. make Member an attribute of Group
     for attr_name in model.model_fields:
         attr_type = model.get_field_root_type(attr_name)
-        if is_complex_attribute(attr_type):
+        if attr_type and is_complex_attribute(attr_type):
             setattr(model, attr_type.__name__, attr_type)
 
     return model
@@ -207,7 +210,7 @@ def from_python(cls, pytype) -> str:
     """When an attribute is of type "complex", "subAttributes" defines a set of
     sub-attributes."""
 
-    def to_python(self) -> Optional[tuple[Any, Field]]:
+    def to_python(self) -> Optional[tuple[Any, Any]]:
         """Build tuple suited to be passed to pydantic 'create_model'."""
         if not self.name or not self.type:
             return None
@@ -290,7 +293,7 @@ def get_attribute(self, attribute_name: str) -> Optional[Attribute]:
                 return attribute
         return None
 
-    def __getitem__(self, name: str) -> "Attribute":
+    def __getitem__(self, name: str) -> "Attribute":  # type: ignore[override]
         """Find an attribute by its name."""
         if attribute := self.get_attribute(name):
             return attribute

tests/test_dynamic_schemas.py

@@ -2,13 +2,17 @@
 from typing import Annotated
 from typing import Optional
 
+import pytest
+
 from scim2_models.annotations import Required
 from scim2_models.context import Context
 from scim2_models.rfc7643.enterprise_user import EnterpriseUser
 from scim2_models.rfc7643.group import Group
 from scim2_models.rfc7643.resource import Resource
 from scim2_models.rfc7643.resource_type import ResourceType
+from scim2_models.rfc7643.schema import Attribute
 from scim2_models.rfc7643.schema import Schema
+from scim2_models.rfc7643.schema import make_python_model
 from scim2_models.rfc7643.service_provider_config import ServiceProviderConfig
 from scim2_models.rfc7643.user import User
 
@@ -177,3 +181,20 @@ class Bar(Foo):
             "urn:ietf:params:scim:schemas:core:2.0:Schema",
         ],
     }
+
+
+def test_make_python_model_validates_name():
+    """Test that make_python_model raises an exception when obj.name is not defined."""
+    # Test with Schema object without name
+    schema = Schema(id="urn:example:schema")
+    schema.name = None
+
+    with pytest.raises(ValueError, match="Schema or Attribute 'name' must be defined"):
+        make_python_model(schema, Resource)
+
+    # Test with Attribute object without name
+    attribute = Attribute(type=Attribute.Type.string)
+    attribute.name = None
+
+    with pytest.raises(ValueError, match="Schema or Attribute 'name' must be defined"):
+        make_python_model(attribute, Resource)