PiCamera: use ROI field names instead of tuple index for readability

David Miguel Susano Pinto · David Miguel Susano Pinto · commit bcd3d86df7e2 · 2023-08-22T13:44:11.000+01:00
diff --git a/microscope/cameras/picamera.py b/microscope/cameras/picamera.py
@@ -267,8 +267,8 @@ def soft_trigger(self):
                 self.camera.capture(output, format="yuv", use_video_port=False)
                 self._queue.put(
                     output.array[
-                        self.roi[1] : self.roi[1] + self.roi[3],
-                        self.roi[0] : self.roi[0] + self.roi[2],
+                        self.roi.top : self.roi.top + self.roi.height,
+                        self.roi.left : self.roi.left + self.roi.width,
                         0,
                     ]
                 )

Original file line number	Diff line number	Diff line change
`@@ -267,8 +267,8 @@ def soft_trigger(self):`
`267`	`267`	`self.camera.capture(output, format="yuv", use_video_port=False)`
`268`	`268`	`self._queue.put(`
`269`	`269`	`output.array[`
`270`		`- self.roi[1] : self.roi[1] + self.roi[3],`
`271`		`- self.roi[0] : self.roi[0] + self.roi[2],`
	`270`	`+ self.roi.top : self.roi.top + self.roi.height,`
	`271`	`+ self.roi.left : self.roi.left + self.roi.width,`
`272`	`272`	`0,`
`273`	`273`	`]`
`274`	`274`	`)`