BaseTestDeviceServer: use exitcode, not is_alive, to determine if process terminated.

carandraug · carandraug · commit 86497ac9f350 · 2021-04-13T03:54:26.000+01:00
diff --git a/microscope/testsuite/test_device_server.py b/microscope/testsuite/test_device_server.py
@@ -144,8 +144,8 @@ def setUp(self):
     def tearDown(self):
         self.process.terminate()
         self.process.join(self.TIMEOUT)
-        self.assertFalse(
-            self.process.is_alive(), "deviceserver not dead after SIGTERM"
+        self.assertIsNotNone(
+            self.process.exitcode, "deviceserver not dead after SIGTERM"
         )
 
 

Original file line number	Diff line number	Diff line change
`@@ -144,8 +144,8 @@ def setUp(self):`
`144`	`144`	`def tearDown(self):`
`145`	`145`	`self.process.terminate()`
`146`	`146`	`self.process.join(self.TIMEOUT)`
`147`		`- self.assertFalse(`
`148`		`- self.process.is_alive(), "deviceserver not dead after SIGTERM"`
	`147`	`+ self.assertIsNotNone(`
	`148`	`+ self.process.exitcode, "deviceserver not dead after SIGTERM"`
`149`	`149`	`)`
`150`	`150`
`151`	`151`