device-server: use FileHandler instead of RotatingFileHandler for logs.

Automatically rotating the logs, with RotatingFileHandler could be
useful.  However, we are not actually rotating anything because we are
not setting its maxBytes or backupCount values and by default it never
rotates.  We might as well use the standard FileHandler and come back
to RotatingFileHandler later when we actually configure it.

Author: carandraug

microscope/device_server.py

@@ -47,8 +47,7 @@
 import typing
 from collections.abc import Iterable
 from dataclasses import dataclass
-from logging import StreamHandler
-from logging.handlers import RotatingFileHandler
+from logging import FileHandler, StreamHandler
 from threading import Thread
 
 import Pyro4
@@ -353,7 +352,7 @@ def run(self):
 
         pyro_daemon = Pyro4.Daemon(port=port, host=host)
 
-        log_handler = RotatingFileHandler(
+        log_handler = FileHandler(
             os.path.join(
                 self._options.logging_dir,
                 "%s_%s_%s.log" % (cls_name, host, port),
@@ -407,7 +406,7 @@ def serve_devices(devices, options: DeviceServerOptions, exit_event=None):
 
     root_logger = logging.getLogger()
 
-    log_handler = RotatingFileHandler("__MAIN__.log")
+    log_handler = FileHandler("__MAIN__.log")
     log_handler.setFormatter(_create_log_formatter("device-server"))
     root_logger.addHandler(log_handler)
 

microscope/testsuite/test_device_server.py

@@ -84,7 +84,7 @@ def null_logs(*args, **kwargs):
         return logging.NullHandler()
 
     no_file = unittest.mock.patch(
-        "microscope.device_server.RotatingFileHandler", null_logs
+        "microscope.device_server.FileHandler", null_logs
     )
     no_stream = unittest.mock.patch(
         "microscope.device_server.StreamHandler", null_logs