No longer storing Cmd/CommandSet instance in subcommand parsers. Using id(instance) instead.

Author: kmvanbrunt

cmd2/cmd2.py

@@ -950,11 +950,12 @@ def unregister_command_set(self, cmdset: CommandSet) -> None:
 
     def _check_uninstallable(self, cmdset: CommandSet) -> None:
         def check_parser_uninstallable(parser: argparse.ArgumentParser) -> None:
+            cmdset_id = id(cmdset)
             for action in parser._actions:
                 if isinstance(action, argparse._SubParsersAction):
                     for subparser in action.choices.values():
-                        attached_cmdset = getattr(subparser, constants.PARSER_ATTR_COMMANDSET, None)
-                        if attached_cmdset is not None and attached_cmdset is not cmdset:
+                        attached_cmdset_id = getattr(subparser, constants.PARSER_ATTR_COMMANDSET_ID, None)
+                        if attached_cmdset_id is not None and attached_cmdset_id != cmdset_id:
                             raise CommandSetRegistrationError(
                                 'Cannot uninstall CommandSet when another CommandSet depends on it'
                             )
@@ -1049,7 +1050,7 @@ def find_subcommand(action: argparse.ArgumentParser, subcmd_names: list[str]) ->
             subcmd_parser.set_defaults(**defaults)
 
             # Set what instance the handler is bound to
-            setattr(subcmd_parser, constants.PARSER_ATTR_COMMANDSET, cmdset)
+            setattr(subcmd_parser, constants.PARSER_ATTR_COMMANDSET_ID, id(cmdset))
 
             # Find the argparse action that handles subcommands
             for action in target_parser._actions:

cmd2/constants.py

@@ -47,8 +47,8 @@
 SUBCMD_ATTR_NAME = 'subcommand_name'
 SUBCMD_ATTR_ADD_PARSER_KWARGS = 'subcommand_add_parser_kwargs'
 
-# arpparse attribute linking to command set instance
-PARSER_ATTR_COMMANDSET = 'command_set'
+# arpparse attribute uniquely identifying the command set instance
+PARSER_ATTR_COMMANDSET_ID = 'command_set_id'
 
 # custom attributes added to argparse Namespaces
 NS_ATTR_SUBCMD_HANDLER = '__subcmd_handler__'