From a70010e7fb88461b39f9bd4009bdd3c66834f38b Mon Sep 17 00:00:00 2001 From: James Aguilar Date: Sun, 4 Jan 2026 02:31:39 +0000 Subject: [PATCH] ev3: Don't request hardware version. This feature doesn't seem to work when it is issued from a USB3 bus. See https://github.com/pybricks/support/issues/2515. Since we don't use the version, removing the command is harmless. --- src/firmware/sagas.ts | 24 +----------------------- 1 file changed, 1 insertion(+), 23 deletions(-) diff --git a/src/firmware/sagas.ts b/src/firmware/sagas.ts index 7ac4fea7..bff25c32 100644 --- a/src/firmware/sagas.ts +++ b/src/firmware/sagas.ts @@ -1,5 +1,5 @@ // SPDX-License-Identifier: MIT -// Copyright (c) 2020-2025 The Pybricks Authors +// Copyright (c) 2020-2026 The Pybricks Authors import { FirmwareReader, @@ -1206,28 +1206,6 @@ function* handleFlashEV3(action: ReturnType): Generator return [new DataView(reply.payload), undefined]; } - const [version, versionError] = yield* sendCommand(0xf6); // get version - - if (versionError) { - yield* put( - alertsShowAlert('alerts', 'unexpectedError', { - error: ensureError(versionError), - }), - ); - yield* put(firmwareDidFailToFlashEV3()); - yield* cleanup(); - return; - } - - defined(version); - - console.debug( - `EV3 bootloader version: ${version.getUint32( - 0, - true, - )}, HW version: ${version.getUint32(4, true)}`, - ); - // FIXME: should be called much earlier. yield* put(didStart());