replace ir_down with longwave_down

Author: cwhanse

pvlib/pvsystem.py

@@ -414,7 +414,7 @@ def get_iam(self, aoi, iam_model='physical'):
 
     @_unwrap_single_value
     def get_cell_temperature(self, poa_global, temp_air, wind_speed, model,
-                             effective_irradiance=None, ir_down=None):
+                             effective_irradiance=None, longwave_down=None):
         """
         Determine cell temperature using the method specified by ``model``.
 
@@ -438,7 +438,7 @@ def get_cell_temperature(self, poa_global, temp_air, wind_speed, model,
             The irradiance that is converted to photocurrent in W/m^2.
             Only used for some models.
 
-        ir_down: numeric or tuple of numeric, optional
+        longwave_down: numeric or tuple of numeric, optional
             Downwelling infrared radiation from the sky, measured on a
             horizontal surface in W/m^2. Only used in ``'faiman_rad'`` model.
 
@@ -464,16 +464,18 @@ def get_cell_temperature(self, poa_global, temp_air, wind_speed, model,
         # Not used for all models, but Array.get_cell_temperature handles it
         effective_irradiance = self._validate_per_array(effective_irradiance,
                                                         system_wide=True)
-        ir_down = self._validate_per_array(ir_down, system_wide=True)
+        longwave_down = self._validate_per_array(longwave_down,
+                                                 system_wide=True)
 
         return tuple(
             array.get_cell_temperature(poa_global, temp_air, wind_speed,
-                                       model, effective_irradiance, ir_down)
+                                       model, effective_irradiance,
+                                       longwave_down)
             for array, poa_global, temp_air, wind_speed, effective_irradiance,
-            ir_down
+            longwave_down
             in zip(
                 self.arrays, poa_global, temp_air, wind_speed,
-                effective_irradiance, ir_down
+                effective_irradiance, longwave_down
             )
         )
 
@@ -1215,7 +1217,7 @@ def get_iam(self, aoi, iam_model='physical'):
             raise ValueError(model + ' is not a valid IAM model')
 
     def get_cell_temperature(self, poa_global, temp_air, wind_speed, model,
-                             effective_irradiance=None, ir_down=None):
+                             effective_irradiance=None, longwave_down=None):
         """
         Determine cell temperature using the method specified by ``model``.
 
@@ -1240,7 +1242,7 @@ def get_cell_temperature(self, poa_global, temp_air, wind_speed, model,
             The irradiance that is converted to photocurrent in W/m^2.
             Only used for some models.
 
-        ir_down: numeric, optional
+        longwave_down: numeric, optional
             Downwelling infrared radiation from the sky, measured on a
             horizontal surface in W/m^2. Only used in ``'faiman_rad'`` model.
 
@@ -1287,7 +1289,7 @@ def get_cell_temperature(self, poa_global, temp_air, wind_speed, model,
                                      self.temperature_model_parameters)
         elif model == 'faiman_rad':
             func = functools.partial(temperature.faiman_rad,
-                                     ir_down=ir_down)
+                                     longwave_down=longwave_down)
             required = ()
             optional = _build_kwargs(['u0', 'u1',
                                       'sky_view', 'emissivity'],

tests/test_pvsystem.py

@@ -495,7 +495,7 @@ def test_PVSystem_faiman_celltemp(mocker):
 
 
 def test_PVSystem_faiman_rad_celltemp(mocker):
-    ir_down = 50  # arbitrary value
+    longwave_down = 50  # arbitrary value
     # default values, u0 and u1 being adjusted in same proportion as in
     # https://www.osti.gov/servlets/purl/1884890/ (not suggested, just example)
     u0, u1 = 25.0*0.86, 6.84*0.88
@@ -509,10 +509,11 @@ def test_PVSystem_faiman_rad_celltemp(mocker):
     temps = 25
     irrads = 1000
     winds = 1
-    out = system.get_cell_temperature(irrads, temps, winds, ir_down=ir_down,
+    out = system.get_cell_temperature(irrads, temps, winds,
+                                      longwave_down=longwave_down,
                                       model='faiman_rad')
     temperature.faiman_rad.assert_called_once_with(irrads, temps, winds,
-                                                   ir_down, u0, u1,
+                                                   longwave_down, u0, u1,
                                                    sky_view, emissivity)
     assert_allclose(out, 48.6, atol=1e-1)