(CONT-786) Rubocop unsafe Auto Fixes 1-3

- Lint/NonAtomicFileOperation
- Performance/StringInclude
- Performance/UnfreezeString

Author: david22swan

.rubocop_todo.yml

@@ -12,13 +12,6 @@ Lint/DuplicateBranch:
   Exclude:
     - 'tooling/kube_tool/other_params.rb'
 
-# Offense count: 2
-# This cop supports unsafe autocorrection (--autocorrect-all).
-Lint/NonAtomicFileOperation:
-  Exclude:
-    - 'tooling/kube_tool/clean_up.rb'
-    - 'tooling/kube_tool/create_certs.rb'
-
 # Offense count: 1
 # Configuration parameters: AllowedPatterns.
 # AllowedPatterns: (?-mix:(exactly|at_least|at_most)\(\d+\)\.times)
@@ -88,18 +81,6 @@ Naming/MethodParameterName:
 Naming/VariableName:
   Enabled: false
 
-# Offense count: 1
-# This cop supports unsafe autocorrection (--autocorrect-all).
-Performance/StringInclude:
-  Exclude:
-    - 'spec/spec_helper_acceptance_local.rb'
-
-# Offense count: 2
-# This cop supports unsafe autocorrection (--autocorrect-all).
-Performance/UnfreezeString:
-  Exclude:
-    - 'tooling/kube_tool/other_params.rb'
-
 # Offense count: 16
 # Configuration parameters: Prefixes, AllowedPatterns.
 # Prefixes: when, with, without

spec/spec_helper_acceptance_local.rb

@@ -249,7 +249,7 @@ def execute_agent(role)
       run_shell('sudo apt install docker.io -y')
       run_shell('systemctl start docker.service')
       run_shell('systemctl enable docker.service')
-      if %r{ubuntu-1604-lts}.match?(family)
+      if family.include?('ubuntu-1604-lts')
         run_shell('sudo ufw disable')
       else
         # Workaround for debian as the strech repositories do not have updated kubernetes packages

tooling/kube_tool/clean_up.rb

@@ -4,7 +4,7 @@
 class CleanUp
   def self.all(files)
     files.each do |x|
-      FileUtils.rm_f(x) if File.exist?(x)
+      FileUtils.rm_f(x)
     end
   end
 

tooling/kube_tool/create_certs.rb

@@ -56,7 +56,7 @@ def etcd_certificates
       server = servers.split(':')
       hostname = server[0]
       ip = server[1]
-      FileUtils.rm_f("#{hostname}.yaml") if File.exist?("#{hostname}.yaml")
+      FileUtils.rm_f("#{hostname}.yaml")
       puts 'Creating etcd peer and server certificates'
       csr = { CN: "etcd-#{hostname}", hosts: etcd_server_ips, key: { algo: @opts[:ca_algo], size: @opts[:key_size] } }
       File.write('config.json', csr.to_json)

tooling/kube_tool/other_params.rb

@@ -41,8 +41,8 @@ def self.create(opts)
     end
 
     x = opts[:etcd_initial_cluster].split(',')
-    cluster = String.new
-    peers = String.new
+    cluster = +''
+    peers = +''
     bootstrap_controller = x[0]
     z = bootstrap_controller.split(':')
     controller_address = "#{z[1]}:6443"