Merge pull request #45 from pulsar-edit/disable-worker-manager

Soft-disable `WorkerManager`…

Author: savetheclocktower

lib/git-shell-out-strategy.js

@@ -379,7 +379,7 @@ export default class GitShellOutStrategy {
   }
 
   executeGitCommand(args, options, marker = null) {
-    if (process.env.ATOM_GITHUB_INLINE_GIT_EXEC || !WorkerManager.getInstance().isReady()) {
+    if (process.env.ATOM_GITHUB_INLINE_GIT_EXEC || !WorkerManager.isEnabled() || !WorkerManager.getInstance().isReady()) {
       marker && marker.mark('nexttick');
 
       let childPid;

lib/worker-manager.js

@@ -7,9 +7,24 @@ import {Emitter, Disposable, CompositeDisposable} from 'event-kit';
 
 import {getPackageRoot, autobind} from './helpers';
 
+// Whether `WorkerManager` is enabled. If not, it will never mark itself as
+// ready, and `GitShellOutStrategy` will use its fallback approach of spawning
+// `git` processes more directly via `dugite` (which works fine). This allows
+// us to bail without even trying to start another renderer process.
+//
+// NOTE: For the reasons explained in
+// https://github.com/pulsar-edit/github/pull/45, `WorkerManager` is now
+// permanently disabled. This automatically triggers the fallback strategy
+// described above and is a prelude to the removal of `WorkerManager` entirely.
+const ENABLED = false;
+
 export default class WorkerManager {
   static instance = null;
 
+  static isEnabled () {
+    return ENABLED;
+  }
+
   static getInstance() {
     if (!this.instance) {
       this.instance = new WorkerManager();
@@ -123,6 +138,7 @@ export class Worker {
     this.completedOperationCount = 0;
     this.sick = false;
 
+    if (!ENABLED) return;
     this.rendererProcess = new RendererProcess({
       loadUrl: this.getLoadUrl(operationCountLimit),
       onData: this.handleDataReceived,
@@ -137,6 +153,7 @@ export class Worker {
   }
 
   isReady() {
+    if (!ENABLED) return false;
     return this.rendererProcess.isReady();
   }