Fix linting

`ruff check --diff` implies `--fix-only` and therefor ignores some rules.

Author: mdellweg

.github/workflows/lint.yml

@@ -32,7 +32,7 @@ jobs:
         run: |
           pip3 install ruff
           ruff format --check --diff plugin-template utils.py
-          ruff check --diff plugin-template utils.py
+          ruff check plugin-template utils.py
       - name: "Bootstrap catdog plugin"
         working-directory: "plugin_template"
         run: |
@@ -54,7 +54,7 @@ jobs:
 
       - name: "Lint code"
         run: |
-          ruff check --diff
+          ruff check
 
       - name: "Check for common gettext problems"
         run: |

plugin-template

@@ -511,6 +511,7 @@ def remove_deprecated_files(plugin_root_dir: Path, sections: list[str]) -> None:
 def reformat_files(plugin_root_dir: Path, config: dict[str, t.Any]) -> None:
     try:
         subprocess.run(["ruff", "format"], cwd=plugin_root_dir)
+        subprocess.run(["ruff", "check", "--select", "I", "--fix"], cwd=plugin_root_dir)
     except FileNotFoundError:
         pass
 

templates/ci/Makefile.j2

@@ -9,7 +9,7 @@ lint:
 	yamllint -s -d '{extends: relaxed, rules: {line-length: disable}}' .github/workflows
 	bump-my-version bump --dry-run release
 	ruff format --check --diff
-	ruff check --diff
+	ruff check
 	{%- if check_manifest %}
 	check-manifest
 	{%- endif %}

templates/github/.github/workflows/lint.yml.j2

@@ -34,7 +34,7 @@ jobs:
 
       - name: "Lint code"
         run: |
-          ruff check --diff
+          ruff check
       {%- if check_gettext %}
 
       - name: "Check for common gettext problems"