fix: clarify cache miss log message#434
Open
Adichapati wants to merge 1 commit into
Open
Conversation
When cached entries fail the Vary header check, we were logging deserialization failed even though the entry is valid but unusable for the current request. Adjust the wording to avoid confusion in troubleshooting output.
There was a problem hiding this comment.
Pull request overview
This PR updates CacheControl’s cache-miss debug logging to better reflect cases where a cached entry exists but cannot be used for the current request (e.g., Vary mismatch), aligning the message with the behavior described in issue #209.
Changes:
- Adjust the
_load_from_cache()debug log message whenserializer.loads(...)returnsNone.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| result = self.serializer.loads(request, cache_data, body_file) | ||
| if result is None: | ||
| logger.debug("Cache entry deserialization failed, entry ignored") | ||
| logger.debug("Cache entry not usable for request, entry ignored") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Closes #209