Skip to content

Django 4.0 support, loosen version constraints#83

Open
tony wants to merge 11 commits into
psevensas:masterfrom
tony:tn-django-4
Open

Django 4.0 support, loosen version constraints#83
tony wants to merge 11 commits into
psevensas:masterfrom
tony:tn-django-4

Conversation

@tony

@tony tony commented Jan 5, 2022

Copy link
Copy Markdown

Fixes #82

@tony

tony commented Feb 1, 2022

Copy link
Copy Markdown
Author

@datadvance Can you take a look at this PR for Django 4.0 support please?

@tony tony mentioned this pull request Feb 6, 2022
@Luferov

Luferov commented Feb 19, 2022

Copy link
Copy Markdown

@prokher could you check PR and accept. Thanks!

@tony

tony commented Feb 22, 2022

Copy link
Copy Markdown
Author

@datadvance Please give this a look if you can!

@danielknightgaynor

Copy link
Copy Markdown

@datadvance I'd also appreciate this being reviewed/merged 👍

Comment thread .github/workflows/tests.yml
Comment thread pyproject.toml Outdated
@tony tony changed the title Django 4.0 support Django 4.0 support, loosen version constraints May 24, 2022
@tony

tony commented May 24, 2022

Copy link
Copy Markdown
Author

@datadvance any possibility you could take a look?

@Luferov

Luferov commented May 24, 2022

Copy link
Copy Markdown

Hey, @tony create you own library from this and push it to pypi.

@helgihg

helgihg commented Oct 28, 2022

Copy link
Copy Markdown

Any news on when this could be merged? I've looked through the changes and they're not that complicated. Django 4.0 has been out for almost a year now and 4.1 is already out.

@Ronjea

Ronjea commented Nov 2, 2022

Copy link
Copy Markdown

It would be lovely to have this out as a package 🚀

@boomdizz

Copy link
Copy Markdown

Seeing these. Could someone provide an ETA for when support for the latest packages would be available?

django-channels-graphql-ws 0.9.1 requires channels<4,>=3, but you have channels 4.0.0 which is incompatible.
django-channels-graphql-ws 0.9.1 requires Django<4,>=3, but you have django 4.1.2 which is incompatible.
django-channels-graphql-ws 0.9.1 requires graphene<3.0,>=2.1, but you have graphene 3.1.1 which is incompatible.

@boomdizz

boomdizz commented Feb 28, 2023

Copy link
Copy Markdown

Another dependency that likely needs to be updated:

  File "<snipped>/lib/python3.10/site-packages/channels_graphql_ws/__init__.py", line 29, in <module>
    from .client import GraphqlWsClient, GraphqlWsResponseError
  File "<snipped>/lib/python3.10/site-packages/channels_graphql_ws/client.py", line 30, in <module>
    from .transport import GraphqlWsTransport
  File "<snipped>/lib/python3.10/site-packages/channels_graphql_ws/transport.py", line 31, in <module>
    from . import graphql_ws_consumer
  File "<snipped>/lib/python3.10/site-packages/channels_graphql_ws/graphql_ws_consumer.py", line 57, in <module>
    import graphql.execution.executors.asyncio
ModuleNotFoundError: No module named 'graphql.execution.executors'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Django 4.0

9 participants