Simplify _warn_proplot, remove action

Author: lukelbd

proplot/config.py

@@ -1597,19 +1597,16 @@ def _load_file(self, path):
                     try:
                         ikw_proplot, ikw_matplotlib = self._get_item_dicts(key, val)
                     except KeyError:
-                        warnings._warn_proplot(
-                            f'Invalid rc key {key!r} on {message}.', 'default'
-                        )
+                        warnings.simplefilter('default', warnings.ProplotWarning)
+                        warnings._warn_proplot(f'Invalid rc key {key!r} on {message}.')
                         continue
                     except ValueError as err:
-                        warnings._warn_proplot(
-                            f'Invalid rc val {val!r} for key {key!r} on {message}: {err}', 'default'  # noqa: E501
-                        )
+                        warnings.simplefilter('default', warnings.ProplotWarning)
+                        warnings._warn_proplot(f'Invalid rc val {val!r} for key {key!r} on {message}: {err}')  # noqa: E501
                         continue
                     except warnings.ProplotWarning as err:
-                        warnings._warn_proplot(
-                            f'Outdated rc key {key!r} on {message}: {err}', 'default'
-                        )
+                        warnings.simplefilter('default', warnings.ProplotWarning)
+                        warnings._warn_proplot(f'Outdated rc key {key!r} on {message}: {err}')  # noqa: E501
                         warnings.simplefilter('ignore', warnings.ProplotWarning)
                         ikw_proplot, ikw_matplotlib = self._get_item_dicts(key, val)
                 # Update the settings

proplot/internals/warnings.py

@@ -35,7 +35,7 @@ def _next_release():
     return string
 
 
-def _warn_proplot(message, action=None):
+def _warn_proplot(message):
     """
     Emit a `ProplotWarning` and show the stack level outside of matplotlib and
     proplot. This is adapted from matplotlib's warning system.
@@ -47,10 +47,7 @@ def _warn_proplot(message, action=None):
             break  # this is the first external frame
         frame = frame.f_back
         stacklevel += 1
-    with warnings.catch_warnings():
-        if action:  # used internally
-            warnings.simplefilter(action, ProplotWarning)
-        warnings.warn(message, ProplotWarning, stacklevel=stacklevel)
+    warnings.warn(message, ProplotWarning, stacklevel=stacklevel)
 
 
 def _rename_objs(version, **kwargs):