From 6782c65ef666564515b07de6af784aacea233a71 Mon Sep 17 00:00:00 2001 From: Gregor Zeitlinger Date: Tue, 17 Feb 2026 08:07:14 +0100 Subject: [PATCH] fix: remove version manipulation from build-release.sh Release-please already sets the correct versions in pom.xml files at the tagged commit, so the sed-based SNAPSHOT replacement in build-release.sh is redundant and would fail (no SNAPSHOT to find). Remove the TAG argument/env and version manipulation logic, keeping only the Maven package command. Update release and test-release-build workflows to stop passing the TAG env var. Signed-off-by: Gregor Zeitlinger --- .github/workflows/release.yml | 2 -- .github/workflows/test-release-build.yml | 3 --- .mise/tasks/build-release.sh | 18 ++---------------- 3 files changed, 2 insertions(+), 21 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index e950b4b36..93d32c188 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -30,8 +30,6 @@ jobs: - name: Build release version run: mise run build-release - env: - TAG: ${{ github.ref_name }} - name: Set up Apache Maven Central uses: actions/setup-java@be666c2fcd27ec809703dec50e508c2fdc7f6654 # v5 diff --git a/.github/workflows/test-release-build.yml b/.github/workflows/test-release-build.yml index 2d7d27ef3..f8de00d8c 100644 --- a/.github/workflows/test-release-build.yml +++ b/.github/workflows/test-release-build.yml @@ -32,6 +32,3 @@ jobs: BASE_URL: "/client_java" - name: Build release version run: mise run build-release - env: - # don't use the current snapshot version, to test a more realistic release - TAG: ${{ github.run_number }} diff --git a/.mise/tasks/build-release.sh b/.mise/tasks/build-release.sh index 9ddb48e53..620dca77a 100755 --- a/.mise/tasks/build-release.sh +++ b/.mise/tasks/build-release.sh @@ -1,22 +1,8 @@ #!/usr/bin/env bash #MISE description="Build release package" -#USAGE arg "[tag]" env="TAG" set -euo pipefail -PARENT_POM="prometheus-metrics-parent/pom.xml" -CURRENT_VERSION=$(sed -n 's/.*\(.*-SNAPSHOT\)<\/version>.*/\1/p' "$PARENT_POM" | head -1) - -if [[ -z "$CURRENT_VERSION" ]]; then - echo "ERROR: could not find SNAPSHOT version in $PARENT_POM" >&2 - exit 1 -fi - -# shellcheck disable=SC2154 # is set by mise -VERSION=${usage_tag:-$CURRENT_VERSION} -VERSION=${VERSION#v} - -find . -name 'pom.xml' -exec \ - sed -i "s/${CURRENT_VERSION}<\/version>/${VERSION}<\/version>/g" {} + -mvn -B package -P 'release,!default,!examples-and-integration-tests' -Dmaven.test.skip=true -Dgpg.skip=true +mvn -B package -P 'release,!default,!examples-and-integration-tests' \ + -Dmaven.test.skip=true -Dgpg.skip=true