Typo in Example Code - textToContours()

[yiyujin]

Most appropriate sections of the p5.js website?

Home

What is your operating system?

None

Web browser and version

No response

Actual Behavior

Need to fix // -> / in textToContours

Expected Behavior

Need to fix // -> / in textToContours

Steps to reproduce

No response

Would you like to work on the issue?

[perminder-17]

Hi @yiyujin thanks for raising this. I don't think this to be a doc or typo error. The line is coming from this part of the codebase

https://github.com/processing/p5.js/blob/6d4540ca85c461aaeedc7a85582b8fad685a8227/src/type/p5.Font.js#L321

And it's perfectly correct. We need to look at the extra slash (/) why it's coming here. Definitely a bug :) Thanks for reporting.

[davepagurek]

Almost certainly from this:

p5.js-website/src/scripts/builders/reference.ts

Lines 163 to 165 in 813ae4d

	return Array.isArray(content)
	? content.map((ex) => ex.replaceAll("assets/", "/assets/").replaceAll(/\n$/g, ""))
	: content.replaceAll("assets/", "/assets/");

Old example code used "assets/..." for URLs, which break in the current site's multi-directory URL structure, so they needed to be replaced with "/assets/...". However, the find-and-replace is also matching the "/[assets/]..." part of an already good URL. Maybe we need to update the replaceAll to match the /(?<!\/)assets/? That's a regex with a negative lookbehind asserting that it only matches assets when not preceded by a slash?