[CodeMirror v6] fix stale react state in cm6 update listener#4156
Merged
khanniie merged 2 commits intoJun 6, 2026
Merged
Conversation
skyash-dev
changed the title
khanniie
approved these changes
Jun 6, 2026
khanniie
left a comment
khanniie
left a comment
Member
There was a problem hiding this comment.
A few small comments but thank you so much for identifying the issue and submitting a fix so fast! Really glad you caught this : D
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
Fixes #4155
the listener is installed when file states are created and can outlive subsequent React renders. as a result, callbacks could read stale values for autorefresh, project, and files.
Changes
Testing