User model: fragile use of arguments.length in findByEmailOrUsername

[Nixxx19]

p5.js version

No response

What is your operating system?

None

Web browser and version

No response

Actual Behavior

findByEmailOrUsername() uses arguments.length === 2 to decide whether to use case-insensitive behavior. This is fragile: it can break with default parameters, extra arguments, or different call styles. Modern practice is to use explicit parameter checks.

Location: server/models/user.ts – findByEmailOrUsername() line 291

Expected Behavior

Case-insensitive behavior should be controlled by explicitly checking the options parameter (e.g. options && typeof options === 'object' && options.caseInsensitive) instead of arguments.length.

Steps to reproduce

Steps:

1. Open server/models/user.ts and find findByEmailOrUsername.
2. Note the condition arguments.length === 2 && typeof options === 'object' && options.caseInsensitive.
3. Consider calling with default args or from a wrapper that passes a third argument; behavior may be inconsistent.

Snippet:

// user.ts - findByEmailOrUsername
if (
  arguments.length === 2 &&
  typeof options === 'object' &&
  options.caseInsensitive
) {
  // case-insensitive branch
}

[Nixxx19]

Hi @raclim!
I'd love to work on this issue and submit the fix for it. I'll replace the arguments.length === 2 check in findByEmailOrUsername() with an explicit check on the options parameter so behavior is stable across call styles.

[raclim]

That makes sense to me, assigned!

[Nixxx19]

thanks @raclim! i've created pr #3931 with the fix. please take a look whenever you get a chance, thank you!

[SinhaS12]

We can just Control the behavior only by checking the options parameter. @Nixxx19

[Nixxx19]

@SinhaS12 Yep, that’s exactly what this PR does, it removes the arguments.length check and controls the behavior only via the options parameter.