-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Description
p5.js version
1.11.11
What is your operating system?
Windows
Web browser and version
Chrome 143.0.7499.170
Actual Behavior
I noticed an issue where the "Add to Collection" feature does not work as expected when a logged-in user is viewing an Example sketch. Even though the user is logged in, clicking the button does not add the sketch to the collection, and there is no feedback (success or error message) provided to the user.
Steps to Reproduce
-
Log in to the p5.js Web Editor.
-
Go to File > Examples.
-
Select any example sketch (e.g., Structure > Setup and Draw).
-
Click on File > Add to Collection.
-
Select a collection from the list (if the modal opens) or observe the behavior.
-
Navigate to Dashboard > Collections.
Actual Behavior
The sketch is not added to the collection. (Optional: If the modal doesn't even open, write: "The Add to Collection modal does not trigger/open.") (Optional: If you see errors in the console, mention them here).
https://drive.google.com/file/d/1V1IXHwBRYFIaUfvAzuvtF7SZQxDAHF3h/view?usp=sharing
Expected Behavior
Expected Behavior
One of the following should happen:
- The Example sketch should be added to the collection successfully.
- OR The user should be prompted to Duplicate the sketch first (since Examples are read-only).
- OR The "Add to Collection" option should be Disabled for Example sketches until the user duplicates them.
Steps to Reproduce
- Log in to the p5.js Web Editor (https://editor.p5js.org/).
- Navigate to File > Examples.
- Select any example sketch to load it (e.g., Structure > Setup and Draw).
- Once the example loads, click File > Add to Collection.
- Observe the behavior: The "Add to Collection" page/modal does not appear, or if it does, selecting a collection does not actually add the sketch.
- Navigate to Hello, [Username]! > My Collections.
- Check the collection; the example sketch is missing.
Are you working on this issue ?
Yes