From cf73529c6c7eb0d13051a59af1913d89e49b6f87 Mon Sep 17 00:00:00 2001 From: Yas Okada Date: Thu, 26 Jun 2025 09:22:24 +0000 Subject: [PATCH 1/2] fix spec --- .gitignore | 2 ++ soapforce.gemspec | 1 + spec/lib/client_spec.rb | 4 ++-- spec/support/fixture_helpers.rb | 5 +++-- 4 files changed, 8 insertions(+), 4 deletions(-) diff --git a/.gitignore b/.gitignore index 1ca9e23..82560a7 100644 --- a/.gitignore +++ b/.gitignore @@ -16,3 +16,5 @@ test/tmp test/version_tmp tmp vendor + +.idea diff --git a/soapforce.gemspec b/soapforce.gemspec index ab83abe..247b95d 100644 --- a/soapforce.gemspec +++ b/soapforce.gemspec @@ -19,6 +19,7 @@ Gem::Specification.new do |spec| spec.require_paths = ["lib"] spec.add_runtime_dependency "savon", ">= 2.3.0", '< 3.0.0' + spec.add_runtime_dependency "nori", "2.6.0" spec.add_development_dependency 'rspec', '>= 2.14.0', '< 4.0.0' spec.add_development_dependency 'webmock', '>=2.3.2' diff --git a/spec/lib/client_spec.rb b/spec/lib/client_spec.rb index 3e4e7c1..e8633d9 100644 --- a/spec/lib/client_spec.rb +++ b/spec/lib/client_spec.rb @@ -319,7 +319,7 @@ describe "#update" do before(:each) do - @body = "Opportunity003ABCDESOAPForce Opportunity2013-08-12Closed Won" + @body = "Opportunity003ABCDESOAPForce Opportunity2013-08-12Closed Won" @params = { Id: '003ABCDE', Name: "SOAPForce Opportunity", CloseDate: '2013-08-12', StageName: 'Closed Won' } end @@ -356,7 +356,7 @@ describe "#upsert" do before(:each) do - @body = "External_Id__cOpportunityNew Opportunity2013-08-12ProspectingOpportunity003ABCDEExisting Opportunity2013-08-12Closed Won" + @body = "External_Id__cOpportunityNew Opportunity2013-08-12ProspectingOpportunity003ABCDEExisting Opportunity2013-08-12Closed Won" @objects = [ { Name: "New Opportunity", CloseDate: '2013-08-12', StageName: 'Prospecting' }, { Id: '003ABCDE', Name: "Existing Opportunity", CloseDate: '2013-08-12', StageName: 'Closed Won' } diff --git a/spec/support/fixture_helpers.rb b/spec/support/fixture_helpers.rb index 539508b..ee662c3 100644 --- a/spec/support/fixture_helpers.rb +++ b/spec/support/fixture_helpers.rb @@ -32,8 +32,9 @@ def soap_envelope(headers, body) xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:tns="urn:partner.soap.sforce.com" xmlns:env="http://schemas.xmlsoap.org/soap/envelope/" - xmlns:ins0="urn:sobject.partner.soap.sforce.com" - xmlns:ins1="urn:fault.partner.soap.sforce.com"> + xmlns:soap="http://schemas.xmlsoap.org/wsdl/soap/" + xmlns:fns="urn:fault.partner.soap.sforce.com" + xmlns:ens="urn:sobject.partner.soap.sforce.com"> #{soap_headers(headers)} #{body} From 48cd454b758d71cef14e8b6bd22a8bfdf8be8ca2 Mon Sep 17 00:00:00 2001 From: Yas Okada Date: Thu, 26 Jun 2025 09:29:38 +0000 Subject: [PATCH 2/2] add CI --- .github/workflows/rspec.yml | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+) create mode 100644 .github/workflows/rspec.yml diff --git a/.github/workflows/rspec.yml b/.github/workflows/rspec.yml new file mode 100644 index 0000000..8a1def1 --- /dev/null +++ b/.github/workflows/rspec.yml @@ -0,0 +1,26 @@ +name: rspec + +on: + pull_request: + branches: [ main, master ] + workflow_dispatch: + +jobs: + test: + runs-on: ubuntu-latest + + steps: + - name: Checkout code + uses: actions/checkout@v4 + + - name: Set up Ruby + uses: ruby/setup-ruby@v1 + with: + ruby-version: 3.1.6 + bundler-cache: true + + - name: Install dependencies + run: bundle install + + - name: Run RSpec tests + run: bundle exec rspec