The plugin "prettier-plugin-sh" could not be loaded

[murdos]

Using experimental cli show errors The plugin "prettier-plugin-sh" could not be loaded when https://www.npmjs.com/package/prettier-plugin-sh is configured.

Without experimental cli, everything works fine.

[JounQin]

It could because we're using undocumented async parser/printer?

[43081j]

@fabiospampinato we could probably improve the error message here too, to include more information

Not necessarily a stack trace but maybe the inner error text

[JounQin]

@fabiospampinato we could probably improve the error message here too, to include more information

Not necessarily a stack trace but maybe the inner error text

Yes, see also prettier/prettier#17669 (comment), no useful message and fallback to defaults are unacceptable IMO.

[43081j]

the underlying error is this:

Error: No "exports" main defined in /code/prettier/node_modules/prettier-plugin-sh/package.json

to do resolution, we use import-meta-resolve (to support node <20)

but it seems import-meta-resolve defaults conditions to undefined.

this means it will look for a default export (e.g. exports.default or exports['.'].default) and bail if there isn't one

so there's a few possible solutions here:

1. prettier-plugin-sh could define a default export (it probably should do this regardless, actually)
2. we could define conditions as ["import", "require"] (since we ultimately import(path) anyway, so leave it up to node to figure out CJS)
3. we could leave conditions as undefined, because that technically is correct but maybe reduces quality of DX

[JounQin]

I think we should add conditions to simulate how Node.js (import.meta.resolve) works itself?

https://nodejs.org/dist/latest-v14.x/docs/api/esm.html#esm_resolver_algorithm

[43081j]

good catch!

defaultConditions is the conditional environment name array, ["node", "import"].

so yes, we should do this 👍

[JounQin]

https://github.com/wooorm/import-meta-resolve#moduleresolvespecifier-parent-conditions-preservesymlinks

I think it could be an unexpected behavior from import-meta-resolve.