From f27263c98167a73352566266be43cd834690d2c5 Mon Sep 17 00:00:00 2001 From: pkaczmarek Date: Fri, 3 Oct 2025 16:16:36 +0200 Subject: [PATCH 1/3] Eplanning: Add support for adomain --- .../org/prebid/server/bidder/eplanning/EplanningBidder.java | 1 + .../prebid/server/bidder/eplanning/model/HbResponseAd.java | 5 +++++ .../prebid/server/bidder/eplanning/EplanningBidderTest.java | 4 ++++ .../openrtb2/eplanning/test-auction-eplanning-response.json | 3 +++ .../it/openrtb2/eplanning/test-eplanning-bid-response-1.json | 5 ++++- 5 files changed, 17 insertions(+), 1 deletion(-) diff --git a/src/main/java/org/prebid/server/bidder/eplanning/EplanningBidder.java b/src/main/java/org/prebid/server/bidder/eplanning/EplanningBidder.java index 09c607d7451..12d45393a0d 100644 --- a/src/main/java/org/prebid/server/bidder/eplanning/EplanningBidder.java +++ b/src/main/java/org/prebid/server/bidder/eplanning/EplanningBidder.java @@ -396,6 +396,7 @@ private static BidderBid mapToBidderBid(HbResponseSpace hbResponseSpace, HbRespo .price(new BigDecimal(hbResponseAd.getPrice())) .adm(hbResponseAd.getAdM()) .crid(hbResponseAd.getCrId()) + .adomain(hbResponseAd.getAdomain()) .w(hbResponseAd.getWidth()) .h(hbResponseAd.getHeight()) .build(), diff --git a/src/main/java/org/prebid/server/bidder/eplanning/model/HbResponseAd.java b/src/main/java/org/prebid/server/bidder/eplanning/model/HbResponseAd.java index 2d5cee971b0..201116a96c6 100644 --- a/src/main/java/org/prebid/server/bidder/eplanning/model/HbResponseAd.java +++ b/src/main/java/org/prebid/server/bidder/eplanning/model/HbResponseAd.java @@ -4,6 +4,8 @@ import lombok.Builder; import lombok.Value; +import java.util.List; + @Builder @Value public class HbResponseAd { @@ -23,6 +25,9 @@ public class HbResponseAd { @JsonProperty("crid") String crId; + @JsonProperty("adomain") + List adomain; + @JsonProperty("w") Integer width; diff --git a/src/test/java/org/prebid/server/bidder/eplanning/EplanningBidderTest.java b/src/test/java/org/prebid/server/bidder/eplanning/EplanningBidderTest.java index 8b94f14c737..93741ea60a3 100644 --- a/src/test/java/org/prebid/server/bidder/eplanning/EplanningBidderTest.java +++ b/src/test/java/org/prebid/server/bidder/eplanning/EplanningBidderTest.java @@ -615,6 +615,7 @@ public void makeBidsShouldReturnBannerBidWithExpectedFields() throws JsonProcess .price("3.3") .adM("some-adm") .crId("CR-ID") + .adomain(List.of("test.com")) .width(500) .height(300) .build())))))); @@ -632,6 +633,7 @@ public void makeBidsShouldReturnBannerBidWithExpectedFields() throws JsonProcess .price(BigDecimal.valueOf(3.3)) .adm("some-adm") .crid("CR-ID") + .adomain(List.of("test.com")) .w(500) .h(300) .build(); @@ -653,6 +655,7 @@ public void makeBidsShouldReturnBannerBidIfMissingAdunitCode() throws JsonProces .price("3.3") .adM("some-adm") .crId("CR-ID") + .adomain(List.of("test.com")) .width(1) .height(1) .build())))))); @@ -671,6 +674,7 @@ public void makeBidsShouldReturnBannerBidIfMissingAdunitCode() throws JsonProces .price(BigDecimal.valueOf(3.3)) .adm("some-adm") .crid("CR-ID") + .adomain(List.of("test.com")) .w(1) .h(1) .build(); diff --git a/src/test/resources/org/prebid/server/it/openrtb2/eplanning/test-auction-eplanning-response.json b/src/test/resources/org/prebid/server/it/openrtb2/eplanning/test-auction-eplanning-response.json index aee270657c9..9cb422d3532 100644 --- a/src/test/resources/org/prebid/server/it/openrtb2/eplanning/test-auction-eplanning-response.json +++ b/src/test/resources/org/prebid/server/it/openrtb2/eplanning/test-auction-eplanning-response.json @@ -11,6 +11,9 @@ "adm": "
test
", "adid": "imp_id", "crid": "crid", + "adomain": [ + "test.com" + ], "w": 600, "h": 300, "ext": { diff --git a/src/test/resources/org/prebid/server/it/openrtb2/eplanning/test-eplanning-bid-response-1.json b/src/test/resources/org/prebid/server/it/openrtb2/eplanning/test-eplanning-bid-response-1.json index cbc840b6081..32ab1558597 100644 --- a/src/test/resources/org/prebid/server/it/openrtb2/eplanning/test-eplanning-bid-response-1.json +++ b/src/test/resources/org/prebid/server/it/openrtb2/eplanning/test-eplanning-bid-response-1.json @@ -9,10 +9,13 @@ "adm": "
test
", "crid": "crid", "id": "imp_id", + "adomain": [ + "test.com" + ], "w": 600, "h": 300 } ] } ] -} \ No newline at end of file +} From 9c2f3ddf107024114fec564e0f6801b2ce3d1508 Mon Sep 17 00:00:00 2001 From: pkaczmarek Date: Mon, 6 Oct 2025 17:03:23 +0200 Subject: [PATCH 2/3] fix comments --- .../org/prebid/server/bidder/eplanning/EplanningBidder.java | 2 +- .../prebid/server/bidder/eplanning/model/HbResponseAd.java | 6 ++---- .../prebid/server/bidder/eplanning/EplanningBidderTest.java | 4 ++-- .../openrtb2/eplanning/test-eplanning-bid-response-1.json | 4 +--- 4 files changed, 6 insertions(+), 10 deletions(-) diff --git a/src/main/java/org/prebid/server/bidder/eplanning/EplanningBidder.java b/src/main/java/org/prebid/server/bidder/eplanning/EplanningBidder.java index 12d45393a0d..99beb0538bf 100644 --- a/src/main/java/org/prebid/server/bidder/eplanning/EplanningBidder.java +++ b/src/main/java/org/prebid/server/bidder/eplanning/EplanningBidder.java @@ -396,7 +396,7 @@ private static BidderBid mapToBidderBid(HbResponseSpace hbResponseSpace, HbRespo .price(new BigDecimal(hbResponseAd.getPrice())) .adm(hbResponseAd.getAdM()) .crid(hbResponseAd.getCrId()) - .adomain(hbResponseAd.getAdomain()) + .adomain(Collections.singletonList(hbResponseAd.getAdom())) .w(hbResponseAd.getWidth()) .h(hbResponseAd.getHeight()) .build(), diff --git a/src/main/java/org/prebid/server/bidder/eplanning/model/HbResponseAd.java b/src/main/java/org/prebid/server/bidder/eplanning/model/HbResponseAd.java index 201116a96c6..605f8d9d076 100644 --- a/src/main/java/org/prebid/server/bidder/eplanning/model/HbResponseAd.java +++ b/src/main/java/org/prebid/server/bidder/eplanning/model/HbResponseAd.java @@ -4,8 +4,6 @@ import lombok.Builder; import lombok.Value; -import java.util.List; - @Builder @Value public class HbResponseAd { @@ -25,8 +23,8 @@ public class HbResponseAd { @JsonProperty("crid") String crId; - @JsonProperty("adomain") - List adomain; + @JsonProperty() + String adom; @JsonProperty("w") Integer width; diff --git a/src/test/java/org/prebid/server/bidder/eplanning/EplanningBidderTest.java b/src/test/java/org/prebid/server/bidder/eplanning/EplanningBidderTest.java index 93741ea60a3..6db871bc6bd 100644 --- a/src/test/java/org/prebid/server/bidder/eplanning/EplanningBidderTest.java +++ b/src/test/java/org/prebid/server/bidder/eplanning/EplanningBidderTest.java @@ -615,7 +615,7 @@ public void makeBidsShouldReturnBannerBidWithExpectedFields() throws JsonProcess .price("3.3") .adM("some-adm") .crId("CR-ID") - .adomain(List.of("test.com")) + .adom("test.com") .width(500) .height(300) .build())))))); @@ -655,7 +655,7 @@ public void makeBidsShouldReturnBannerBidIfMissingAdunitCode() throws JsonProces .price("3.3") .adM("some-adm") .crId("CR-ID") - .adomain(List.of("test.com")) + .adom("test.com") .width(1) .height(1) .build())))))); diff --git a/src/test/resources/org/prebid/server/it/openrtb2/eplanning/test-eplanning-bid-response-1.json b/src/test/resources/org/prebid/server/it/openrtb2/eplanning/test-eplanning-bid-response-1.json index 32ab1558597..25396475d2a 100644 --- a/src/test/resources/org/prebid/server/it/openrtb2/eplanning/test-eplanning-bid-response-1.json +++ b/src/test/resources/org/prebid/server/it/openrtb2/eplanning/test-eplanning-bid-response-1.json @@ -9,9 +9,7 @@ "adm": "
test
", "crid": "crid", "id": "imp_id", - "adomain": [ - "test.com" - ], + "adom": "test.com", "w": 600, "h": 300 } From 11450ad1ca0dec3bcbf45b3387f5ce01fc03fc26 Mon Sep 17 00:00:00 2001 From: pkaczmarek Date: Tue, 7 Oct 2025 07:07:32 +0200 Subject: [PATCH 3/3] fix comments --- .../org/prebid/server/bidder/eplanning/model/HbResponseAd.java | 1 - src/test/java/org/prebid/server/it/EplanningTest.java | 2 +- ...ing-bid-response-1.json => test-eplanning-bid-response.json} | 0 3 files changed, 1 insertion(+), 2 deletions(-) rename src/test/resources/org/prebid/server/it/openrtb2/eplanning/{test-eplanning-bid-response-1.json => test-eplanning-bid-response.json} (100%) diff --git a/src/main/java/org/prebid/server/bidder/eplanning/model/HbResponseAd.java b/src/main/java/org/prebid/server/bidder/eplanning/model/HbResponseAd.java index 605f8d9d076..d951070a537 100644 --- a/src/main/java/org/prebid/server/bidder/eplanning/model/HbResponseAd.java +++ b/src/main/java/org/prebid/server/bidder/eplanning/model/HbResponseAd.java @@ -23,7 +23,6 @@ public class HbResponseAd { @JsonProperty("crid") String crId; - @JsonProperty() String adom; @JsonProperty("w") diff --git a/src/test/java/org/prebid/server/it/EplanningTest.java b/src/test/java/org/prebid/server/it/EplanningTest.java index 432456d8526..d8e95e45b2f 100644 --- a/src/test/java/org/prebid/server/it/EplanningTest.java +++ b/src/test/java/org/prebid/server/it/EplanningTest.java @@ -18,7 +18,7 @@ public class EplanningTest extends IntegrationTest { public void openrtb2AuctionShouldRespondWithBidsFromEplanning() throws IOException, JSONException { // given WIRE_MOCK_RULE.stubFor(get(urlPathEqualTo("/eplanning-exchange/12345/1/www.example.com/ROS")) - .willReturn(aResponse().withBody(jsonFrom("openrtb2/eplanning/test-eplanning-bid-response-1.json")))); + .willReturn(aResponse().withBody(jsonFrom("openrtb2/eplanning/test-eplanning-bid-response.json")))); // when final Response response = responseFor("openrtb2/eplanning/test-auction-eplanning-request.json", diff --git a/src/test/resources/org/prebid/server/it/openrtb2/eplanning/test-eplanning-bid-response-1.json b/src/test/resources/org/prebid/server/it/openrtb2/eplanning/test-eplanning-bid-response.json similarity index 100% rename from src/test/resources/org/prebid/server/it/openrtb2/eplanning/test-eplanning-bid-response-1.json rename to src/test/resources/org/prebid/server/it/openrtb2/eplanning/test-eplanning-bid-response.json