From d35eaeae9a926a1caf54ed91c3e04c984388cf2d Mon Sep 17 00:00:00 2001 From: antonbabak Date: Fri, 25 Jul 2025 15:24:55 +0200 Subject: [PATCH 1/3] New Akcelo Adapter --- .../server/bidder/akcelo/AkceloBidder.java | 192 ++++++++++++ .../ext/request/akcelo/ExtImpAkcelo.java | 16 + .../config/bidder/AkceloConfiguration.java | 43 +++ src/main/resources/bidder-config/akcelo.yaml | 12 + .../static/bidder-params/akcelo.json | 24 ++ .../bidder/akcelo/AkceloBidderTest.java | 293 ++++++++++++++++++ .../java/org/prebid/server/it/AkceloTest.java | 32 ++ .../org/prebid/server/it/AlgorixTest.java | 3 - .../akcelo/test-akcelo-bid-request.json | 68 ++++ .../akcelo/test-akcelo-bid-response.json | 40 +++ .../akcelo/test-auction-akcelo-request.json | 34 ++ .../akcelo/test-auction-akcelo-response.json | 43 +++ .../server/it/test-application.properties | 2 + 13 files changed, 799 insertions(+), 3 deletions(-) create mode 100644 src/main/java/org/prebid/server/bidder/akcelo/AkceloBidder.java create mode 100644 src/main/java/org/prebid/server/proto/openrtb/ext/request/akcelo/ExtImpAkcelo.java create mode 100644 src/main/java/org/prebid/server/spring/config/bidder/AkceloConfiguration.java create mode 100644 src/main/resources/bidder-config/akcelo.yaml create mode 100644 src/main/resources/static/bidder-params/akcelo.json create mode 100644 src/test/java/org/prebid/server/bidder/akcelo/AkceloBidderTest.java create mode 100644 src/test/java/org/prebid/server/it/AkceloTest.java create mode 100644 src/test/resources/org/prebid/server/it/openrtb2/akcelo/test-akcelo-bid-request.json create mode 100644 src/test/resources/org/prebid/server/it/openrtb2/akcelo/test-akcelo-bid-response.json create mode 100644 src/test/resources/org/prebid/server/it/openrtb2/akcelo/test-auction-akcelo-request.json create mode 100644 src/test/resources/org/prebid/server/it/openrtb2/akcelo/test-auction-akcelo-response.json diff --git a/src/main/java/org/prebid/server/bidder/akcelo/AkceloBidder.java b/src/main/java/org/prebid/server/bidder/akcelo/AkceloBidder.java new file mode 100644 index 00000000000..428452c01d9 --- /dev/null +++ b/src/main/java/org/prebid/server/bidder/akcelo/AkceloBidder.java @@ -0,0 +1,192 @@ +package org.prebid.server.bidder.akcelo; + +import com.fasterxml.jackson.core.JsonProcessingException; +import com.fasterxml.jackson.core.type.TypeReference; +import com.fasterxml.jackson.databind.JsonNode; +import com.fasterxml.jackson.databind.node.ObjectNode; +import com.iab.openrtb.request.BidRequest; +import com.iab.openrtb.request.Imp; +import com.iab.openrtb.request.Publisher; +import com.iab.openrtb.request.Site; +import com.iab.openrtb.response.Bid; +import com.iab.openrtb.response.BidResponse; +import com.iab.openrtb.response.SeatBid; +import org.apache.commons.collections4.CollectionUtils; +import org.prebid.server.bidder.Bidder; +import org.prebid.server.bidder.model.BidderBid; +import org.prebid.server.bidder.model.BidderCall; +import org.prebid.server.bidder.model.BidderError; +import org.prebid.server.bidder.model.HttpRequest; +import org.prebid.server.bidder.model.Result; +import org.prebid.server.exception.PreBidException; +import org.prebid.server.json.DecodeException; +import org.prebid.server.json.JacksonMapper; +import org.prebid.server.proto.openrtb.ext.ExtPrebid; +import org.prebid.server.proto.openrtb.ext.request.ExtPublisher; +import org.prebid.server.proto.openrtb.ext.request.ExtPublisherPrebid; +import org.prebid.server.proto.openrtb.ext.request.akcelo.ExtImpAkcelo; +import org.prebid.server.proto.openrtb.ext.response.BidType; +import org.prebid.server.proto.openrtb.ext.response.ExtBidPrebid; +import org.prebid.server.util.BidderUtil; +import org.prebid.server.util.HttpUtil; + +import java.util.ArrayList; +import java.util.Collection; +import java.util.Collections; +import java.util.List; +import java.util.Objects; +import java.util.Optional; + +public class AkceloBidder implements Bidder { + + private static final TypeReference> AKCELO_EXT_TYPE_REFERENCE = + new TypeReference<>() { + }; + private static final String BIDDER_NAME = "akcelo"; + + private final String endpointUrl; + private final JacksonMapper mapper; + + public AkceloBidder(String endpointUrl, JacksonMapper mapper) { + this.endpointUrl = HttpUtil.validateUrl(Objects.requireNonNull(endpointUrl)); + this.mapper = Objects.requireNonNull(mapper); + } + + @Override + public Result>> makeHttpRequests(BidRequest request) { + final List modifiedImps = new ArrayList<>(); + final List errors = new ArrayList<>(); + + String siteId = null; + + try { + final List imps = request.getImp(); + for (int i = 0; i < imps.size(); i++) { + final Imp imp = imps.get(i); + if (i == 0) { + final ExtImpAkcelo extImp = parseImpExt(imp); + siteId = extImp.getSiteId(); + } + modifiedImps.add(modifyImp(imp)); + } + } catch (PreBidException e) { + errors.add(BidderError.badInput(e.getMessage())); + } + + if (modifiedImps.isEmpty()) { + return Result.withErrors(errors); + } + + final BidRequest outgoingRequest = modifyRequest(request, modifiedImps, siteId); + final HttpRequest httpRequest = BidderUtil.defaultRequest(outgoingRequest, endpointUrl, mapper); + return Result.of(Collections.singletonList(httpRequest), errors); + } + + private ExtImpAkcelo parseImpExt(Imp imp) { + try { + return mapper.mapper().convertValue(imp.getExt(), AKCELO_EXT_TYPE_REFERENCE).getBidder(); + } catch (IllegalArgumentException e) { + throw new PreBidException(e.getMessage()); + } + } + + private Imp modifyImp(Imp imp) { + return Optional.ofNullable(imp.getExt()) + .map(prebid -> prebid.get("bidder")) + .filter(JsonNode::isObject) + .map(bidder -> (ObjectNode) mapper.mapper().createObjectNode().set(BIDDER_NAME, bidder)) + .map(ext -> imp.toBuilder().ext(ext).build()) + .orElseThrow(() -> new PreBidException("imp.ext.prebid.bidder can't be parsed")); + } + + private BidRequest modifyRequest(BidRequest request, List imps, String siteId) { + return request.toBuilder() + .imp(imps) + .site(modifySite(request.getSite(), siteId)) + .build(); + } + + private Site modifySite(Site site, String siteId) { + final Publisher publisher = Optional.ofNullable(site) + .map(Site::getPublisher) + .map(Publisher::toBuilder) + .orElseGet(Publisher::builder) + .ext(ExtPublisher.of(ExtPublisherPrebid.of(siteId))) + .build(); + + return Optional.ofNullable(site) + .map(Site::toBuilder) + .orElseGet(Site::builder) + .publisher(publisher) + .build(); + } + + @Override + public Result> makeBids(BidderCall httpCall, BidRequest bidRequest) { + try { + final BidResponse bidResponse = mapper.decodeValue(httpCall.getResponse().getBody(), BidResponse.class); + final List errors = new ArrayList<>(); + return Result.of(extractBids(bidResponse, errors), errors); + } catch (DecodeException e) { + return Result.withError(BidderError.badServerResponse(e.getMessage())); + } + } + + private List extractBids(BidResponse bidResponse, List errors) { + if (bidResponse == null || CollectionUtils.isEmpty(bidResponse.getSeatbid())) { + return Collections.emptyList(); + } + + return bidResponse.getSeatbid().stream() + .filter(Objects::nonNull) + .map(SeatBid::getBid) + .filter(Objects::nonNull) + .flatMap(Collection::stream) + .filter(Objects::nonNull) + .map(bid -> makeBid(bid, bidResponse.getCur(), errors)) + .filter(Objects::nonNull) + .toList(); + } + + private BidderBid makeBid(Bid bid, String currency, List errors) { + final BidType bidType = getBidType(bid, errors); + return bidType == null ? null : BidderBid.of(bid, bidType, currency); + } + + private BidType getBidType(Bid bid, List errors) { + final Integer mType = bid.getMtype(); + if (mType != null) { + return switch (mType) { + case 1 -> BidType.banner; + case 2 -> BidType.video; + case 4 -> BidType.xNative; + default -> { + errors.add(BidderError.badServerResponse("unable to get media type " + mType)); + yield null; + } + }; + } + + return getExtBidPrebidType(bid, errors); + } + + private BidType getExtBidPrebidType(Bid bid, List errors) { + return Optional.ofNullable(bid.getExt()) + .map(ext -> ext.get("prebid")) + .map(ObjectNode.class::cast) + .map(this::parseExtBidPrebid) + .map(ExtBidPrebid::getType) + .orElseGet(() -> { + errors.add(BidderError.badServerResponse("missing media type for bid " + bid.getId())); + return null; + }); + } + + private ExtBidPrebid parseExtBidPrebid(ObjectNode prebid) { + try { + return mapper.mapper().treeToValue(prebid, ExtBidPrebid.class); + } catch (JsonProcessingException e) { + return null; + } + } +} diff --git a/src/main/java/org/prebid/server/proto/openrtb/ext/request/akcelo/ExtImpAkcelo.java b/src/main/java/org/prebid/server/proto/openrtb/ext/request/akcelo/ExtImpAkcelo.java new file mode 100644 index 00000000000..4e57d8d6a12 --- /dev/null +++ b/src/main/java/org/prebid/server/proto/openrtb/ext/request/akcelo/ExtImpAkcelo.java @@ -0,0 +1,16 @@ +package org.prebid.server.proto.openrtb.ext.request.akcelo; + +import com.fasterxml.jackson.annotation.JsonProperty; +import lombok.Value; + +@Value(staticConstructor = "of") +public class ExtImpAkcelo { + + @JsonProperty("adUnitId") + Integer adUnitId; + + @JsonProperty("siteId") + String siteId; + + Integer test; +} diff --git a/src/main/java/org/prebid/server/spring/config/bidder/AkceloConfiguration.java b/src/main/java/org/prebid/server/spring/config/bidder/AkceloConfiguration.java new file mode 100644 index 00000000000..3b6472eac49 --- /dev/null +++ b/src/main/java/org/prebid/server/spring/config/bidder/AkceloConfiguration.java @@ -0,0 +1,43 @@ +package org.prebid.server.spring.config.bidder; + +import org.prebid.server.bidder.BidderDeps; +import org.prebid.server.bidder.akcelo.AkceloBidder; +import org.prebid.server.json.JacksonMapper; +import org.prebid.server.spring.config.bidder.model.BidderConfigurationProperties; +import org.prebid.server.spring.config.bidder.util.BidderDepsAssembler; +import org.prebid.server.spring.config.bidder.util.UsersyncerCreator; +import org.prebid.server.spring.env.YamlPropertySourceFactory; +import org.springframework.beans.factory.annotation.Value; +import org.springframework.boot.context.properties.ConfigurationProperties; +import org.springframework.context.annotation.Bean; +import org.springframework.context.annotation.Configuration; +import org.springframework.context.annotation.PropertySource; + +import jakarta.validation.constraints.NotBlank; + +@Configuration +@PropertySource(value = "classpath:/bidder-config/akcelo.yaml", + factory = YamlPropertySourceFactory.class) +public class AkceloConfiguration { + + private static final String BIDDER_NAME = "akcelo"; + + @Bean("akceloConfigurationProperties") + @ConfigurationProperties("adapters.akcelo") + BidderConfigurationProperties configurationProperties() { + return new BidderConfigurationProperties(); + } + + @Bean + BidderDeps akceloBidderDeps(BidderConfigurationProperties akceloConfigurationProperties, + @NotBlank @Value("${external-url}") String externalUrl, + JacksonMapper mapper) { + + return BidderDepsAssembler.forBidder(BIDDER_NAME) + .withConfig(akceloConfigurationProperties) + .usersyncerCreator(UsersyncerCreator.create(externalUrl)) + .bidderCreator(config -> new AkceloBidder(config.getEndpoint(), mapper)) + .assemble(); + } + +} diff --git a/src/main/resources/bidder-config/akcelo.yaml b/src/main/resources/bidder-config/akcelo.yaml new file mode 100644 index 00000000000..dfec684d42d --- /dev/null +++ b/src/main/resources/bidder-config/akcelo.yaml @@ -0,0 +1,12 @@ +adapters: + akcelo: + endpoint: https://s2s.sportslocalmedia.com/openrtb2/auction + meta-info: + maintainer-email: tech@akcelo.io + app-media-types: + site-media-types: + - banner + - video + - native + supported-vendors: + vendor-id: 0 diff --git a/src/main/resources/static/bidder-params/akcelo.json b/src/main/resources/static/bidder-params/akcelo.json new file mode 100644 index 00000000000..2bdf75ce1d2 --- /dev/null +++ b/src/main/resources/static/bidder-params/akcelo.json @@ -0,0 +1,24 @@ +{ + "$schema": "http://json-schema.org/draft-04/schema#", + "title": "Akcelo Adapter Params", + "description": "A schema which validates params accepted by the Akcelo adapter", + "type": "object", + "properties": { + "adUnitID": { + "type": "number", + "description": "The identifier of the ad unit. Will be provided by your account manager." + }, + "siteId": { + "type": "number", + "description": "The identifier of the site. Will be provided by your account manager." + }, + "test": { + "type": "number", + "description": "Whether to display test creatives or not. Default is 0." + } + }, + "required": [ + "adUnitId", + "siteId" + ] +} diff --git a/src/test/java/org/prebid/server/bidder/akcelo/AkceloBidderTest.java b/src/test/java/org/prebid/server/bidder/akcelo/AkceloBidderTest.java new file mode 100644 index 00000000000..19b1b3dbf7d --- /dev/null +++ b/src/test/java/org/prebid/server/bidder/akcelo/AkceloBidderTest.java @@ -0,0 +1,293 @@ +package org.prebid.server.bidder.akcelo; + +import com.fasterxml.jackson.core.JsonProcessingException; +import com.fasterxml.jackson.databind.node.ObjectNode; +import com.iab.openrtb.request.BidRequest; +import com.iab.openrtb.request.Imp; +import com.iab.openrtb.request.Publisher; +import com.iab.openrtb.request.Site; +import com.iab.openrtb.response.Bid; +import com.iab.openrtb.response.BidResponse; +import com.iab.openrtb.response.SeatBid; +import org.junit.jupiter.api.Test; +import org.prebid.server.VertxTest; +import org.prebid.server.bidder.model.BidderBid; +import org.prebid.server.bidder.model.BidderCall; +import org.prebid.server.bidder.model.BidderError; +import org.prebid.server.bidder.model.HttpRequest; +import org.prebid.server.bidder.model.HttpResponse; +import org.prebid.server.bidder.model.Result; +import org.prebid.server.proto.openrtb.ext.ExtPrebid; +import org.prebid.server.proto.openrtb.ext.request.ExtPublisher; +import org.prebid.server.proto.openrtb.ext.request.ExtPublisherPrebid; +import org.prebid.server.proto.openrtb.ext.request.akcelo.ExtImpAkcelo; +import org.prebid.server.proto.openrtb.ext.response.BidType; + +import java.math.BigDecimal; +import java.util.Arrays; +import java.util.List; +import java.util.function.UnaryOperator; + +import static java.util.Collections.singletonList; +import static org.assertj.core.api.Assertions.assertThat; +import static org.assertj.core.api.Assertions.assertThatIllegalArgumentException; +import static org.prebid.server.bidder.model.BidderError.badServerResponse; + +public class AkceloBidderTest extends VertxTest { + + private static final String ENDPOINT_URL = "https://test.endpoint.com"; + private static final String BIDDER_NAME = "akcelo"; + + private final AkceloBidder target = new AkceloBidder(ENDPOINT_URL, jacksonMapper); + + @Test + public void creationShouldFailOnInvalidEndpointUrl() { + assertThatIllegalArgumentException().isThrownBy(() -> new AkceloBidder("invalid_url", jacksonMapper)); + } + + @Test + public void makeHttpRequestsShouldReturnErrorWhenImpExtCouldNotBeParsed() { + // given + final BidRequest bidRequest = givenBidRequest( + imp -> imp.ext(mapper.valueToTree(ExtPrebid.of(null, mapper.createArrayNode())))); + + // when + final Result>> result = target.makeHttpRequests(bidRequest); + + // then + assertThat(result.getErrors()).hasSize(1) + .allSatisfy(error -> { + assertThat(error.getType()).isEqualTo(BidderError.Type.bad_input); + assertThat(error.getMessage()).startsWith("Cannot deserialize value of type"); + }); + assertThat(result.getValue()).isEmpty(); + } + + @Test + public void makeHttpRequestsShouldNotReturnErrorWhenSiteIdBeParsedInTheSecondImp() { + // given + final BidRequest bidRequest = givenBidRequest( + imp -> imp.id("imp1"), + imp -> imp.id("imp2").ext(mapper.valueToTree(ExtPrebid.of(null, mapper.createArrayNode())))); + + // when + final Result>> result = target.makeHttpRequests(bidRequest); + + // then + assertThat(result.getErrors()).hasSize(1); + assertThat(result.getValue()).hasSize(1); + } + + @Test + public void makeHttpRequestsShouldCorrectlyModifyRequest() { + // given + final ObjectNode extImp1 = givenImpExt(1, "1", 1); + final ObjectNode extImp2 = givenImpExt(2, "2", 2); + final BidRequest bidRequest = givenBidRequest( + imp -> imp.id("imp1").ext(extImp1), + imp -> imp.id("imp2").ext(extImp2)) + .toBuilder() + .site(Site.builder().id("siteId").publisher(Publisher.builder().id("pubId").build()).build()) + .build(); + + // when + final Result>> result = target.makeHttpRequests(bidRequest); + + // then + final ObjectNode expectedExtImp1 = mapper.createObjectNode() + .set(BIDDER_NAME, mapper.valueToTree(extImp1.get("bidder"))); + final ObjectNode expectedExtImp2 = mapper.createObjectNode() + .set(BIDDER_NAME, mapper.valueToTree(extImp2.get("bidder"))); + + final Publisher expectedPublisher = Publisher.builder() + .id("pubId") + .ext(ExtPublisher.of(ExtPublisherPrebid.of("1"))) + .build(); + + final Site expectedSite = Site.builder().id("siteId").publisher(expectedPublisher).build(); + + assertThat(result.getErrors()).isEmpty(); + assertThat(result.getValue()).hasSize(1).first() + .extracting(HttpRequest::getPayload) + .satisfies(request -> { + assertThat(request.getSite()).isEqualTo(expectedSite); + assertThat(request.getImp()) + .extracting(Imp::getExt) + .containsExactly(expectedExtImp1, expectedExtImp2); + }); + } + + @Test + public void makeHttpRequestsShouldCreateSitePublisherWhenSiteIsAbsent() { + // given + final ObjectNode extImp1 = givenImpExt(1, "1", 1); + final ObjectNode extImp2 = givenImpExt(2, "2", 2); + final BidRequest bidRequest = givenBidRequest( + imp -> imp.id("imp1").ext(extImp1), + imp -> imp.id("imp2").ext(extImp2)) + .toBuilder() + .build(); + + // when + final Result>> result = target.makeHttpRequests(bidRequest); + + // then + final Site expectedSite = Site.builder().publisher(Publisher.builder() + .ext(ExtPublisher.of(ExtPublisherPrebid.of("1"))) + .build()).build(); + + assertThat(result.getErrors()).isEmpty(); + assertThat(result.getValue()).hasSize(1).first() + .extracting(HttpRequest::getPayload) + .extracting(BidRequest::getSite) + .isEqualTo(expectedSite); + } + + @Test + public void makeBidsShouldReturnErrorWhenResponseBodyCouldNotBeParsed() { + // given + final BidderCall httpCall = givenHttpCall("invalid_json"); + + // when + final Result> result = target.makeBids(httpCall, null); + + // then + assertThat(result.getErrors()).hasSize(1) + .allSatisfy(error -> { + assertThat(error.getType()).isEqualTo(BidderError.Type.bad_server_response); + assertThat(error.getMessage()).startsWith("Failed to decode: Unrecognized token"); + }); + assertThat(result.getValue()).isEmpty(); + } + + @Test + public void makeBidsShouldReturnBannerBidWhenMtypeIsBanner() throws JsonProcessingException { + // given + final Bid bannerBid = givenBid(1, "video"); + final BidderCall httpCall = givenHttpCall(givenBidResponse(bannerBid)); + + // when + final Result> result = target.makeBids(httpCall, null); + + // then + assertThat(result.getErrors()).isEmpty(); + assertThat(result.getValue()).containsExactly(BidderBid.of(bannerBid, BidType.banner, "USD")); + } + + @Test + public void makeBidsShouldReturnVideoBidWhenMtypeIsVideo() throws JsonProcessingException { + // given + final Bid videoBid = givenBid(2, "banner"); + final BidderCall httpCall = givenHttpCall(givenBidResponse(videoBid)); + + // when + final Result> result = target.makeBids(httpCall, null); + + // then + assertThat(result.getErrors()).isEmpty(); + assertThat(result.getValue()).containsExactly(BidderBid.of(videoBid, BidType.video, "USD")); + } + + @Test + public void makeBidsShouldReturnNativeBidWhenMtypeIsNative() throws JsonProcessingException { + // given + final Bid nativeBid = givenBid(4, "audio"); + final BidderCall httpCall = givenHttpCall(givenBidResponse(nativeBid)); + + // when + final Result> result = target.makeBids(httpCall, null); + + // then + assertThat(result.getErrors()).isEmpty(); + assertThat(result.getValue()).containsExactly(BidderBid.of(nativeBid, BidType.xNative, "USD")); + } + + @Test + public void makeBidsShouldReturnBidsAndErrorsForMixedValidAndInvalidBids() throws JsonProcessingException { + // given + final Bid validBid = givenBid(1, null); + final Bid invalidBid = givenBid(3, "video"); + final BidderCall httpCall = givenHttpCall(givenBidResponse(validBid, invalidBid)); + + // when + final Result> result = target.makeBids(httpCall, null); + + // then + assertThat(result.getErrors()).hasSize(1) + .containsExactly(badServerResponse("unable to get media type 3")); + assertThat(result.getValue()).hasSize(1) + .containsExactly(BidderBid.of(validBid, BidType.banner, "USD")); + } + + @Test + public void makeBidsShouldReturnBannerBidWhenMtypeIsMissingAndExtTypeIsBanner() throws JsonProcessingException { + // given + final Bid bannerBid = givenBid(null, "banner"); + final BidderCall httpCall = givenHttpCall(givenBidResponse(bannerBid)); + + // when + final Result> result = target.makeBids(httpCall, null); + + // then + assertThat(result.getErrors()).isEmpty(); + assertThat(result.getValue()).containsExactly(BidderBid.of(bannerBid, BidType.banner, "USD")); + } + + @Test + public void makeBidsShouldReturnErrorWhenMtypeAndExtTypeAreMissing() throws JsonProcessingException { + // given + final Bid invalidBid = givenBid(null, null); + final BidderCall httpCall = givenHttpCall(givenBidResponse(invalidBid)); + + // when + final Result> result = target.makeBids(httpCall, null); + + // then + assertThat(result.getValue()).isEmpty(); + assertThat(result.getErrors()).hasSize(1) + .containsExactly(badServerResponse("missing media type for bid bidId")); + } + + private static BidRequest givenBidRequest(UnaryOperator... impCustomizers) { + final List imps = Arrays.stream(impCustomizers).map(AkceloBidderTest::givenImp).toList(); + return BidRequest.builder().imp(imps).build(); + } + + private static Imp givenImp(UnaryOperator impCustomizer) { + return impCustomizer.apply( + Imp.builder().id("impId").ext(givenImpExt(1, "3", null))) + .build(); + } + + private static ObjectNode givenImpExt(Integer adUnitId, String siteId, Integer test) { + return mapper.valueToTree(ExtPrebid.of(null, ExtImpAkcelo.of(adUnitId, siteId, test))); + } + + private static Bid givenBid(Integer mtype, String extType) { + final ObjectNode ext = extType != null + ? mapper.valueToTree(ExtPrebid.of(mapper.createObjectNode().put("type", extType), null)) + : null; + + return Bid.builder() + .id("bidId") + .impid("impId") + .price(BigDecimal.ONE) + .mtype(mtype) + .ext(ext) + .build(); + } + + private static String givenBidResponse(Bid... bids) throws JsonProcessingException { + return mapper.writeValueAsString(BidResponse.builder() + .cur("USD") + .seatbid(singletonList(SeatBid.builder().bid(List.of(bids)).build())) + .build()); + } + + private static BidderCall givenHttpCall(String body) { + return BidderCall.succeededHttp( + HttpRequest.builder().build(), + HttpResponse.of(200, null, body), + null); + } +} diff --git a/src/test/java/org/prebid/server/it/AkceloTest.java b/src/test/java/org/prebid/server/it/AkceloTest.java new file mode 100644 index 00000000000..464a861d43d --- /dev/null +++ b/src/test/java/org/prebid/server/it/AkceloTest.java @@ -0,0 +1,32 @@ +package org.prebid.server.it; + +import io.restassured.response.Response; +import org.json.JSONException; +import org.junit.jupiter.api.Test; +import org.prebid.server.model.Endpoint; + +import java.io.IOException; + +import static com.github.tomakehurst.wiremock.client.WireMock.aResponse; +import static com.github.tomakehurst.wiremock.client.WireMock.equalToJson; +import static com.github.tomakehurst.wiremock.client.WireMock.post; +import static com.github.tomakehurst.wiremock.client.WireMock.urlPathEqualTo; +import static java.util.Collections.singletonList; + +public class AkceloTest extends IntegrationTest { + + @Test + public void openrtb2AuctionShouldRespondWithBidsFromAkcelo() throws IOException, JSONException { + // given + WIRE_MOCK_RULE.stubFor(post(urlPathEqualTo("/akcelo-exchange")) + .withRequestBody(equalToJson(jsonFrom("openrtb2/akcelo/test-akcelo-bid-request.json"))) + .willReturn(aResponse().withBody(jsonFrom("openrtb2/akcelo/test-akcelo-bid-response.json")))); + + // when + final Response response = responseFor("openrtb2/akcelo/test-auction-akcelo-request.json", + Endpoint.openrtb2_auction); + + // then + assertJsonEquals("openrtb2/akcelo/test-auction-akcelo-response.json", response, singletonList("akcelo")); + } +} diff --git a/src/test/java/org/prebid/server/it/AlgorixTest.java b/src/test/java/org/prebid/server/it/AlgorixTest.java index 2c2e95ddd01..9d9dde25bc3 100644 --- a/src/test/java/org/prebid/server/it/AlgorixTest.java +++ b/src/test/java/org/prebid/server/it/AlgorixTest.java @@ -13,9 +13,6 @@ import static com.github.tomakehurst.wiremock.client.WireMock.urlPathEqualTo; import static java.util.Collections.singletonList; -/** - * Algorix Test in org.prebid.server.it - */ public class AlgorixTest extends IntegrationTest { @Test diff --git a/src/test/resources/org/prebid/server/it/openrtb2/akcelo/test-akcelo-bid-request.json b/src/test/resources/org/prebid/server/it/openrtb2/akcelo/test-akcelo-bid-request.json new file mode 100644 index 00000000000..fcae2928304 --- /dev/null +++ b/src/test/resources/org/prebid/server/it/openrtb2/akcelo/test-akcelo-bid-request.json @@ -0,0 +1,68 @@ +{ + "id": "test-auction-request", + "imp": [ + { + "id": "imp1", + "banner": { + "format": [ + { + "w": 300, + "h": 250 + } + ] + }, + "secure": 1, + "ext": { + "akcelo": { + "adUnitId": 1, + "siteId": 2 + } + } + } + ], + "site": { + "domain": "testpage.com", + "page": "http://testpage.com", + "publisher": { + "domain": "testpage.com", + "ext": { + "prebid": { + "parentAccount": "2" + } + } + }, + "ext": { + "amp": 0 + } + }, + "device": { + "ua": "Mozilla/5.0", + "ip": "193.168.244.1" + }, + "at": 1, + "tmax": "${json-unit.any-number}", + "cur": [ + "USD" + ], + "source": { + "tid": "${json-unit.any-string}" + }, + "regs": { + "ext": { + "gdpr": 0 + } + }, + "ext" : { + "prebid" : { + "channel" : { + "name" : "web" + }, + "server" : { + "externalurl" : "http://localhost:8080", + "gvlid" : 1, + "datacenter" : "local", + "endpoint" : "/openrtb2/auction" + } + } + } +} diff --git a/src/test/resources/org/prebid/server/it/openrtb2/akcelo/test-akcelo-bid-response.json b/src/test/resources/org/prebid/server/it/openrtb2/akcelo/test-akcelo-bid-response.json new file mode 100644 index 00000000000..0d282ff107d --- /dev/null +++ b/src/test/resources/org/prebid/server/it/openrtb2/akcelo/test-akcelo-bid-response.json @@ -0,0 +1,40 @@ +{ + "id": "test-auction-request", + "seatbid": [ + { + "seat": "adverxo", + "group": 0, + "bid": [ + { + "id": "bid1", + "impid": "imp1", + "price": 1.23, + "adm": "", + "nurl": "https://example.com/win?price=1.23", + "crid": "creative1", + "w": 300, + "h": 250, + "exp": 300, + "mtype": 1, + "ext": { + "origbidcpm": 1.23, + "origbidcur": "USD", + "prebid": { + "type": "banner" + } + } + } + ] + } + ], + "cur": "USD", + "ext": { + "responsetimemillis": { + "adverxo": 0 + }, + "tmaxrequest": 5000, + "prebid": { + "auctiontimestamp": 0 + } + } +} diff --git a/src/test/resources/org/prebid/server/it/openrtb2/akcelo/test-auction-akcelo-request.json b/src/test/resources/org/prebid/server/it/openrtb2/akcelo/test-auction-akcelo-request.json new file mode 100644 index 00000000000..c4986c14ef9 --- /dev/null +++ b/src/test/resources/org/prebid/server/it/openrtb2/akcelo/test-auction-akcelo-request.json @@ -0,0 +1,34 @@ +{ + "id": "test-auction-request", + "imp": [ + { + "id": "imp1", + "banner": { + "format": [ + { + "w": 300, + "h": 250 + } + ] + }, + "ext": { + "akcelo": { + "adUnitId": 1, + "siteId": 2 + } + } + } + ], + "site": { + "page": "http://testpage.com" + }, + "device": { + "ua": "Mozilla/5.0" + }, + "tmax": 5000, + "regs": { + "ext": { + "gdpr": 0 + } + } +} diff --git a/src/test/resources/org/prebid/server/it/openrtb2/akcelo/test-auction-akcelo-response.json b/src/test/resources/org/prebid/server/it/openrtb2/akcelo/test-auction-akcelo-response.json new file mode 100644 index 00000000000..5268897f633 --- /dev/null +++ b/src/test/resources/org/prebid/server/it/openrtb2/akcelo/test-auction-akcelo-response.json @@ -0,0 +1,43 @@ +{ + "id": "test-auction-request", + "seatbid": [ + { + "seat": "akcelo", + "group": 0, + "bid": [ + { + "id": "bid1", + "impid": "imp1", + "price": 1.23, + "adm": "", + "nurl": "https://example.com/win?price=1.23", + "crid": "creative1", + "w": 300, + "h": 250, + "exp": 300, + "mtype": 1, + "ext": { + "origbidcpm": 1.23, + "origbidcur": "USD", + "prebid": { + "type": "banner", + "meta": { + "adaptercode": "akcelo" + } + } + } + } + ] + } + ], + "cur": "USD", + "ext": { + "responsetimemillis": { + "akcelo": 0 + }, + "tmaxrequest": 5000, + "prebid": { + "auctiontimestamp": 0 + } + } +} diff --git a/src/test/resources/org/prebid/server/it/test-application.properties b/src/test/resources/org/prebid/server/it/test-application.properties index 747b9a2fc6a..046bf8669cd 100644 --- a/src/test/resources/org/prebid/server/it/test-application.properties +++ b/src/test/resources/org/prebid/server/it/test-application.properties @@ -108,6 +108,8 @@ adapters.aidem.enabled=true adapters.aidem.endpoint=http://localhost:8090/aidem-exchange adapters.aja.enabled=true adapters.aja.endpoint=http://localhost:8090/aja +adapters.akcelo.enabled=true +adapters.akcelo.endpoint=http://localhost:8090/akcelo-exchange adapters.algorix.enabled=true adapters.algorix.endpoint=http://localhost:8090/algorix-exchange adapters.alkimi.enabled=true From 78e3792456d017c8c0390b6883b2dd7123a5d619 Mon Sep 17 00:00:00 2001 From: antonbabak Date: Mon, 28 Jul 2025 14:21:54 +0200 Subject: [PATCH 2/3] fix comments --- src/main/java/org/prebid/server/bidder/akcelo/AkceloBidder.java | 1 + 1 file changed, 1 insertion(+) diff --git a/src/main/java/org/prebid/server/bidder/akcelo/AkceloBidder.java b/src/main/java/org/prebid/server/bidder/akcelo/AkceloBidder.java index 428452c01d9..904ab17ec2f 100644 --- a/src/main/java/org/prebid/server/bidder/akcelo/AkceloBidder.java +++ b/src/main/java/org/prebid/server/bidder/akcelo/AkceloBidder.java @@ -173,6 +173,7 @@ private BidType getBidType(Bid bid, List errors) { private BidType getExtBidPrebidType(Bid bid, List errors) { return Optional.ofNullable(bid.getExt()) .map(ext -> ext.get("prebid")) + .filter(JsonNode::isObject) .map(ObjectNode.class::cast) .map(this::parseExtBidPrebid) .map(ExtBidPrebid::getType) From 91fbc93678ff362792bee11b6ae8e8409bba6359 Mon Sep 17 00:00:00 2001 From: antonbabak Date: Mon, 28 Jul 2025 14:29:20 +0200 Subject: [PATCH 3/3] fix comments --- .../server/bidder/akcelo/AkceloBidder.java | 35 ++++++------------- .../bidder/akcelo/AkceloBidderTest.java | 15 -------- 2 files changed, 11 insertions(+), 39 deletions(-) diff --git a/src/main/java/org/prebid/server/bidder/akcelo/AkceloBidder.java b/src/main/java/org/prebid/server/bidder/akcelo/AkceloBidder.java index 904ab17ec2f..c214112735e 100644 --- a/src/main/java/org/prebid/server/bidder/akcelo/AkceloBidder.java +++ b/src/main/java/org/prebid/server/bidder/akcelo/AkceloBidder.java @@ -54,32 +54,22 @@ public AkceloBidder(String endpointUrl, JacksonMapper mapper) { @Override public Result>> makeHttpRequests(BidRequest request) { + final List imps = request.getImp(); final List modifiedImps = new ArrayList<>(); - final List errors = new ArrayList<>(); - - String siteId = null; + final ExtImpAkcelo firstExtImp; try { - final List imps = request.getImp(); - for (int i = 0; i < imps.size(); i++) { - final Imp imp = imps.get(i); - if (i == 0) { - final ExtImpAkcelo extImp = parseImpExt(imp); - siteId = extImp.getSiteId(); - } - modifiedImps.add(modifyImp(imp)); - } + firstExtImp = parseImpExt(imps.getFirst()); } catch (PreBidException e) { - errors.add(BidderError.badInput(e.getMessage())); + return Result.withError(BidderError.badInput(e.getMessage())); } - if (modifiedImps.isEmpty()) { - return Result.withErrors(errors); + for (final Imp imp : imps) { + modifiedImps.add(modifyImp(imp)); } - final BidRequest outgoingRequest = modifyRequest(request, modifiedImps, siteId); - final HttpRequest httpRequest = BidderUtil.defaultRequest(outgoingRequest, endpointUrl, mapper); - return Result.of(Collections.singletonList(httpRequest), errors); + final BidRequest outgoingRequest = modifyRequest(request, modifiedImps, firstExtImp.getSiteId()); + return Result.withValue(BidderUtil.defaultRequest(outgoingRequest, endpointUrl, mapper)); } private ExtImpAkcelo parseImpExt(Imp imp) { @@ -91,12 +81,9 @@ private ExtImpAkcelo parseImpExt(Imp imp) { } private Imp modifyImp(Imp imp) { - return Optional.ofNullable(imp.getExt()) - .map(prebid -> prebid.get("bidder")) - .filter(JsonNode::isObject) - .map(bidder -> (ObjectNode) mapper.mapper().createObjectNode().set(BIDDER_NAME, bidder)) - .map(ext -> imp.toBuilder().ext(ext).build()) - .orElseThrow(() -> new PreBidException("imp.ext.prebid.bidder can't be parsed")); + return imp.toBuilder() + .ext(mapper.mapper().createObjectNode().set(BIDDER_NAME, imp.getExt().get("bidder"))) + .build(); } private BidRequest modifyRequest(BidRequest request, List imps, String siteId) { diff --git a/src/test/java/org/prebid/server/bidder/akcelo/AkceloBidderTest.java b/src/test/java/org/prebid/server/bidder/akcelo/AkceloBidderTest.java index 19b1b3dbf7d..fe82dcf4714 100644 --- a/src/test/java/org/prebid/server/bidder/akcelo/AkceloBidderTest.java +++ b/src/test/java/org/prebid/server/bidder/akcelo/AkceloBidderTest.java @@ -63,21 +63,6 @@ public void makeHttpRequestsShouldReturnErrorWhenImpExtCouldNotBeParsed() { assertThat(result.getValue()).isEmpty(); } - @Test - public void makeHttpRequestsShouldNotReturnErrorWhenSiteIdBeParsedInTheSecondImp() { - // given - final BidRequest bidRequest = givenBidRequest( - imp -> imp.id("imp1"), - imp -> imp.id("imp2").ext(mapper.valueToTree(ExtPrebid.of(null, mapper.createArrayNode())))); - - // when - final Result>> result = target.makeHttpRequests(bidRequest); - - // then - assertThat(result.getErrors()).hasSize(1); - assertThat(result.getValue()).hasSize(1); - } - @Test public void makeHttpRequestsShouldCorrectlyModifyRequest() { // given