From 1858e5cb5280e17782f173fb7ff058f10c815da5 Mon Sep 17 00:00:00 2001 From: kim-ng93 <76963037+kim-ng93@users.noreply.github.com> Date: Fri, 7 Mar 2025 15:21:31 -0800 Subject: [PATCH 1/2] make attekmi partnerName optional --- .../org/prebid/server/bidder/smarthub/SmarthubBidder.java | 5 ++++- src/main/resources/static/bidder-params/smarthub.json | 4 +--- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/src/main/java/org/prebid/server/bidder/smarthub/SmarthubBidder.java b/src/main/java/org/prebid/server/bidder/smarthub/SmarthubBidder.java index ae00fa4675e..69669126efc 100644 --- a/src/main/java/org/prebid/server/bidder/smarthub/SmarthubBidder.java +++ b/src/main/java/org/prebid/server/bidder/smarthub/SmarthubBidder.java @@ -11,6 +11,7 @@ import io.vertx.core.MultiMap; import io.vertx.core.http.HttpMethod; import org.apache.commons.collections4.CollectionUtils; +import org.apache.commons.lang3.StringUtils; import org.prebid.server.bidder.Bidder; import org.prebid.server.bidder.model.BidderBid; import org.prebid.server.bidder.model.BidderCall; @@ -28,6 +29,7 @@ import java.util.Collections; import java.util.List; import java.util.Objects; +import java.util.Optional; public class SmarthubBidder implements Bidder { @@ -67,7 +69,8 @@ private MultiMap resolveHeaders() { } private String buildEndpointUrl(ExtImpSmarthub extImpSmarthub) { - return endpointTemplate.replace("{{Host}}", extImpSmarthub.getPartnerName()) + final String host = Optional.ofNullable(extImpSmarthub.getPartnerName()).orElse(StringUtils.EMPTY); + return endpointTemplate.replace("{{Host}}", host) .replace("{{AccountID}}", extImpSmarthub.getSeat()) .replace("{{SourceId}}", extImpSmarthub.getToken()); } diff --git a/src/main/resources/static/bidder-params/smarthub.json b/src/main/resources/static/bidder-params/smarthub.json index 97fe7ecc237..1a68bf5cfc3 100644 --- a/src/main/resources/static/bidder-params/smarthub.json +++ b/src/main/resources/static/bidder-params/smarthub.json @@ -6,8 +6,7 @@ "properties": { "partnerName": { "type": "string", - "description": "Attekmi (formerly SmartHub) unique partner name", - "minLength": 1 + "description": "Attekmi (formerly SmartHub) unique partner name" }, "seat": { "type": "string", @@ -21,7 +20,6 @@ } }, "required": [ - "partnerName", "seat", "token" ] From f8e485babfe89c59d568ff1cdde6e895f15a8824 Mon Sep 17 00:00:00 2001 From: kim-ng93 <76963037+kim-ng93@users.noreply.github.com> Date: Mon, 10 Mar 2025 09:58:03 -0700 Subject: [PATCH 2/2] Update SmarthubBidder.java --- .../org/prebid/server/bidder/smarthub/SmarthubBidder.java | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/main/java/org/prebid/server/bidder/smarthub/SmarthubBidder.java b/src/main/java/org/prebid/server/bidder/smarthub/SmarthubBidder.java index 69669126efc..73df9290df2 100644 --- a/src/main/java/org/prebid/server/bidder/smarthub/SmarthubBidder.java +++ b/src/main/java/org/prebid/server/bidder/smarthub/SmarthubBidder.java @@ -29,7 +29,6 @@ import java.util.Collections; import java.util.List; import java.util.Objects; -import java.util.Optional; public class SmarthubBidder implements Bidder { @@ -69,8 +68,7 @@ private MultiMap resolveHeaders() { } private String buildEndpointUrl(ExtImpSmarthub extImpSmarthub) { - final String host = Optional.ofNullable(extImpSmarthub.getPartnerName()).orElse(StringUtils.EMPTY); - return endpointTemplate.replace("{{Host}}", host) + return endpointTemplate.replace("{{Host}}", StringUtils.defaultString(extImpSmarthub.getPartnerName())) .replace("{{AccountID}}", extImpSmarthub.getSeat()) .replace("{{SourceId}}", extImpSmarthub.getToken()); }