The presence of a {@link Banner} as a subordinate of the {@link Imp} diff --git a/src/main/java/com/iab/openrtb/request/BidRequest.java b/src/main/java/com/iab/openrtb/request/BidRequest.java index f021cf5e1e9..79de78bb242 100644 --- a/src/main/java/com/iab/openrtb/request/BidRequest.java +++ b/src/main/java/com/iab/openrtb/request/BidRequest.java @@ -105,7 +105,7 @@ public class BidRequest { /** * Flag to indicate if Exchange can verify that the impressions offered - * represent all of the impressions available in context (e.g., all on the + * represent all the impressions available in context (e.g., all on the * web page, all video spots such as pre/mid/post roll) to support * road-blocking. 0 = no or unknown, 1 = yes, the impressions offered * represent all that are available. diff --git a/src/main/java/com/iab/openrtb/request/Channel.java b/src/main/java/com/iab/openrtb/request/Channel.java index a5a51c64055..84e0c7d2748 100644 --- a/src/main/java/com/iab/openrtb/request/Channel.java +++ b/src/main/java/com/iab/openrtb/request/Channel.java @@ -9,7 +9,7 @@ * {@link Channel} is defined as the entity that curates a content * library, or stream within a brand name for viewers. Examples are * specific view selectable ‘channels’ within linear and streaming - * television (MTV, HGTV, CNN, BBC One, etc) or a specific stream of + * television (MTV, HGTV, CNN, BBC One, etc.) or a specific stream of * audio content commonly called ‘stations.’ Name is a human-readable * field while domain and id can be used for reporting and targeting * purposes. See 7.6 for further examples. @@ -25,7 +25,7 @@ public class Channel { String id; /** - * Channel the content is on (e.g., a local channel like “WABC-TV") + * Channel the content is on (e.g., a local channel like "WABC-TV") */ String name; diff --git a/src/main/java/com/iab/openrtb/request/Content.java b/src/main/java/com/iab/openrtb/request/Content.java index 8ef947e810d..486630d8eed 100644 --- a/src/main/java/com/iab/openrtb/request/Content.java +++ b/src/main/java/com/iab/openrtb/request/Content.java @@ -9,7 +9,7 @@ /** * This object describes the content in which the impression will appear, which - * may be syndicated or non- syndicated content. This object may be useful when + * may be syndicated or non-syndicated content. This object may be useful when * syndicated content contains impressions and does not necessarily match the * publisher’s general content. The exchange might or might not have knowledge * of the page where the content is running, because of the syndication @@ -60,7 +60,7 @@ public class Content { String artist; /** - * Genre that best describes the content (e.g., rock, pop, etc). + * Genre that best describes the content (e.g., rock, pop, etc.). */ String genre; @@ -161,7 +161,7 @@ public class Content { String langb; /** - * Indicator of whether or not the content is embeddable (e.g., an + * Indicator of whether the content is embeddable (e.g., an * embeddable video player), where 0 = no, 1 = yes. */ Integer embeddable; diff --git a/src/main/java/com/iab/openrtb/request/Device.java b/src/main/java/com/iab/openrtb/request/Device.java index 453406e126a..848e1b01e66 100644 --- a/src/main/java/com/iab/openrtb/request/Device.java +++ b/src/main/java/com/iab/openrtb/request/Device.java @@ -10,7 +10,7 @@ * This object provides information pertaining to the device through which the * user is interacting. {@link Device} information includes its hardware, platform, * location, and carrier data. The device can refer to a mobile handset, - * a desktop computer, set top box, or other digital device. + * a desktop computer, set-top box, or other digital device. *
BEST PRACTICE: There are currently no prominent open source lists * for device makes, models, operating systems, or carriers. Exchanges typically * use commercial products or other proprietary lists for these attributes. @@ -18,7 +18,7 @@ * to publish lists of their device make, model, operating system, and carrier * values to bidders. *
BEST PRACTICE: Proper device IP detection in mobile is not - * straightforward. Typically it involves starting at the left of the + * straightforward. Typically, it involves starting at the left of the * {@code x-forwarded-for} header, skipping private carrier networks * (e.g., 10.x.x.x or 192.x.x.x), and possibly scanning for known carrier IP * ranges. Exchanges are urged to research and implement this feature carefully diff --git a/src/main/java/com/iab/openrtb/request/DurFloor.java b/src/main/java/com/iab/openrtb/request/DurFloor.java index 1c375372129..c03c5f657ee 100644 --- a/src/main/java/com/iab/openrtb/request/DurFloor.java +++ b/src/main/java/com/iab/openrtb/request/DurFloor.java @@ -28,7 +28,7 @@ public class DurFloor { /** * Minimum bid for a given impression opportunity, * if bidding with a creative in this duration range, expressed in CPM. - * For any creatives whose durations are outside of the defined min/max, + * For any creatives whose durations are outside the defined min/max, * the `bidfloor` at the `Imp` level will serve as the default floor. */ BigDecimal bidfloor; diff --git a/src/main/java/com/iab/openrtb/request/Imp.java b/src/main/java/com/iab/openrtb/request/Imp.java index 98392688e2c..a24e90d464e 100644 --- a/src/main/java/com/iab/openrtb/request/Imp.java +++ b/src/main/java/com/iab/openrtb/request/Imp.java @@ -29,7 +29,7 @@ public class Imp { /** * A unique identifier for this impression within the context of the bid - * request (typically, starts with 1 and increments. + * request (typically, starts with 1 and increments). *
(required) */ String id; diff --git a/src/main/java/com/iab/openrtb/request/Native.java b/src/main/java/com/iab/openrtb/request/Native.java index 2739b3ee2f4..0c11132b12d 100644 --- a/src/main/java/com/iab/openrtb/request/Native.java +++ b/src/main/java/com/iab/openrtb/request/Native.java @@ -34,7 +34,7 @@ public class Native { /** * Request payload complying with the Native Ad Specification. The root node * of the payload, “native”, was dropped in the Native Ad Specification 1.1. - * For Native 1.0, this is a JSON-encoded string consisting of a unnamed + * For Native 1.0, this is a JSON-encoded string consisting of an unnamed * root object with a single subordinate object named 'native', which is the * Native Markup Request object, section 4.1 of OpenRTB Native 1.0 specification. * For Native 1.1 and higher, this is a JSON-encoded string consisting of diff --git a/src/main/java/com/iab/openrtb/request/Network.java b/src/main/java/com/iab/openrtb/request/Network.java index 7d67627ab7e..8d3e3350f92 100644 --- a/src/main/java/com/iab/openrtb/request/Network.java +++ b/src/main/java/com/iab/openrtb/request/Network.java @@ -25,7 +25,7 @@ public class Network { String id; /** - * Network the content is on (e.g., a TV network like “ABC") + * Network the content is on (e.g., a TV network like "ABC") */ String name; diff --git a/src/main/java/com/iab/openrtb/request/Qty.java b/src/main/java/com/iab/openrtb/request/Qty.java index 191fab718d1..64e882de199 100644 --- a/src/main/java/com/iab/openrtb/request/Qty.java +++ b/src/main/java/com/iab/openrtb/request/Qty.java @@ -23,7 +23,7 @@ public class Qty { BigDecimal multiplier; /** - * The source type of the quantity measurement, ie. publisher. + * The source type of the quantity measurement, i.e. publisher. */ Integer sourcetype; diff --git a/src/main/java/com/iab/openrtb/request/Regs.java b/src/main/java/com/iab/openrtb/request/Regs.java index 932ae34784a..ffee5dd3216 100644 --- a/src/main/java/com/iab/openrtb/request/Regs.java +++ b/src/main/java/com/iab/openrtb/request/Regs.java @@ -23,7 +23,7 @@ public class Regs { Integer coppa; /** - * Flag that indicates whether or not the request is subject to + * Flag that indicates whether the request is subject to * GDPR regulations 0 = No, 1 = Yes, omission indicates Unknown. * Refer to Section 7.5 for more information. */ diff --git a/src/main/java/com/iab/openrtb/request/Request.java b/src/main/java/com/iab/openrtb/request/Request.java index 6f631fc152a..09ddac68d34 100644 --- a/src/main/java/com/iab/openrtb/request/Request.java +++ b/src/main/java/com/iab/openrtb/request/Request.java @@ -44,7 +44,7 @@ public class Request { /** Set to '0' in case if supply source / impression supports returning an assets url. */ Integer aurlsupport; - /** Set to '0' in case if supply source / impression supports returning an dco url. */ + /** Set to '0' in case if supply source / impression supports returning a dco url. */ Integer durlsupport; /** Specifies types of events supported by tracking. */ diff --git a/src/main/java/com/iab/openrtb/request/Source.java b/src/main/java/com/iab/openrtb/request/Source.java index e4804fea972..142a55fc7c4 100644 --- a/src/main/java/com/iab/openrtb/request/Source.java +++ b/src/main/java/com/iab/openrtb/request/Source.java @@ -36,8 +36,8 @@ public class Source { String pchain; /** - * This object represents both the links in the supply chain as - * well as an indicator whether or not the supply chain is complete. + * This object represents both the links in the supply chain and + * an indicator whether the supply chain is complete. * Details via the {@link SupplyChain} object (section 3.2.25) */ SupplyChain schain; diff --git a/src/main/java/com/iab/openrtb/request/SupplyChainNode.java b/src/main/java/com/iab/openrtb/request/SupplyChainNode.java index 1896cc7efea..ead56a2cdae 100644 --- a/src/main/java/com/iab/openrtb/request/SupplyChainNode.java +++ b/src/main/java/com/iab/openrtb/request/SupplyChainNode.java @@ -14,7 +14,7 @@ public class SupplyChainNode { /** * The canonical domain name of the SSP, Exchange, Header - * Wrapper, etc system that bidders connect to. This may be + * Wrapper, etc. system that bidders connect to. This may be * the operational domain of the system, if that is different than * the parent corporate domain, to facilitate WHOIS and * reverse IP lookups to establish clear ownership of the diff --git a/src/main/java/com/iab/openrtb/request/ntv/ContextSubType.java b/src/main/java/com/iab/openrtb/request/ntv/ContextSubType.java index 82e9edb98e2..71392349d73 100644 --- a/src/main/java/com/iab/openrtb/request/ntv/ContextSubType.java +++ b/src/main/java/com/iab/openrtb/request/ntv/ContextSubType.java @@ -14,7 +14,7 @@ public enum ContextSubType { */ GENERAL(10), /** - * Primarily article content (which of course could include images, etc as part of the article) + * Primarily article content (which of course could include images, etc. as part of the article) */ ARTICLE(11), /** diff --git a/src/main/java/com/iab/openrtb/request/video/CacheConfig.java b/src/main/java/com/iab/openrtb/request/video/CacheConfig.java index 72a3b73cc83..e02f683862b 100644 --- a/src/main/java/com/iab/openrtb/request/video/CacheConfig.java +++ b/src/main/java/com/iab/openrtb/request/video/CacheConfig.java @@ -1,10 +1,8 @@ package com.iab.openrtb.request.video; -import lombok.AllArgsConstructor; import lombok.Value; -@AllArgsConstructor(staticName = "of") -@Value +@Value(staticConstructor = "of") public class CacheConfig { Integer ttl; diff --git a/src/main/java/com/iab/openrtb/request/video/IncludeBrandCategory.java b/src/main/java/com/iab/openrtb/request/video/IncludeBrandCategory.java index 74689599d1f..0b6a489694e 100644 --- a/src/main/java/com/iab/openrtb/request/video/IncludeBrandCategory.java +++ b/src/main/java/com/iab/openrtb/request/video/IncludeBrandCategory.java @@ -1,11 +1,9 @@ package com.iab.openrtb.request.video; import com.fasterxml.jackson.annotation.JsonProperty; -import lombok.AllArgsConstructor; import lombok.Value; -@AllArgsConstructor(staticName = "of") -@Value +@Value(staticConstructor = "of") public class IncludeBrandCategory { @JsonProperty("primaryadserver") diff --git a/src/main/java/com/iab/openrtb/request/video/Pod.java b/src/main/java/com/iab/openrtb/request/video/Pod.java index 58a0b5405aa..1f899dcbc18 100644 --- a/src/main/java/com/iab/openrtb/request/video/Pod.java +++ b/src/main/java/com/iab/openrtb/request/video/Pod.java @@ -1,11 +1,9 @@ package com.iab.openrtb.request.video; import com.fasterxml.jackson.annotation.JsonProperty; -import lombok.AllArgsConstructor; import lombok.Value; -@AllArgsConstructor(staticName = "of") -@Value +@Value(staticConstructor = "of") public class Pod { @JsonProperty("podid") diff --git a/src/main/java/com/iab/openrtb/request/video/PodError.java b/src/main/java/com/iab/openrtb/request/video/PodError.java index 649d141eff5..2a1c1f8c09a 100644 --- a/src/main/java/com/iab/openrtb/request/video/PodError.java +++ b/src/main/java/com/iab/openrtb/request/video/PodError.java @@ -1,12 +1,10 @@ package com.iab.openrtb.request.video; -import lombok.AllArgsConstructor; import lombok.Value; import java.util.List; -@AllArgsConstructor(staticName = "of") -@Value +@Value(staticConstructor = "of") public class PodError { Integer podId; diff --git a/src/main/java/com/iab/openrtb/response/Link.java b/src/main/java/com/iab/openrtb/response/Link.java index 8c8c3e576a7..57f740f00e9 100644 --- a/src/main/java/com/iab/openrtb/response/Link.java +++ b/src/main/java/com/iab/openrtb/response/Link.java @@ -1,7 +1,6 @@ package com.iab.openrtb.response; import com.fasterxml.jackson.databind.node.ObjectNode; -import lombok.AllArgsConstructor; import lombok.Value; import java.util.List; @@ -9,8 +8,7 @@ /** * Used for ‘call to action’ assets, or other links from the Native ad. */ -@AllArgsConstructor(staticName = "of") -@Value +@Value(staticConstructor = "of") public class Link { /** diff --git a/src/main/java/org/prebid/server/analytics/reporter/agma/model/AgmaAccountAnalyticsProperties.java b/src/main/java/org/prebid/server/analytics/reporter/agma/model/AgmaAccountAnalyticsProperties.java deleted file mode 100644 index 1d5a994dbe9..00000000000 --- a/src/main/java/org/prebid/server/analytics/reporter/agma/model/AgmaAccountAnalyticsProperties.java +++ /dev/null @@ -1,15 +0,0 @@ -package org.prebid.server.analytics.reporter.agma.model; - -import lombok.Builder; -import lombok.Value; - -@Builder -@Value -public class AgmaAccountAnalyticsProperties { - - String code; - - String publisherId; - - String siteAppId; -} diff --git a/src/main/java/org/prebid/server/analytics/reporter/pubstack/model/PubstackConfig.java b/src/main/java/org/prebid/server/analytics/reporter/pubstack/model/PubstackConfig.java index 27562b9e40e..e36afbe4236 100644 --- a/src/main/java/org/prebid/server/analytics/reporter/pubstack/model/PubstackConfig.java +++ b/src/main/java/org/prebid/server/analytics/reporter/pubstack/model/PubstackConfig.java @@ -1,13 +1,11 @@ package org.prebid.server.analytics.reporter.pubstack.model; import com.fasterxml.jackson.annotation.JsonProperty; -import lombok.AllArgsConstructor; import lombok.Value; import java.util.Map; -@Value -@AllArgsConstructor(staticName = "of") +@Value(staticConstructor = "of") public class PubstackConfig { @JsonProperty("scopeId") diff --git a/src/main/java/org/prebid/server/auction/BidResponseCreator.java b/src/main/java/org/prebid/server/auction/BidResponseCreator.java index 4242281a5dd..0609be7dbcd 100644 --- a/src/main/java/org/prebid/server/auction/BidResponseCreator.java +++ b/src/main/java/org/prebid/server/auction/BidResponseCreator.java @@ -528,11 +528,11 @@ private Integer resolveVastTtl(Bid bid, Imp imp, BidRequestCacheInfo cacheInfo, private Future
- * Brings a convenient way for creating keywords regarding to bidder and winning bid flag.
+ * Brings a convenient way for creating keywords regarding bidder and winning bid flag.
*/
private static class KeywordMap {
diff --git a/src/main/java/org/prebid/server/auction/categorymapping/BasicCategoryMappingService.java b/src/main/java/org/prebid/server/auction/categorymapping/BasicCategoryMappingService.java
index e9a7b7818a1..823c29d5bd2 100644
--- a/src/main/java/org/prebid/server/auction/categorymapping/BasicCategoryMappingService.java
+++ b/src/main/java/org/prebid/server/auction/categorymapping/BasicCategoryMappingService.java
@@ -150,7 +150,7 @@ private Future
- * Therefore this method should be called only for names that previously passed validity check
+ * Therefore, this method should be called only for names that previously passed validity check
* through calling {@link #isValidName(String)}.
*/
public BidderInfo bidderInfoByName(String name) {
@@ -149,7 +149,7 @@ public BidderInfo bidderInfoByName(String name) {
/**
* Returns an VendorId registered by the given name or null if there is none.
*
- * Therefore this method should be called only for names that previously passed validity check
+ * Therefore, this method should be called only for names that previously passed validity check
* through calling {@link #isValidName(String)}.
*/
public Integer vendorIdByName(String name) {
@@ -217,7 +217,7 @@ public Set
- * Therefore this method should be called only for names that previously passed validity check
+ * Therefore, this method should be called only for names that previously passed validity check
* through calling {@link #isValidName(String)}.
*/
public Bidder bidderByName(String name) {
diff --git a/src/main/java/org/prebid/server/bidder/HttpBidderRequestEnricher.java b/src/main/java/org/prebid/server/bidder/HttpBidderRequestEnricher.java
index 4aabd5960a5..0289d100f3d 100644
--- a/src/main/java/org/prebid/server/bidder/HttpBidderRequestEnricher.java
+++ b/src/main/java/org/prebid/server/bidder/HttpBidderRequestEnricher.java
@@ -48,7 +48,7 @@ MultiMap enrichHeaders(
BidderAliases aliases,
BidRequest bidRequest) {
- // some bidders has headers on class level, so we create copy to not affect them
+ // some bidders have headers on class level, so we create copy to not affect them
final MultiMap bidderRequestHeadersCopy = copyMultiMap(bidderRequestHeaders);
addOriginalRequestHeaders(bidderRequestHeadersCopy, originalRequestHeaders);
diff --git a/src/main/java/org/prebid/server/bidder/HttpBidderRequester.java b/src/main/java/org/prebid/server/bidder/HttpBidderRequester.java
index 3a24683c774..5fed030cb41 100644
--- a/src/main/java/org/prebid/server/bidder/HttpBidderRequester.java
+++ b/src/main/java/org/prebid/server/bidder/HttpBidderRequester.java
@@ -4,7 +4,6 @@
import io.netty.channel.ConnectTimeoutException;
import io.netty.handler.codec.http.HttpHeaderValues;
import io.netty.handler.codec.http.HttpResponseStatus;
-import io.vertx.core.CompositeFuture;
import io.vertx.core.Future;
import io.vertx.core.MultiMap;
import org.apache.commons.collections4.CollectionUtils;
@@ -131,8 +130,8 @@ public
- * Note: this will safe making bids by bidders from JSON parsing error.
+ * Note: this will save making bids by bidders from JSON parsing error.
*/
private static