diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 28ce307df13..a5f5cdf5aaf 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,40 +1,34 @@ ### ๐Ÿ”ง Type of changes - [ ] new bid adapter -- [ ] update bid adapter +- [ ] bid adapter update - [ ] new feature - [ ] new analytics adapter - [ ] new module +- [ ] module update - [ ] bugfix - [ ] documentation - [ ] configuration +- [ ] dependency update - [ ] tech debt (test coverage, refactorings, etc.) ### โœจ What's the context? - -What's the context for the changes? Are there any - +What's the context for the changes? ### ๐Ÿง  Rationale behind the change - Why did you choose to make these changes? Were there any trade-offs you had to consider? - ### ๐Ÿ”Ž New Bid Adapter Checklist - [ ] verify email contact works -- [ ] NO fully dynamic hosts +- [ ] NO fully dynamic hostnames - [ ] geographic host parameters are NOT required -- [ ] NO direct use of HTTP is prohibited - *implement an existing Bidder interface that will do all the job* +- [ ] direct use of HTTP is prohibited - *implement an existing Bidder interface that will do all the job* - [ ] if the ORTB is just forwarded to the endpoint, use the generic adapter - *define the new adapter as the alias of the generic adapter* - [ ] cover an adapter configuration with an integration test - ### ๐Ÿงช Test plan - How do you know the changes are safe to ship to production? - ### ๐ŸŽ Quality check - - [ ] Are your changes following [our code style guidelines](https://github.com/prebid/prebid-server-java/blob/master/docs/developers/code-style.md)? - [ ] Are there any breaking changes in your code? - [ ] Does your test coverage exceed 90%?