-
Notifications
You must be signed in to change notification settings - Fork 224
Closed
Description
Hi,
Recently Protobuf tests started failing at least for old PBS code (v 3.16):
- Tests where the maven cache was found and successfully restored were passing.
- Tests where the maven cache did not exist and could not be restored were failing.
The error: PROTOC FAILED: test-opernrtb.proto:84:8: "com.iabtechlab.openrtb.v2.BidRequest.Imp.Video.CompanionAd" is not defined.
The reason:
- The POM file is referencing to : openrtb.proto
- This file was changed in the last several days: openrtb.proto update
test-opernrtb.protowasn’t updated according to openrtb.proto.
Updating the POM to reference the older version of the above file allows the tests to pass.
- https://raw.githubusercontent.com/IABTechLab/openrtb-proto-v2/fcb59b3b4fa7687c1db6e4866ec6f76c55849f2f/openrtb-core/src/main/protobuf/openrtb.proto
- https://github.com/IABTechLab/openrtb-proto-v2/blob/fcb59b3b4fa7687c1db6e4866ec6f76c55849f2f/openrtb-core/src/main/protobuf/openrtb.proto
Please introduce versioning for https://raw.githubusercontent.com/IABTechLab/openrtb-proto-v2/master/openrtb-core/src/main/protobuf/openrtb.proto file and keep it actual per PBS code version.
Metadata
Metadata
Assignees
Labels
No labels
Type
Projects
Status
Done