Pubmatic Adapter: Set bid.meta.mediaType=video when bid.ext.ibv=true (#4049)

Author: AntoxaAntoxic

src/main/java/org/prebid/server/bidder/pubmatic/PubmaticBidder.java

@@ -42,6 +42,7 @@
 import org.prebid.server.proto.openrtb.ext.request.pubmatic.ExtImpPubmaticKeyVal;
 import org.prebid.server.proto.openrtb.ext.response.BidType;
 import org.prebid.server.proto.openrtb.ext.response.ExtBidPrebid;
+import org.prebid.server.proto.openrtb.ext.response.ExtBidPrebidMeta;
 import org.prebid.server.proto.openrtb.ext.response.ExtBidPrebidVideo;
 import org.prebid.server.proto.openrtb.ext.response.ExtIgi;
 import org.prebid.server.proto.openrtb.ext.response.ExtIgiIgs;
@@ -504,6 +505,7 @@ public CompositeBidderResponse makeBidderResponse(BidderCall<BidRequest> httpCal
             return CompositeBidderResponse.builder()
                     .bids(extractBids(bidResponse, errors))
                     .igi(extractIgi(bidResponse))
+                    .errors(errors)
                     .build();
         } catch (DecodeException | PreBidException e) {
             return CompositeBidderResponse.withError(BidderError.badServerResponse(e.getMessage()));
@@ -523,6 +525,7 @@ private List<BidderBid> bidsFromResponse(PubmaticBidResponse bidResponse, List<B
                 .filter(Objects::nonNull)
                 .flatMap(Collection::stream)
                 .map(bid -> resolveBidderBid(bid, bidResponse.getCur(), bidderErrors))
+                .filter(Objects::nonNull)
                 .toList();
     }
 
@@ -533,21 +536,22 @@ private BidderBid resolveBidderBid(Bid bid, String currency, List<BidderError> b
                 : null;
 
         final PubmaticBidExt pubmaticBidExt = parseBidExt(bid.getExt(), bidderErrors);
-        final Integer duration = getDuration(pubmaticBidExt);
-        final BidType bidType = getBidType(pubmaticBidExt);
+        final BidType bidType = getBidType(bid, bidderErrors);
+
+        if (bidType == null) {
+            return null;
+        }
 
         final String bidAdm = bid.getAdm();
         final String resolvedAdm = bidAdm != null && bidType == BidType.xNative
                 ? resolveNativeAdm(bidAdm, bidderErrors)
                 : bidAdm;
 
-        final Bid updatedBid = firstCat != null || duration != null || resolvedAdm != null
-                ? bid.toBuilder()
+        final Bid updatedBid = bid.toBuilder()
                 .cat(firstCat)
                 .adm(resolvedAdm != null ? resolvedAdm : bidAdm)
-                .ext(duration != null ? updateBidExtWithExtPrebid(duration, bid.getExt()) : bid.getExt())
-                .build()
-                : bid;
+                .ext(updateBidExtWithExtPrebid(pubmaticBidExt, bidType, bid.getExt()))
+                .build();
 
         return BidderBid.builder()
                 .bid(updatedBid)
@@ -567,22 +571,17 @@ private PubmaticBidExt parseBidExt(ObjectNode bidExt, List<BidderError> errors)
         }
     }
 
-    private static Integer getDuration(PubmaticBidExt bidExt) {
-        return Optional.ofNullable(bidExt)
-                .map(PubmaticBidExt::getVideo)
-                .map(VideoCreativeInfo::getDuration)
-                .orElse(null);
-    }
-
-    private static BidType getBidType(PubmaticBidExt bidExt) {
-        final int bidType = Optional.ofNullable(bidExt)
-                .map(PubmaticBidExt::getBidType)
-                .orElse(0);
-
-        return switch (bidType) {
-            case 1 -> BidType.video;
-            case 2 -> BidType.xNative;
-            default -> BidType.banner;
+    private static BidType getBidType(Bid bid, List<BidderError> errors) {
+        return switch (bid.getMtype()) {
+            case 1 -> BidType.banner;
+            case 2 -> BidType.video;
+            case 3 -> BidType.audio;
+            case 4 -> BidType.xNative;
+            case null, default -> {
+                errors.add(BidderError.badServerResponse("failed to parse bid mtype (%d) for impression id %s"
+                        .formatted(bid.getMtype(), bid.getImpid())));
+                yield null;
+            }
         };
     }
 
@@ -603,9 +602,33 @@ private String resolveNativeAdm(String adm, List<BidderError> bidderErrors) {
         return null;
     }
 
-    private ObjectNode updateBidExtWithExtPrebid(Integer duration, ObjectNode extBid) {
-        final ExtBidPrebid extBidPrebid = ExtBidPrebid.builder().video(ExtBidPrebidVideo.of(duration, null)).build();
-        return extBid.set(PREBID, mapper.mapper().valueToTree(extBidPrebid));
+    private ObjectNode updateBidExtWithExtPrebid(PubmaticBidExt pubmaticBidExt, BidType type, ObjectNode extBid) {
+        final Integer duration = getDuration(pubmaticBidExt);
+        final boolean inBannerVideo = getInBannerVideo(pubmaticBidExt);
+
+        final ExtBidPrebid extBidPrebid = ExtBidPrebid.builder()
+                .video(duration != null ? ExtBidPrebidVideo.of(duration, null) : null)
+                .meta(ExtBidPrebidMeta.builder()
+                        .mediaType(inBannerVideo ? BidType.video.getName() : type.getName())
+                        .build())
+                .build();
+
+        return extBid != null
+                ? extBid.set(PREBID, mapper.mapper().valueToTree(extBidPrebid))
+                : mapper.mapper().createObjectNode().set(PREBID, mapper.mapper().valueToTree(extBidPrebid));
+    }
+
+    private static Integer getDuration(PubmaticBidExt bidExt) {
+        return Optional.ofNullable(bidExt)
+                .map(PubmaticBidExt::getVideo)
+                .map(VideoCreativeInfo::getDuration)
+                .orElse(null);
+    }
+
+    private static boolean getInBannerVideo(PubmaticBidExt bidExt) {
+        return Optional.ofNullable(bidExt)
+                .map(PubmaticBidExt::getInBannerVideo)
+                .orElse(false);
     }
 
     private static Integer getDealPriority(PubmaticBidExt bidExt) {

src/main/java/org/prebid/server/bidder/pubmatic/model/response/PubmaticBidExt.java

@@ -1,20 +1,18 @@
 package org.prebid.server.bidder.pubmatic.model.response;
 
-import com.fasterxml.jackson.annotation.JsonAlias;
 import com.fasterxml.jackson.annotation.JsonProperty;
 import lombok.Value;
 
 @Value(staticConstructor = "of")
 public class PubmaticBidExt {
 
-    @JsonProperty("BidType")
-    @JsonAlias({"bidtype", "bidType"})
-    Integer bidType;
-
     VideoCreativeInfo video;
 
     @JsonProperty("prebiddealpriority")
     Integer prebidDealPriority;
 
     String marketplace;
+
+    @JsonProperty("ibv")
+    Boolean inBannerVideo;
 }