Fix comments

Author: AntoxaAntoxic

extra/modules/live-intent-omni-channel-identity/src/main/java/org/prebid/server/hooks/modules/liveintent/omni/channel/identity/config/LiveIntentOmniChannelIdentityConfiguration.java

@@ -13,7 +13,6 @@
 import org.springframework.context.annotation.Configuration;
 
 import java.util.Collections;
-import java.util.concurrent.ThreadLocalRandom;
 
 @Configuration
 @ConditionalOnProperty(
@@ -36,7 +35,7 @@ Module liveIntentOmniChannelIdentityModule(LiveIntentOmniChannelProperties prope
 
         final LiveIntentOmniChannelIdentityProcessedAuctionRequestHook hook =
                 new LiveIntentOmniChannelIdentityProcessedAuctionRequestHook(
-                        properties, mapper, httpClient, () -> ThreadLocalRandom.current().nextLong(), logSamplingRate);
+                        properties, mapper, httpClient, logSamplingRate);
 
         return new LiveIntentOmniChannelIdentityModule(Collections.singleton(hook));
     }

extra/modules/live-intent-omni-channel-identity/src/main/java/org/prebid/server/hooks/modules/liveintent/omni/channel/identity/v1/hooks/LiveIntentOmniChannelIdentityProcessedAuctionRequestHook.java

@@ -27,7 +27,7 @@
 import java.util.List;
 import java.util.Objects;
 import java.util.Optional;
-import java.util.random.RandomGenerator;
+import java.util.concurrent.ThreadLocalRandom;
 
 public class LiveIntentOmniChannelIdentityProcessedAuctionRequestHook implements ProcessedAuctionRequestHook {
 
@@ -39,33 +39,30 @@ public class LiveIntentOmniChannelIdentityProcessedAuctionRequestHook implements
     private final LiveIntentOmniChannelProperties config;
     private final JacksonMapper mapper;
     private final HttpClient httpClient;
-    private final RandomGenerator random;
     private final double logSamplingRate;
 
     public LiveIntentOmniChannelIdentityProcessedAuctionRequestHook(LiveIntentOmniChannelProperties config,
                                                                     JacksonMapper mapper,
                                                                     HttpClient httpClient,
-                                                                    RandomGenerator random,
                                                                     double logSamplingRate) {
 
         this.config = Objects.requireNonNull(config);
         HttpUtil.validateUrlSyntax(config.getIdentityResolutionEndpoint());
         this.mapper = Objects.requireNonNull(mapper);
         this.httpClient = Objects.requireNonNull(httpClient);
-        this.random = Objects.requireNonNull(random);
         this.logSamplingRate = logSamplingRate;
     }
 
     @Override
     public Future<InvocationResult<AuctionRequestPayload>> call(AuctionRequestPayload auctionRequestPayload,
                                                                 AuctionInvocationContext invocationContext) {
 
-        return config.getTreatmentRate() <= random.nextFloat()
-                ? noAction()
-                : requestIdentities(auctionRequestPayload.bidRequest())
+        return config.getTreatmentRate() > ThreadLocalRandom.current().nextFloat()
+                ? requestIdentities(auctionRequestPayload.bidRequest())
                 .<InvocationResult<AuctionRequestPayload>>map(this::update)
                 .onFailure(throwable -> conditionalLogger.error(
-                        "Failed enrichment: %s".formatted(throwable.getMessage()), logSamplingRate));
+                        "Failed enrichment: %s".formatted(throwable.getMessage()), logSamplingRate))
+                : noAction();
     }
 
     private Future<IdResResponse> requestIdentities(BidRequest bidRequest) {

extra/modules/live-intent-omni-channel-identity/src/test/java/org/prebid/server/hooks/modules/liveintent/omni/channel/identity/v1/LiveIntentOmniChannelIdentityProcessedAuctionRequestHookTest.java

@@ -26,7 +26,6 @@
 import org.prebid.server.vertx.httpclient.model.HttpClientResponse;
 
 import java.util.List;
-import java.util.Random;
 import java.util.concurrent.TimeoutException;
 
 import static java.util.Collections.singletonList;
@@ -48,9 +47,6 @@ public class LiveIntentOmniChannelIdentityProcessedAuctionRequestHookTest {
     @Mock
     private HttpClient httpClient;
 
-    @Mock(strictness = LENIENT)
-    private Random random;
-
     @Mock(strictness = LENIENT)
     private LiveIntentOmniChannelProperties properties;
 
@@ -61,19 +57,18 @@ public void setUp() {
         given(properties.getRequestTimeoutMs()).willReturn(5L);
         given(properties.getIdentityResolutionEndpoint()).willReturn("https://test.com/idres");
         given(properties.getAuthToken()).willReturn("auth_token");
-        given(properties.getTreatmentRate()).willReturn(0.9f);
-        given(random.nextFloat()).willReturn(0.89f);
+        given(properties.getTreatmentRate()).willReturn(1.0f);
 
         target = new LiveIntentOmniChannelIdentityProcessedAuctionRequestHook(
-                properties, MAPPER, httpClient, random, 0.01d);
+                properties, MAPPER, httpClient, 0.01d);
     }
 
     @Test
     public void creationShouldFailOnInvalidIdentityUrl() {
         given(properties.getIdentityResolutionEndpoint()).willReturn("invalid_url");
         assertThatIllegalArgumentException().isThrownBy(() ->
                 new LiveIntentOmniChannelIdentityProcessedAuctionRequestHook(
-                        properties, MAPPER, httpClient, random, 0.01d));
+                        properties, MAPPER, httpClient, 0.01d));
     }
 
     @Test
@@ -164,8 +159,7 @@ public void callShouldReturnNoActionSuccessfullyWhenTreatmentRateIsLowerThanThre
         final AuctionInvocationContext auctionInvocationContext = AuctionInvocationContextImpl.of(
                 null, null, false, null, null);
 
-        given(properties.getTreatmentRate()).willReturn(0.9f);
-        given(random.nextFloat()).willReturn(0.91f);
+        given(properties.getTreatmentRate()).willReturn(0.0f);
 
         // when
         final InvocationResult<AuctionRequestPayload> result = target.call(