Skip to content

Commit cfe1603

Browse files
authored
Kobler: Fix NPE (#3885)
1 parent 4c8bcc0 commit cfe1603

File tree

2 files changed

+17
-1
lines changed

2 files changed

+17
-1
lines changed

src/main/java/org/prebid/server/bidder/kobler/KoblerBidder.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
import com.iab.openrtb.response.BidResponse;
1111
import com.iab.openrtb.response.SeatBid;
1212
import org.apache.commons.collections4.CollectionUtils;
13+
import org.apache.commons.lang3.BooleanUtils;
1314
import org.prebid.server.bidder.Bidder;
1415
import org.prebid.server.bidder.model.BidderBid;
1516
import org.prebid.server.bidder.model.BidderCall;
@@ -126,7 +127,7 @@ private List<String> normalizeCurrencies(BidRequest bidRequest) {
126127

127128
private boolean isTest(Imp imp, List<BidderError> errors) {
128129
try {
129-
return parseImpExt(imp).getTest();
130+
return BooleanUtils.isTrue(parseImpExt(imp).getTest());
130131
} catch (PreBidException e) {
131132
errors.add(BidderError.badInput(e.getMessage()));
132133
return false;

src/test/java/org/prebid/server/bidder/kobler/KoblerBidderTest.java

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -133,6 +133,21 @@ public void makeHttpRequestsShouldUseDefaultEndpointWhenTestModeDisabled() {
133133
.containsExactly(ENDPOINT_URL);
134134
}
135135

136+
@Test
137+
public void makeHttpRequestsShouldUseDefaultEndpointWhenTestModeAbsent() {
138+
// given
139+
final BidRequest bidRequest = givenBidRequest(givenImp(
140+
imp -> imp.ext(mapper.valueToTree(ExtPrebid.of(null, ExtImpKobler.of(null))))));
141+
142+
// when
143+
final Result<List<HttpRequest<BidRequest>>> result = target.makeHttpRequests(bidRequest);
144+
145+
// then
146+
assertThat(result.getValue())
147+
.extracting(HttpRequest::getUri)
148+
.containsExactly(ENDPOINT_URL);
149+
}
150+
136151
@Test
137152
public void makeHttpRequestsShouldAddUsdToCurrenciesIfMissing() {
138153
// given

0 commit comments

Comments
 (0)