Skip to content

Commit ce2d86c

Browse files
authored
Connatix Bid Adapter: copy entire imp[i].ext (#4180)
1 parent 81c237c commit ce2d86c

File tree

3 files changed

+9
-7
lines changed

3 files changed

+9
-7
lines changed

src/main/java/org/prebid/server/bidder/connatix/ConnatixBidder.java

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -171,13 +171,12 @@ private ExtImpConnatix parseExtImp(Imp imp) {
171171
private Imp modifyImp(Imp imp, ExtImpConnatix extImpConnatix, String displayManagerVer, BidRequest request) {
172172
final Price bidFloorPrice = resolveBidFloor(imp, request);
173173

174-
final ObjectNode impExt = mapper.mapper()
175-
.createObjectNode().set("connatix", mapper.mapper().valueToTree(extImpConnatix));
174+
final ObjectNode impExt = imp.getExt() != null
175+
? imp.getExt().deepCopy()
176+
: mapper.mapper().createObjectNode();
176177

177-
Optional.ofNullable(imp.getExt())
178-
.map(ext -> ext.get(GPID_KEY))
179-
.filter(JsonNode::isTextual)
180-
.ifPresent(gpidNode -> impExt.set(GPID_KEY, gpidNode));
178+
impExt.remove("bidder");
179+
impExt.set("connatix", mapper.mapper().valueToTree(extImpConnatix));
181180

182181
return imp.toBuilder()
183182
.ext(impExt)

src/test/java/org/prebid/server/bidder/connatix/ConnatixBidderTest.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -350,11 +350,12 @@ public void makeHttpRequestsShouldExcludeDataCenterWhenUserIdIsMissing() {
350350
}
351351

352352
@Test
353-
public void makeHttpRequestsShouldIncludeGpidWhenPresent() {
353+
public void makeHttpRequestsShouldIncludeEntireImpExt() {
354354
// given
355355
final ObjectNode impExt = mapper.createObjectNode();
356356
impExt.set("bidder", mapper.valueToTree(ExtImpConnatix.of("placementId", null)));
357357
impExt.put("gpid", "test-gpid");
358+
impExt.put("random", "test-random");
358359

359360
final BidRequest bidRequest = givenBidRequest(
360361
UnaryOperator.identity(),
@@ -367,6 +368,7 @@ public void makeHttpRequestsShouldIncludeGpidWhenPresent() {
367368
final ObjectNode expectedExt = mapper.createObjectNode();
368369
expectedExt.set("connatix", mapper.valueToTree(ExtImpConnatix.of("placementId", null)));
369370
expectedExt.put("gpid", "test-gpid");
371+
expectedExt.put("random", "test-random");
370372

371373
assertThat(result.getErrors()).isEmpty();
372374
assertThat(result.getValue())

src/test/resources/org/prebid/server/it/openrtb2/connatix/test-banner-connatix-bid-request.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
"connatix": {
1313
"placementId": "some-placement-id"
1414
},
15+
"tid": "${json-unit.any-string}",
1516
"gpid": "test-gpid"
1617
}
1718
}

0 commit comments

Comments
 (0)