Skip to content

Commit 79bc055

Browse files
authored
Housekeeping: Update pull_request_template.md (#3585)
1 parent 5643eae commit 79bc055

File tree

1 file changed

+6
-12
lines changed

1 file changed

+6
-12
lines changed

.github/pull_request_template.md

Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,40 +1,34 @@
11
### 🔧 Type of changes
22
- [ ] new bid adapter
3-
- [ ] update bid adapter
3+
- [ ] bid adapter update
44
- [ ] new feature
55
- [ ] new analytics adapter
66
- [ ] new module
7+
- [ ] module update
78
- [ ] bugfix
89
- [ ] documentation
910
- [ ] configuration
11+
- [ ] dependency update
1012
- [ ] tech debt (test coverage, refactorings, etc.)
1113

1214
### ✨ What's the context?
13-
14-
What's the context for the changes? Are there any
15-
15+
What's the context for the changes?
1616

1717
### 🧠 Rationale behind the change
18-
1918
Why did you choose to make these changes? Were there any trade-offs you had to consider?
2019

21-
2220
### 🔎 New Bid Adapter Checklist
2321
- [ ] verify email contact works
24-
- [ ] NO fully dynamic hosts
22+
- [ ] NO fully dynamic hostnames
2523
- [ ] geographic host parameters are NOT required
26-
- [ ] NO direct use of HTTP is prohibited - *implement an existing Bidder interface that will do all the job*
24+
- [ ] direct use of HTTP is prohibited - *implement an existing Bidder interface that will do all the job*
2725
- [ ] if the ORTB is just forwarded to the endpoint, use the generic adapter - *define the new adapter as the alias of the generic adapter*
2826
- [ ] cover an adapter configuration with an integration test
2927

30-
3128
### 🧪 Test plan
32-
3329
How do you know the changes are safe to ship to production?
3430

35-
3631
### 🏎 Quality check
37-
3832
- [ ] Are your changes following [our code style guidelines](https://github.com/prebid/prebid-server-java/blob/master/docs/developers/code-style.md)?
3933
- [ ] Are there any breaking changes in your code?
4034
- [ ] Does your test coverage exceed 90%?

0 commit comments

Comments
 (0)