SmileWanted endpoint now supports dynamic zoneId and integrates prebid server technology

Author: QuentinGallard

src/main/java/org/prebid/server/bidder/smilewanted/SmileWantedBidder.java

@@ -1,5 +1,6 @@
 package org.prebid.server.bidder.smilewanted;
 
+import com.fasterxml.jackson.core.type.TypeReference;
 import com.iab.openrtb.request.BidRequest;
 import com.iab.openrtb.request.Imp;
 import com.iab.openrtb.response.BidResponse;
@@ -13,8 +14,11 @@
 import org.prebid.server.bidder.model.BidderError;
 import org.prebid.server.bidder.model.HttpRequest;
 import org.prebid.server.bidder.model.Result;
+import org.prebid.server.exception.PreBidException;
 import org.prebid.server.json.DecodeException;
 import org.prebid.server.json.JacksonMapper;
+import org.prebid.server.proto.openrtb.ext.ExtPrebid;
+import org.prebid.server.proto.openrtb.ext.request.smilewanted.ExtImpSmilewanted;
 import org.prebid.server.proto.openrtb.ext.response.BidType;
 import org.prebid.server.util.HttpUtil;
 
@@ -28,6 +32,10 @@ public class SmileWantedBidder implements Bidder<BidRequest> {
     private static final String X_OPENRTB_VERSION = "2.5";
     private static final int DEFAULT_AT = 1;
 
+    private static final TypeReference<ExtPrebid<?, ExtImpSmilewanted>> SMILEWANTED_EXT_TYPE_REFERENCE =
+            new TypeReference<>() {
+            };
+
     private final String endpointUrl;
     private final JacksonMapper mapper;
 
@@ -38,17 +46,38 @@ public SmileWantedBidder(String endpointUrl, JacksonMapper mapper) {
 
     @Override
     public Result<List<HttpRequest<BidRequest>>> makeHttpRequests(BidRequest request) {
+        if (CollectionUtils.isEmpty(request.getImp())) {
+            return Result.withError(BidderError.badInput("No impressions in request"));
+        }
+
+        final ExtImpSmilewanted extImpSmilewanted;
+
+        try {
+            extImpSmilewanted = parseImpExt(request.getImp().getFirst());
+        } catch (PreBidException e) {
+            return Result.withError(BidderError.badInput(e.getMessage()));
+        }
+
         final BidRequest outgoingRequest = request.toBuilder().at(DEFAULT_AT).build();
+        final String url = endpointUrl + extImpSmilewanted.getZoneId();
 
         return Result.withValue(HttpRequest.<BidRequest>builder()
                 .method(HttpMethod.POST)
-                .uri(endpointUrl)
+                .uri(url)
                 .headers(createHeaders())
                 .payload(outgoingRequest)
                 .body(mapper.encodeToBytes(outgoingRequest))
                 .build());
     }
 
+    private ExtImpSmilewanted parseImpExt(Imp imp) {
+        try {
+            return mapper.mapper().convertValue(imp.getExt(), SMILEWANTED_EXT_TYPE_REFERENCE).getBidder();
+        } catch (IllegalArgumentException e) {
+            throw new PreBidException("Missing bidder ext in impression with id: " + imp.getId());
+        }
+    }
+
     private static MultiMap createHeaders() {
         return HttpUtil.headers()
                 .add(HttpUtil.X_OPENRTB_VERSION_HEADER, X_OPENRTB_VERSION)

src/main/java/org/prebid/server/proto/openrtb/ext/request/smilewanted/ExtImpSmilewanted.java

@@ -0,0 +1,11 @@
+package org.prebid.server.proto.openrtb.ext.request.smilewanted;
+
+import com.fasterxml.jackson.annotation.JsonProperty;
+import lombok.Value;
+
+@Value(staticConstructor = "of")
+public class ExtImpSmilewanted {
+
+    @JsonProperty("zoneId")
+    String zoneId;
+}

…ig/bidder/SimpleWantedConfiguration.java …fig/bidder/SmileWantedConfiguration.javasrc/main/java/org/prebid/server/spring/config/bidder/SimpleWantedConfiguration.java renamed to src/main/java/org/prebid/server/spring/config/bidder/SmileWantedConfiguration.java src/main/java/org/prebid/server/spring/config/bidder/SimpleWantedConfiguration.java renamed to src/main/java/org/prebid/server/spring/config/bidder/SmileWantedConfiguration.java

@@ -17,7 +17,7 @@
 
 @Configuration
 @PropertySource(value = "classpath:/bidder-config/smilewanted.yaml", factory = YamlPropertySourceFactory.class)
-public class SimpleWantedConfiguration {
+public class SmileWantedConfiguration {
 
     private static final String BIDDER_NAME = "smilewanted";
 

src/main/resources/bidder-config/smilewanted.yaml

@@ -1,6 +1,6 @@
 adapters:
   smilewanted:
-    endpoint: https://prebid-server.smilewanted.com
+    endpoint: https://prebid-server.smilewanted.com/java/
     meta-info:
       maintainer-email: tech@smilewanted.com
       app-media-types:

src/test/java/org/prebid/server/bidder/smilewanted/SmileWantedBidderTest.java

@@ -17,6 +17,8 @@
 import org.prebid.server.bidder.model.HttpRequest;
 import org.prebid.server.bidder.model.HttpResponse;
 import org.prebid.server.bidder.model.Result;
+import org.prebid.server.proto.openrtb.ext.ExtPrebid;
+import org.prebid.server.proto.openrtb.ext.request.smilewanted.ExtImpSmilewanted;
 import org.prebid.server.util.HttpUtil;
 
 import java.util.List;
@@ -32,7 +34,7 @@
 
 public class SmileWantedBidderTest extends VertxTest {
 
-    private static final String ENDPOINT_URL = "https://{{Host}}/test?param={{PublisherId}}";
+    private static final String ENDPOINT_URL = "https://prebid-server.smilewanted.com/java/";
 
     private final SmileWantedBidder target = new SmileWantedBidder(ENDPOINT_URL, jacksonMapper);
 
@@ -42,13 +44,29 @@ public void creationShouldFailOnInvalidEndpointUrl() {
     }
 
     @Test
-    public void makeHttpRequestsShouldCorrectlyAddHeaders() {
+    public void makeHttpRequestsShouldReturnErrorIfNoImpressions() {
         // given
         final BidRequest bidRequest = BidRequest.builder().build();
 
         // when
         final Result<List<HttpRequest<BidRequest>>> result = target.makeHttpRequests(bidRequest);
 
+        // then
+        assertThat(result.getValue()).isEmpty();
+        assertThat(result.getErrors())
+                .containsExactly(BidderError.badInput("No impressions in request"));
+    }
+
+    @Test
+    public void makeHttpRequestsShouldCorrectlyAddHeaders() {
+        // given
+        final BidRequest bidRequest = BidRequest.builder()
+                .imp(singletonList(givenImp("zone123")))
+                .build();
+
+        // when
+        final Result<List<HttpRequest<BidRequest>>> result = target.makeHttpRequests(bidRequest);
+
         // then
         assertThat(result.getErrors()).isEmpty();
         assertThat(result.getValue())
@@ -65,7 +83,9 @@ public void makeHttpRequestsShouldCorrectlyAddHeaders() {
     @Test
     public void makeHttpRequestsShouldSetAtToOne() {
         // given
-        final BidRequest bidRequest = BidRequest.builder().build();
+        final BidRequest bidRequest = BidRequest.builder()
+                .imp(singletonList(givenImp("zone123")))
+                .build();
 
         // when
         final Result<List<HttpRequest<BidRequest>>> result = target.makeHttpRequests(bidRequest);
@@ -173,4 +193,11 @@ private static BidderCall<BidRequest> givenHttpCall(BidRequest bidRequest, Strin
                 HttpResponse.of(200, null, body),
                 null);
     }
+
+    private static Imp givenImp(String zoneId) {
+        return Imp.builder()
+                .id("123")
+                .ext(mapper.valueToTree(ExtPrebid.of(null, ExtImpSmilewanted.of(zoneId))))
+                .build();
+    }
 }

src/test/java/org/prebid/server/it/SmileWantedTest.java

@@ -18,7 +18,7 @@ public class SmileWantedTest extends IntegrationTest {
     @Test
     public void openrtb2AuctionShouldRespondWithBidsFromSmileWanted() throws IOException, JSONException {
         // given
-        WIRE_MOCK_RULE.stubFor(post(urlPathEqualTo("/smilewanted-exchange"))
+        WIRE_MOCK_RULE.stubFor(post(urlPathEqualTo("/smilewanted-exchange/java/someZoneId"))
                 .withRequestBody(equalToJson(jsonFrom("openrtb2/smilewanted/test-smilewanted-bid-request.json")))
                 .willReturn(aResponse().withBody(jsonFrom(
                         "openrtb2/smilewanted/test-smilewanted-bid-response.json"))));

src/test/resources/org/prebid/server/it/test-application.properties

@@ -511,7 +511,7 @@ adapters.smarthub.aliases.artechnology.endpoint=http://localhost:8090/artechnolo
 adapters.smartyads.enabled=true
 adapters.smartyads.endpoint=http://localhost:8090/smartyads-exchange
 adapters.smilewanted.enabled=true
-adapters.smilewanted.endpoint=http://localhost:8090/smilewanted-exchange
+adapters.smilewanted.endpoint=http://localhost:8090/smilewanted-exchange/java/
 adapters.smoot.enabled=true
 adapters.smoot.endpoint=http://localhost:8090/smoot-exchange
 adapters.smrtconnect.enabled=true