Skip to content

Commit 001502b

Browse files
TheTradeDesk adapter should resolve burl if not resolved
1 parent 413779f commit 001502b

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

src/main/java/org/prebid/server/bidder/thetradedesk/TheTradeDeskBidder.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -231,6 +231,7 @@ private static Bid resolvePriceMacros(Bid bid) {
231231
return bid.toBuilder()
232232
.nurl(StringUtils.replace(bid.getNurl(), PRICE_MACRO, priceAsString))
233233
.adm(StringUtils.replace(bid.getAdm(), PRICE_MACRO, priceAsString))
234+
.burl(StringUtils.replace(bid.getNurl(), PRICE_MACRO, priceAsString))
234235
.build();
235236
}
236237
}

src/test/java/org/prebid/server/bidder/thetradedesk/TheTradeDeskBidderTest.java

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -512,7 +512,8 @@ public void makeBidsShouldReplacePriceMacroInNurlAndAdmWithBidPrice() throws Jso
512512
.impid("123")
513513
.price(BigDecimal.valueOf(1.23))
514514
.nurl("http://example.com/nurl?price=${AUCTION_PRICE}")
515-
.adm("<div>Price: ${AUCTION_PRICE}</div>")));
515+
.adm("<div>Price: ${AUCTION_PRICE}</div>")
516+
.burl("http://adsrvr.org/feedback/xxxx?wp=${AUCTION_PRICE}&param2=abc")));
516517

517518
// when
518519
final Result<List<BidderBid>> result = target.makeBids(httpCall, null);
@@ -521,8 +522,8 @@ public void makeBidsShouldReplacePriceMacroInNurlAndAdmWithBidPrice() throws Jso
521522
assertThat(result.getErrors()).isEmpty();
522523
assertThat(result.getValue()).hasSize(1)
523524
.extracting(BidderBid::getBid)
524-
.extracting(Bid::getNurl, Bid::getAdm, Bid::getPrice)
525-
.containsOnly(tuple("http://example.com/nurl?price=1.23", "<div>Price: 1.23</div>", BigDecimal.valueOf(1.23)));
525+
.extracting(Bid::getNurl, Bid::getAdm, Bid::getBurl, Bid::getPrice)
526+
.containsOnly(tuple("http://example.com/nurl?price=1.23", "<div>Price: 1.23</div>", "http://adsrvr.org/feedback/xxxx?wp=1.23&param2=abc", BigDecimal.valueOf(1.23)));
526527
}
527528

528529
@Test
@@ -644,7 +645,8 @@ public void makeBidsShouldHandleNullNurlAndAdm() throws JsonProcessingException
644645
.impid("123")
645646
.price(BigDecimal.valueOf(15.00))
646647
.nurl(null)
647-
.adm(null)));
648+
.adm(null)
649+
.burl(null)));
648650

649651
// when
650652
final Result<List<BidderBid>> result = target.makeBids(httpCall, null);

0 commit comments

Comments
 (0)