improve logging

Signed-off-by: Abhi S <saxena_abhinav@icloud.com>

Author: abhi-dev-engg

test/wycheproof/wycheproof_mldsa.c

@@ -29,6 +29,7 @@
 
 #define MAX_MSG_LENGTH 8192
 #define MAX_CTX_LENGTH 255
+#define MU_LENGTH 64
 
 #define CHECK(x)                                              \
   do                                                          \
@@ -124,7 +125,7 @@ int main(int argc, char *argv[])
 
     if (argc != 3 || decode_hex("seed", seed, sizeof(seed), argv[2]) != 0)
     {
-      printf("decode_error=1\n");
+      printf("decode_error=for seed\n");
       return 0;
     }
 
@@ -149,19 +150,19 @@ int main(int argc, char *argv[])
     mlen = (strlen(argv[2]) - strlen("msg=")) / 2;
     if (mlen > MAX_MSG_LENGTH || decode_hex("msg", msg, mlen, argv[2]) != 0)
     {
-      printf("decode_error=1\n");
+      printf("decode_error=for msg or mlen incorrect\n");
       return 0;
     }
     if (decode_hex("sk", sk, sizeof(sk), argv[3]) != 0)
     {
-      printf("decode_error=1\n");
+      printf("decode_error=for sk\n");
       return 0;
     }
 
     ctxlen = (strlen(argv[4]) - strlen("ctx=")) / 2;
     if (ctxlen > MAX_CTX_LENGTH || decode_hex("ctx", ctx, ctxlen, argv[4]) != 0)
     {
-      printf("decode_error=1\n");
+      printf("decode_error=for ctx or ctxlen incorrect\n");
       return 0;
     }
 
@@ -178,7 +179,7 @@ int main(int argc, char *argv[])
   }
   else if (strcmp(argv[1], "sign_internal") == 0)
   {
-    unsigned char mu[MAX_MSG_LENGTH];
+    unsigned char mu[MU_LENGTH];
     unsigned char sk[CRYPTO_SECRETKEYBYTES];
     unsigned char sig[CRYPTO_BYTES];
     size_t mulen = 0, siglen = 0;
@@ -190,14 +191,14 @@ int main(int argc, char *argv[])
     }
 
     mulen = (strlen(argv[2]) - strlen("mu=")) / 2;
-    if (mulen > MAX_MSG_LENGTH || decode_hex("mu", mu, mulen, argv[2]) != 0)
+    if (mulen != MU_LENGTH || decode_hex("mu", mu, mulen, argv[2]) != 0)
     {
-      printf("decode_error=1\n");
+      printf("decode_error=for mu or mulen incorrect\n");
       return 0;
     }
     if (decode_hex("sk", sk, sizeof(sk), argv[3]) != 0)
     {
-      printf("decode_error=1\n");
+      printf("decode_error=for sk\n");
       return 0;
     }
 
@@ -222,23 +223,23 @@ int main(int argc, char *argv[])
     mlen = (strlen(argv[2]) - strlen("msg=")) / 2;
     if (mlen > MAX_MSG_LENGTH || decode_hex("msg", msg, mlen, argv[2]) != 0)
     {
-      printf("decode_error=1\n");
+      printf("decode_error=for msg or mlen incorrect\n");
       return 0;
     }
     ctxlen = (strlen(argv[3]) - strlen("ctx=")) / 2;
     if (ctxlen > MAX_CTX_LENGTH || decode_hex("ctx", ctx, ctxlen, argv[3]) != 0)
     {
-      printf("decode_error=1\n");
+      printf("decode_error=for ctx or ctxlen incorrect\n");
       return 0;
     }
     if (decode_hex("sig", sig, sizeof(sig), argv[4]) != 0)
     {
-      printf("decode_error=1\n");
+      printf("decode_error=for sig\n");
       return 0;
     }
     if (decode_hex("pk", pk, sizeof(pk), argv[5]) != 0)
     {
-      printf("decode_error=1\n");
+      printf("decode_error=for pk\n");
       return 0;
     }
 
@@ -247,7 +248,7 @@ int main(int argc, char *argv[])
   }
   else if (strcmp(argv[1], "verify_internal") == 0)
   {
-    unsigned char mu[MAX_MSG_LENGTH];
+    unsigned char mu[MU_LENGTH];
     unsigned char sig[CRYPTO_BYTES];
     unsigned char pk[CRYPTO_PUBLICKEYBYTES];
     size_t mulen = 0;
@@ -259,19 +260,19 @@ int main(int argc, char *argv[])
     }
 
     mulen = (strlen(argv[2]) - strlen("mu=")) / 2;
-    if (mulen > MAX_MSG_LENGTH || decode_hex("mu", mu, mulen, argv[2]) != 0)
+    if (mulen != MU_LENGTH || decode_hex("mu", mu, mulen, argv[2]) != 0)
     {
-      printf("decode_error=1\n");
+      printf("decode_error=for mu or mulen incorrect\n");
       return 0;
     }
     if (decode_hex("sig", sig, sizeof(sig), argv[3]) != 0)
     {
-      printf("decode_error=1\n");
+      printf("decode_error=for sig\n");
       return 0;
     }
     if (decode_hex("pk", pk, sizeof(pk), argv[4]) != 0)
     {
-      printf("decode_error=1\n");
+      printf("decode_error=for pk\n");
       return 0;
     }
 
@@ -293,6 +294,6 @@ int main(int argc, char *argv[])
           "  wycheproof_mldsa{lvl} sign_internal mu=HEX sk=HEX\n"
           "  wycheproof_mldsa{lvl} verify msg=HEX ctx=HEX sig=HEX pk=HEX\n"
           "  wycheproof_mldsa{lvl} verify_internal mu=HEX sig=HEX pk=HEX\n");
-          
+
   return 1;
 }