Skip to content

Commit 76fc609

Browse files
authored
fix(dotnet): add config after sdks (#38)
* fix(dotnet): add config after sdks * fix: add dummy config to dotnet test
1 parent 650c4df commit 76fc609

2 files changed

Lines changed: 9 additions & 7 deletions

File tree

features/src/dotnet/installer.go

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -85,12 +85,6 @@ func runMain() error {
8585
}
8686
// Create the feature
8787
feature := installer.NewFeature(".NET", true)
88-
if *nugetConfigPath != "" {
89-
feature.AddComponents(&nugetConfigComponent{
90-
ComponentBase: installer.NewComponentBase("Nuget Config", installer.VERSION_IRRELEVANT),
91-
NugetConfigPath: *nugetConfigPath,
92-
})
93-
}
9488
// add sdks
9589
for _, sdkVersion := range allSdks {
9690
component := &sdkComponent{
@@ -118,6 +112,13 @@ func runMain() error {
118112
}
119113
feature.AddComponents(component)
120114
}
115+
// nuget config
116+
if *nugetConfigPath != "" {
117+
feature.AddComponents(&nugetConfigComponent{
118+
ComponentBase: installer.NewComponentBase("Nuget Config", installer.VERSION_IRRELEVANT),
119+
NugetConfigPath: *nugetConfigPath,
120+
})
121+
}
121122
// workloads
122123
if len(*workloads) > 0 {
123124
feature.AddComponents(&workloadComponent{

features/test/dotnet/scenarios.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,8 @@
88
},
99
"features": {
1010
"./dotnet": {
11-
"version": "8.0"
11+
"version": "8.0",
12+
"nugetConfigPath": "https://raw.githubusercontent.com/postfinance/devcontainer-features/refs/heads/main/override-all.env"
1213
}
1314
}
1415
},

0 commit comments

Comments
 (0)