Skip to content

Commit 6efdff6

Browse files
authored
Merge pull request #386 from plugwise/p1-notify
"Fix" P1 userdata so that the availability is not impacted
2 parents 1d96d2c + b5117c1 commit 6efdff6

File tree

5 files changed

+9
-5
lines changed

5 files changed

+9
-5
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
# Changelog
22

3+
## Ongoing
4+
5+
- Modify the added P1 Plugwise notification so that it does not impact the device-availability
6+
37
## v0.32.2 Continuous improvements, bugfix
48

59
- Extend p1v4_442_triple userdata to include a Plugwise notification, extending the related fixture which is used in PW-beta and Core Plugwise.

fixtures/p1v4_442_triple/all_data.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
"vendor": "Plugwise"
1515
},
1616
"b82b6b3322484f2ea4e25e0bd5f3d61f": {
17-
"available": false,
17+
"available": true,
1818
"dev_class": "smartmeter",
1919
"location": "03e65b16e4b247a29ae0d75a78cb492e",
2020
"model": "XMX5LGF0010453051839",
@@ -53,7 +53,7 @@
5353
"gateway_id": "03e65b16e4b247a29ae0d75a78cb492e",
5454
"notifications": {
5555
"97a04c0c263049b29350a660b4cdd01e": {
56-
"warning": "The Smile P1 does not seem to be connected to a smart meter."
56+
"warning": "The Smile P1 is not connected to a smart meter."
5757
}
5858
},
5959
"smile_name": "Smile P1"
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
22
"97a04c0c263049b29350a660b4cdd01e": {
3-
"warning": "The Smile P1 does not seem to be connected to a smart meter."
3+
"warning": "The Smile P1 is not connected to a smart meter."
44
}
55
}

tests/test_smile.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5191,7 +5191,7 @@ async def test_connect_p1v4_442_triple(self):
51915191
"model": "XMX5LGF0010453051839",
51925192
"name": "P1",
51935193
"vendor": "XEMEX NV",
5194-
"available": False,
5194+
"available": True,
51955195
"sensors": {
51965196
"net_electricity_point": 5553,
51975197
"electricity_consumed_peak_point": 0,

userdata/p1v4_442_triple/core.domain_objects.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -436,7 +436,7 @@
436436
<type>warning</type>
437437
<origin>local</origin>
438438
<title>Smart meter not found.</title>
439-
<message>The Smile P1 does not seem to be connected to a smart meter.</message>
439+
<message>The Smile P1 is not connected to a smart meter.</message>
440440
<valid_from></valid_from>
441441
<valid_to></valid_to>
442442
<read_date>2020-01-23T10:54:59.710+01:00</read_date>

0 commit comments

Comments
 (0)