Add test-method and implement

Author: bouwew

plugwise/__init__.py

@@ -883,13 +883,10 @@ async def set_gateway_mode(self, mode: str) -> None:
         if mode == "full":
             valid = ""
         if mode == "vacation":
-            valid = (
-                "<valid_from>{vacation_time}</valid_from><valid_to>end_time</valid_to>"
-            )
+            valid = f"<valid_from>{vacation_time}</valid_from><valid_to>{end_time}</valid_to>"
 
         uri = f"{APPLIANCES};type=gateway/gateway_mode_control"
         data = f"<gateway_mode_control_functionality><mode>{mode}</mode>{valid}</gateway_mode_control_functionality>"
-        LOGGER.debug("HOI data: %s", data)
 
         await self._request(uri, method="put", data=data)
 

tests/test_adam.py

@@ -345,8 +345,8 @@ async def test_connect_adam_plus_anna_new(self):
         )
         assert not switch_change
 
+        await self.tinker_gateway_mode(smile)
         await self.tinker_regulation_mode(smile)
-
         await self.tinker_max_boiler_temp(smile)
 
         # Now change some data and change directory reading xml from

tests/test_init.py

@@ -687,6 +687,21 @@ async def tinker_temp_offset(smile, dev_id):
             _LOGGER.info("  + tinker_temp_offset failed as intended")
             return False
 
+    @staticmethod
+    async def tinker_gateway_mode(smile):
+        """Toggle gateway_mode to test functionality."""
+        for mode in ["away", "full", "vacation", "!bogus"]:
+            warning = ""
+            if mode[0] == "!":
+                warning = " Negative test"
+                mode = mode[1:]
+            _LOGGER.info("%s", f"- Adjusting gateway mode to {mode}{warning}")
+            try:
+                await smile.set_gateway_mode(mode)
+                _LOGGER.info("  + worked as intended")
+            except pw_exceptions.PlugwiseError:
+                _LOGGER.info("  + found invalid mode, as expected")
+
     @staticmethod
     def validate_test_basics(
         parent_logger,