Skip to content

Commit 0b72765

Browse files
committed
_get_groups(): simplify logic
1 parent f67dfa0 commit 0b72765

File tree

1 file changed

+16
-17
lines changed

1 file changed

+16
-17
lines changed

plugwise/common.py

Lines changed: 16 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -210,23 +210,22 @@ def _get_groups(self) -> None:
210210

211211
if members := self._collect_members(group):
212212
self._new_groups.append(group_id)
213-
214-
if (
215-
group_id in self._existing_groups
216-
and self.gw_entities[group_id]["name"] == group_name
217-
):
218-
continue
219-
220-
group_type = group.find("type").text
221-
if group_type in GROUP_TYPES and members:
222-
self.gw_entities[group_id] = {
223-
"dev_class": group_type,
224-
"model": "Group",
225-
"name": group_name,
226-
"members": members,
227-
"vendor": "Plugwise",
228-
}
229-
self._count += 5
213+
if (
214+
group_id in self._existing_groups
215+
and self.gw_entities[group_id]["name"] == group_name
216+
):
217+
continue
218+
219+
group_type = group.find("type").text
220+
if group_type in GROUP_TYPES:
221+
self.gw_entities[group_id] = {
222+
"dev_class": group_type,
223+
"model": "Group",
224+
"name": group_name,
225+
"members": members,
226+
"vendor": "Plugwise",
227+
}
228+
self._count += 5
230229

231230
removed = list(set(self._existing_groups) - set(self._new_groups))
232231
if self._existing_groups and removed:

0 commit comments

Comments
 (0)