Replace Python 3.5 CI tests with 3.8

Author: jonmmease

.circleci/config.yml

@@ -31,11 +31,11 @@ jobs:
           command: "cd packages/python/plotly; tox -e py27-core"
           no_output_timeout: 20m
 
-  python-3.5-core:
+  python-3.6-core:
     docker:
-      - image: circleci/python:3.5-stretch-node-browsers
+      - image: circleci/python:3.6-stretch-node-browsers
         environment:
-          PLOTLY_TOX_PYTHON_35: python3.5
+          PLOTLY_TOX_PYTHON_36: python3.6
 
     steps:
       - checkout
@@ -44,14 +44,14 @@ jobs:
           command: "sudo pip install tox"
       - run:
           name: Test with tox
-          command: "cd packages/python/plotly; tox -e py35-core"
+          command: "cd packages/python/plotly; tox -e py36-core"
           no_output_timeout: 20m
 
-  python-3.6-core:
+  python-3.7-core:
     docker:
-      - image: circleci/python:3.6-stretch-node-browsers
+      - image: circleci/python:3.7-stretch-node-browsers
         environment:
-          PLOTLY_TOX_PYTHON_36: python3.6
+          PLOTLY_TOX_PYTHON_37: python3.7
 
     steps:
       - checkout
@@ -60,14 +60,14 @@ jobs:
           command: "sudo pip install tox"
       - run:
           name: Test with tox
-          command: "cd packages/python/plotly; tox -e py36-core"
+          command: "cd packages/python/plotly; tox -e py37-core"
           no_output_timeout: 20m
 
-  python-3.7-core:
+  python-3.8-core:
     docker:
-      - image: circleci/python:3.7-stretch-node-browsers
+      - image: circleci/python:3.8-stretch-node-browsers
         environment:
-          PLOTLY_TOX_PYTHON_37: python3.7
+          PLOTLY_TOX_PYTHON_38: python3.8
 
     steps:
       - checkout
@@ -76,7 +76,7 @@ jobs:
           command: "sudo pip install tox"
       - run:
           name: Test with tox
-          command: "cd packages/python/plotly; tox -e py37-core"
+          command: "cd packages/python/plotly; tox -e py38-core"
           no_output_timeout: 20m
 
   python-3.7-percy:
@@ -128,11 +128,11 @@ jobs:
           command: "cd packages/python/plotly; tox -e py27-optional"
           no_output_timeout: 20m
 
-  python-3.5-optional:
+  python-3.6-optional:
     docker:
-      - image: circleci/python:3.5-stretch-node-browsers
+      - image: circleci/python:3.6-stretch-node-browsers
         environment:
-          PLOTLY_TOX_PYTHON_35: python3.5
+          PLOTLY_TOX_PYTHON_36: python3.6
 
     steps:
       - checkout
@@ -141,14 +141,14 @@ jobs:
           command: "sudo pip install tox"
       - run:
           name: Test with tox
-          command: "cd packages/python/plotly; tox -e py35-optional"
+          command: "cd packages/python/plotly; tox -e py36-optional"
           no_output_timeout: 20m
 
-  python-3.6-optional:
+  python-3.7-optional:
     docker:
-      - image: circleci/python:3.6-stretch-node-browsers
+      - image: circleci/python:3.7-stretch-node-browsers
         environment:
-          PLOTLY_TOX_PYTHON_36: python3.6
+          PLOTLY_TOX_PYTHON_37: python3.7
 
     steps:
       - checkout
@@ -157,14 +157,14 @@ jobs:
           command: "sudo pip install tox"
       - run:
           name: Test with tox
-          command: "cd packages/python/plotly; tox -e py36-optional"
+          command: "cd packages/python/plotly; tox -e py37-optional"
           no_output_timeout: 20m
 
-  python-3.7-optional:
+  python-3.8-optional:
     docker:
-      - image: circleci/python:3.7-stretch-node-browsers
+      - image: circleci/python:3.8-stretch-node-browsers
         environment:
-          PLOTLY_TOX_PYTHON_37: python3.7
+          PLOTLY_TOX_PYTHON_38: python3.8
 
     steps:
       - checkout
@@ -173,7 +173,7 @@ jobs:
           command: "sudo pip install tox"
       - run:
           name: Test with tox
-          command: "cd packages/python/plotly; tox -e py37-optional"
+          command: "cd packages/python/plotly; tox -e py38-optional"
           no_output_timeout: 20m
 
   # Plot.ly
@@ -255,23 +255,23 @@ jobs:
       - store_artifacts:
           path: plotly/tests/test_orca/images/linux/failed
 
-  python-3-5-orca:
+  python-3-6-orca:
     docker:
       - image: circleci/node:10.9-stretch-browsers
         environment:
-          PYTHON_VERSION: 3.5
+          PYTHON_VERSION: 3.6
 
     steps:
       - checkout
       - restore_cache:
           keys:
-            - conda-35-v1-{{ checksum ".circleci/create_conda_optional_env.sh" }}
+            - conda-36-v1-{{ checksum ".circleci/create_conda_optional_env.sh" }}
       - run:
           name: Create conda environment
           command: .circleci/create_conda_optional_env.sh
 
       - save_cache:
-          key: conda-35-v1-{{ checksum ".circleci/create_conda_optional_env.sh" }}
+          key: conda-36-v1-{{ checksum ".circleci/create_conda_optional_env.sh" }}
           paths:
             - /home/circleci/miniconda/
       - run:
@@ -518,14 +518,14 @@ workflows:
   build:
     jobs:
       - python-2.7-core
-      - python-3.5-core
       - python-3.6-core
       - python-3.7-core
+      - python-3.8-core
       - python-3.7-percy
       - python-2.7-optional
-      - python-3.5-optional
       - python-3.6-optional
       - python-3.7-optional
+      - python-3.8-optional
       - python-3.7-plot_ly
       - python-2-7-orca
       - python-3-7-orca

packages/python/plotly/tox.ini

@@ -36,7 +36,7 @@
 [tox]
 ; The py{A,B,C}-{X,Y} generates a matrix of envs:
 ;   pyA-X,pyA-Y,pyB-X,pyB-Y,pyC-X,pyC-Y
-envlist = py{27,34,35,36,37}-{core,optional},py{27,34,37}
+envlist = py{27,36,37,38}-{core,optional},py{27,37}
 
 ; Note that envs can be targeted by deps using the <target>: dep syntax.
 ; Only one dep is allowed per line as of the time of writing. The <target>
@@ -84,12 +84,6 @@ commands=
     python --version
     pytest {posargs} plotly/tests/test_core
 
-[testenv:py35-core]
-basepython={env:PLOTLY_TOX_PYTHON_35:}
-commands=
-    python --version
-    pytest {posargs} plotly/tests/test_core
-
 [testenv:py36-core]
 basepython={env:PLOTLY_TOX_PYTHON_36:}
 commands=
@@ -104,6 +98,12 @@ commands=
     pytest {posargs} -x test_init/test_dependencies_not_imported.py
     pytest {posargs} -x test_init/test_lazy_imports.py
 
+[testenv:py38-core]
+basepython={env:PLOTLY_TOX_PYTHON_38:}
+commands=
+    python --version
+    pytest {posargs} plotly/tests/test_core
+
 ; OPTIONAL ENVIRONMENTS
 ;[testenv:py27-optional]
 ;basepython={env:PLOTLY_TOX_PYTHON_27:}
@@ -124,26 +124,26 @@ commands=
     pytest _plotly_utils/tests/
     pytest plotly/tests/test_io
 
-[testenv:py35-optional]
-basepython={env:PLOTLY_TOX_PYTHON_35:}
+[testenv:py36-optional]
+basepython={env:PLOTLY_TOX_PYTHON_36:}
 commands=
     python --version
     pytest {posargs} plotly/tests/test_core
     pytest {posargs} plotly/tests/test_optional
     pytest _plotly_utils/tests/
     pytest plotly/tests/test_io
 
-[testenv:py36-optional]
-basepython={env:PLOTLY_TOX_PYTHON_36:}
+[testenv:py37-optional]
+basepython={env:PLOTLY_TOX_PYTHON_37:}
 commands=
     python --version
     pytest {posargs} plotly/tests/test_core
     pytest {posargs} plotly/tests/test_optional
     pytest _plotly_utils/tests/
     pytest plotly/tests/test_io
 
-[testenv:py37-optional]
-basepython={env:PLOTLY_TOX_PYTHON_37:}
+[testenv:py38-optional]
+basepython={env:PLOTLY_TOX_PYTHON_38:}
 commands=
     python --version
     pytest {posargs} plotly/tests/test_core