Skip to content

Commit e96744b

Browse files
committed
src: robotics: astart, bfs, dijikstra: fixed missing test coverage
1 parent e365ec6 commit e96744b

4 files changed

Lines changed: 40 additions & 17 deletions

File tree

src/robotics/astar/test/astar_test.cpp

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,11 @@ TEST(Astar, ValidSetOccupanciedGrid) {
2626
EXPECT_TRUE(astar.SetOccupiedGrid({{1, 6}}));
2727
}
2828

29+
TEST(Astar, InvalidSetStartAndDestination) {
30+
Astar astar{MotionConstraintType::CARDINAL_MOTION};
31+
EXPECT_FALSE(astar.SetStartAndDestination({0, 0}, {4, 4}));
32+
}
33+
2934
TEST(Astar, FailedToFindPath) {
3035
Astar astar{MotionConstraintType::CARDINAL_MOTION};
3136

src/robotics/astar/test/weighted_astar_test.cpp

Lines changed: 14 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
1-
/*
1+
/*
22
* weighted_astar_test.cpp
3-
*
3+
*
44
* Created on: Jan 02, 2023 11:49
5-
* Description:
6-
*
5+
* Description:
6+
*
77
* Copyright (c) 2023 Pin Loon Lee (pllee4)
8-
*/
8+
*/
99

1010
#include "algorithm/robotics/astar/weighted_astar.hpp"
1111

@@ -28,6 +28,11 @@ TEST(WeightedAstar, ValidSetOccupanciedGrid) {
2828
EXPECT_TRUE(weighted_astar.SetOccupiedGrid({{1, 6}}));
2929
}
3030

31+
TEST(WeightedAstar, InvalidSetStartAndDestination) {
32+
WeightedAstar<weight> weighted_astar{MotionConstraintType::CARDINAL_MOTION};
33+
EXPECT_FALSE(weighted_astar.SetStartAndDestination({0, 0}, {4, 4}));
34+
}
35+
3136
TEST(WeightedAstar, FailedToFindPath) {
3237
WeightedAstar<weight> weighted_astar{MotionConstraintType::CARDINAL_MOTION};
3338

@@ -156,7 +161,8 @@ TEST(WeightedAstar, GetPathAfterReset) {
156161
}
157162

158163
TEST(WeightedAstar, GetPath8Dir) {
159-
WeightedAstar<weight> weighted_astar{MotionConstraintType::CARDINAL_ORDINAL_MOTION};
164+
WeightedAstar<weight> weighted_astar{
165+
MotionConstraintType::CARDINAL_ORDINAL_MOTION};
160166

161167
/**
162168
* s = start, e = end, x = occupied
@@ -201,7 +207,8 @@ TEST(WeightedAstar, GetPathWithRevisit) {
201207
}
202208

203209
TEST(WeightedAstar, GetPath8DirWithRevisit) {
204-
WeightedAstar<weight> weighted_astar{MotionConstraintType::CARDINAL_ORDINAL_MOTION};
210+
WeightedAstar<weight> weighted_astar{
211+
MotionConstraintType::CARDINAL_ORDINAL_MOTION};
205212

206213
/**
207214
* s = start, e = end, x = occupied

src/robotics/best_first_search/test/best_first_search_test.cpp

Lines changed: 16 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,18 @@
1-
/*
1+
/*
22
* best_first_search_test.cpp
3-
*
3+
*
44
* Created on: Jan 04, 2023 21:26
5-
* Description:
6-
*
5+
* Description:
6+
*
77
* Copyright (c) 2023 Pin Loon Lee (pllee4)
8-
*/
8+
*/
99

1010
#include "algorithm/robotics/best_first_search/best_first_search.hpp"
1111

1212
#include "gtest/gtest.h"
1313

1414
using namespace pllee4::graph;
1515

16-
static constexpr uint8_t weight = 10;
17-
1816
TEST(BestFirstSearch, InvalidSetOccupiedGrid) {
1917
BestFirstSearch best_first_search{MotionConstraintType::CARDINAL_MOTION};
2018
EXPECT_FALSE(best_first_search.SetOccupiedGrid({{1, 6}}));
@@ -28,6 +26,11 @@ TEST(BestFirstSearch, ValidSetOccupanciedGrid) {
2826
EXPECT_TRUE(best_first_search.SetOccupiedGrid({{1, 6}}));
2927
}
3028

29+
TEST(BestFirstSearch, InvalidSetStartAndDestination) {
30+
BestFirstSearch best_first_search{MotionConstraintType::CARDINAL_MOTION};
31+
EXPECT_FALSE(best_first_search.SetStartAndDestination({0, 0}, {4, 4}));
32+
}
33+
3134
TEST(BestFirstSearch, FailedToFindPath) {
3235
BestFirstSearch best_first_search{MotionConstraintType::CARDINAL_MOTION};
3336

@@ -156,7 +159,8 @@ TEST(BestFirstSearch, GetPathAfterReset) {
156159
}
157160

158161
TEST(BestFirstSearch, GetPath8Dir) {
159-
BestFirstSearch best_first_search{MotionConstraintType::CARDINAL_ORDINAL_MOTION};
162+
BestFirstSearch best_first_search{
163+
MotionConstraintType::CARDINAL_ORDINAL_MOTION};
160164

161165
/**
162166
* s = start, e = end, x = occupied
@@ -172,7 +176,8 @@ TEST(BestFirstSearch, GetPath8Dir) {
172176
EXPECT_TRUE(best_first_search.GetPath().has_value());
173177
const auto path = best_first_search.GetPath().value();
174178

175-
std::vector<Coordinate> expected = {{0, 2}, {0, 1}, {0, 0}, {1, 0}, {2, 1}, {2, 2}};
179+
std::vector<Coordinate> expected = {{0, 2}, {0, 1}, {0, 0},
180+
{1, 0}, {2, 1}, {2, 2}};
176181
EXPECT_TRUE(std::equal(std::begin(path), std::end(path), std::begin(expected),
177182
std::end(expected)));
178183
}
@@ -201,7 +206,8 @@ TEST(BestFirstSearch, GetPathWithRevisit) {
201206
}
202207

203208
TEST(BestFirstSearch, GetPath8DirWithRevisit) {
204-
BestFirstSearch best_first_search{MotionConstraintType::CARDINAL_ORDINAL_MOTION};
209+
BestFirstSearch best_first_search{
210+
MotionConstraintType::CARDINAL_ORDINAL_MOTION};
205211

206212
/**
207213
* s = start, e = end, x = occupied

src/robotics/dijikstra/test/dijikstra_test.cpp

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,11 @@ TEST(Dijikstra, ValidSetOccupanciedGrid) {
2626
EXPECT_TRUE(dijikstra.SetOccupiedGrid({{1, 6}}));
2727
}
2828

29+
TEST(Dijikstra, InvalidSetStartAndDestination) {
30+
Dijikstra dijikstra{MotionConstraintType::CARDINAL_MOTION};
31+
EXPECT_FALSE(dijikstra.SetStartAndDestination({0, 0}, {4, 4}));
32+
}
33+
2934
TEST(Dijikstra, FailedToFindPath) {
3035
Dijikstra dijikstra{MotionConstraintType::CARDINAL_MOTION};
3136

0 commit comments

Comments
 (0)