From 02fee7718b34fb19fc770ea462a637fcae170789 Mon Sep 17 00:00:00 2001 From: Gordon Franke Date: Thu, 5 Mar 2026 09:35:31 +0100 Subject: [PATCH 1/2] bug: use logger from PlaywrightConfig --- src/Locator/Locator.php | 2 +- src/Page/Page.php | 8 ++++++-- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/src/Locator/Locator.php b/src/Locator/Locator.php index 13072ff..141ce83 100644 --- a/src/Locator/Locator.php +++ b/src/Locator/Locator.php @@ -272,7 +272,7 @@ public function locator(string $selector): self $newSelectorChain = clone $this->selectorChain; $newSelectorChain->append($selector); - return new Locator($this->transport, $this->pageId, $newSelectorChain, $this->frameSelector); + return new Locator($this->transport, $this->pageId, $newSelectorChain, $this->frameSelector, $this->logger); } /** diff --git a/src/Page/Page.php b/src/Page/Page.php index da74311..8461114 100644 --- a/src/Page/Page.php +++ b/src/Page/Page.php @@ -78,6 +78,8 @@ final class Page implements PageInterface, EventDispatcherInterface private PageEventHandlerInterface $eventHandler; + private LoggerInterface $logger; + private ?APIRequestContextInterface $apiRequestContext = null; private bool $isClosed = false; @@ -92,8 +94,10 @@ public function __construct( private readonly BrowserContextInterface $context, private readonly string $pageId, private readonly PlaywrightConfig $config, - private readonly LoggerInterface $logger = new NullLogger(), + ?LoggerInterface $logger = null, ) { + $this->logger = $logger ?? $config->logger ?? new NullLogger(); + $this->keyboard = new Keyboard($this->transport, $this->pageId); $this->mouse = new Mouse($this->transport, $this->pageId); $this->eventHandler = new PageEventHandler(); @@ -204,7 +208,7 @@ public function locator(string $selector, array|LocatorOptions $options = []): L $this->pageId, $selector, null, - null, + $this->logger, $this->normalizeLocatorOptions($options) ); } From 20216ca7f31b12ad62e21117a660531f87a30152 Mon Sep 17 00:00:00 2001 From: Gordon Franke Date: Thu, 5 Mar 2026 10:06:05 +0100 Subject: [PATCH 2/2] bug: waitForCondition() log playwright exception --- src/Locator/Locator.php | 1 + 1 file changed, 1 insertion(+) diff --git a/src/Locator/Locator.php b/src/Locator/Locator.php index 141ce83..55df3be 100644 --- a/src/Locator/Locator.php +++ b/src/Locator/Locator.php @@ -657,6 +657,7 @@ private function waitForCondition(callable $condition, int $timeoutMs, string $m return; } } catch (PlaywrightException $e) { + $this->logger->error($e->getMessage()); } usleep(100000);