From 72198bd6c2ee65b67cb32d14bfc90d04122b1bcb Mon Sep 17 00:00:00 2001 From: "pixeebot[bot]" <104101892+pixeebot[bot]@users.noreply.github.com> Date: Fri, 24 Jan 2025 13:30:49 +0000 Subject: [PATCH 1/2] Use Generator Expressions Instead of List Comprehensions --- src/codemodder/codemods/test/integration_utils.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/codemodder/codemods/test/integration_utils.py b/src/codemodder/codemods/test/integration_utils.py index 4883d8c6..06f85d2b 100644 --- a/src/codemodder/codemods/test/integration_utils.py +++ b/src/codemodder/codemods/test/integration_utils.py @@ -292,8 +292,7 @@ def check_sonar_issues(cls): ) assert any( - [x in sonar_results for x in cls.codemod.requested_rules] - ), f"Make sure to add a sonar issue/hotspot for {cls.codemod.rule_id} in {cls.sonar_issues_json} or {cls.sonar_hotspots_json}" + x in sonar_results for x in cls.codemod.requested_rules), f"Make sure to add a sonar issue/hotspot for {cls.codemod.rule_id} in {cls.sonar_issues_json} or {cls.sonar_hotspots_json}" results_for_codemod = sonar_results[cls.codemod.requested_rules[-1]] file_path = pathlib.Path(cls.code_filename) assert ( From c225a920a4c4000a399c1eeffa0f482462cf0a48 Mon Sep 17 00:00:00 2001 From: "pixeebot[bot]" <104101892+pixeebot[bot]@users.noreply.github.com> Date: Fri, 24 Jan 2025 13:31:09 +0000 Subject: [PATCH 2/2] :art: Apply formatting --- src/codemodder/codemods/test/integration_utils.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/codemodder/codemods/test/integration_utils.py b/src/codemodder/codemods/test/integration_utils.py index 06f85d2b..9de54b1e 100644 --- a/src/codemodder/codemods/test/integration_utils.py +++ b/src/codemodder/codemods/test/integration_utils.py @@ -292,7 +292,8 @@ def check_sonar_issues(cls): ) assert any( - x in sonar_results for x in cls.codemod.requested_rules), f"Make sure to add a sonar issue/hotspot for {cls.codemod.rule_id} in {cls.sonar_issues_json} or {cls.sonar_hotspots_json}" + x in sonar_results for x in cls.codemod.requested_rules + ), f"Make sure to add a sonar issue/hotspot for {cls.codemod.rule_id} in {cls.sonar_issues_json} or {cls.sonar_hotspots_json}" results_for_codemod = sonar_results[cls.codemod.requested_rules[-1]] file_path = pathlib.Path(cls.code_filename) assert (