Skip to content

Commit b5196c8

Browse files
committed
Move FixQuality and Rating to common codetf module
1 parent 708f972 commit b5196c8

File tree

3 files changed

+13
-23
lines changed

3 files changed

+13
-23
lines changed

src/codemodder/codetf/common.py

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,3 +84,14 @@ def validate_description(self):
8484
if self.description is not None and not self.description:
8585
raise ValueError("description must not be empty")
8686
return self
87+
88+
89+
class Rating(BaseModel):
90+
score: int
91+
description: Optional[str] = None
92+
93+
94+
class FixQuality(BaseModel):
95+
safetyRating: Rating
96+
effectivenessRating: Rating
97+
cleanlinessRating: Rating

src/codemodder/codetf/v2/codetf.py

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
from ..common import Change as CommonChange
2222
from ..common import (
2323
CodeTFWriter,
24+
FixQuality,
2425
Rule,
2526
)
2627

@@ -104,17 +105,6 @@ class Strategy(Enum):
104105
deterministic = "deterministic"
105106

106107

107-
class Rating(BaseModel):
108-
score: int
109-
description: Optional[str] = None
110-
111-
112-
class FixQuality(BaseModel):
113-
safetyRating: Rating
114-
effectivenessRating: Rating
115-
cleanlinessRating: Rating
116-
117-
118108
class ChangeSet(BaseModel):
119109
"""A set of changes made to a file at `path`"""
120110

src/codemodder/codetf/v3/codetf.py

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
from pydantic import BaseModel, model_validator
77

8-
from ..common import Change, CodeTFWriter, Finding
8+
from ..common import Change, CodeTFWriter, Finding, FixQuality
99
from ..v2.codetf import Finding as V2Finding
1010

1111

@@ -92,17 +92,6 @@ class FixMetadata(BaseModel):
9292
generation: GenerationMetadata
9393

9494

95-
class Rating(BaseModel):
96-
score: int
97-
description: Optional[str] = None
98-
99-
100-
class FixQuality(BaseModel):
101-
safetyRating: Rating
102-
effectivenessRating: Rating
103-
cleanlinessRating: Rating
104-
105-
10695
class FixResult(BaseModel):
10796
"""Result corresponding to a single finding"""
10897

0 commit comments

Comments
 (0)